Log In - Home Page

Patch: plpgsql: returning row expression

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2012-11
Topic Procedural Languages
Patch Status Committed
Author Asif Rehman
Reviewers Pavel Stehule
Committer Tom Lane
Close Date 2012-12-07
Patch by asif.rana on 2012-11-12 05:43:55 PM: Initial version.
Review by okbobcz on 2012-11-20 09:01:43 PM: there is a performance issue, and RETURN NEXT is not supported
Patch by asif.rana on 2012-11-22 05:59:29 PM: submitted an updated version.
Patch by asif.rana on 2012-11-23 08:14:57 AM: Included the documentation changes. forgot to include in earlier patch.
Review by okbobcz on 2012-11-23 12:03:47 PM: no objection
Review by alvherre on 2012-11-28 06:20:36 PM: should get cast functions only once. And what about other users of tupconvert?
Patch by asif.rana on 2012-12-03 07:19:18 PM: done the suggested changes.
Comment by okbobcz on 2012-12-04 08:50:04 PM: new conversions produces wrong result or crash
Patch by asif.rana on 2012-12-04 09:06:05 PM: updated patch. fixed the bug.
Comment by okbobcz on 2012-12-05 08:51:10 AM: no objection
Comment by tgl on 2012-12-05 08:53:08 PM: Not happy with the coercion semantics this version embodies.
Patch by asif.rana on 2012-12-06 09:20:47 PM: stripped-down version. removed the type coercions support from tupconvert.

Add Comment

Please log in to comment on this patch.