Log In - Home Page

Patch: Patch to compute Max LSN of Data Pages (from 2012-11)

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-09
Topic System Administration
Patch Status Returned with Feedback
Author Amit Kapila, Hari Babu
Reviewers Robert Haas
Committer Robert Haas
Close Date 2013-10-18
Patch by amitkapila on 2012-08-13 09:47:49 AM: Initial version.
Comment by amitkapila on 2012-08-13 09:51:30 AM: This patch is for providing an option in pg_resetxlog to compute the value of MAX LSN of data pages. It can be helpful incase the data pages are corrupted. User can use the LSN value to resetxlog for DB which will minimise the chances of further corruption.
Patch by amitkapila on 2012-08-29 12:10:00 PM: Documentation update patch and test cases.
Patch by amitkapila on 2012-11-16 11:41:38 AM: updated version to have pg_computemaxlsn as a separate utility.
Review by muhammad usama on 2012-11-23 12:37:48 AM: Some review observations and comments need to be addressed.
Patch by amitkapila on 2012-11-27 01:33:31 PM: updated patch to address review comments.
Patch by amitkapila on 2012-12-06 03:36:47 AM: updated patch to handle review comment for making file path relative to current working direcory.
Patch by amitkapila on 2012-12-09 05:44:24 AM: updated patch to handle absolute path.
Comment by ringerc on 2013-01-18 03:03:17 AM: Emailed author to verify that patch is still good to proceed
Patch by amitkapila on 2013-01-19 05:37:34 AM: Re-based to latest head.
Comment by ringerc on 2013-01-21 02:46:34 AM: Further revision pending
Patch by amitkapila on 2013-01-21 04:11:26 PM: Fixed the typo errors.
Comment by tgl on 2013-04-11 03:37:16 PM: Not everybody is convinced that we want this at all.
Review by rhaas on 2013-07-02 07:56:19 PM: needs a lot of work
Patch by haribabu on 2013-07-04 09:21:23 AM: patch with review comments fix.
Patch by haribabu on 2013-07-08 10:50:21 AM: Updated patch
Patch by haribabu on 2013-07-08 12:14:49 PM: wrong use case removed patch
Patch by amitkapila on 2013-09-14 07:14:22 AM: updated patch to resolve windows build issue
Comment by rhaas on 2013-10-09 06:29:03 PM: patch looks technically OK, but do we have enough consensus to move forward?
Review by rhaas on 2013-10-18 03:32:27 PM: still no consensus; and some other review comments and directional thoughts

Add Comment

Please log in to comment on this patch.