Log In - Home Page

Patch: async notifications for dblink

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2009-07
Topic Contrib modules
Patch Status Committed
Author Marcus Kempe
Reviewers Joe Conway
Committer Nobody
Close Date 2009-08-05
Comments
Patch by marcus.kempe on 2008-11-18 11:47:28 PM: Initial version
Comment by jconway on 2009-07-21 08:41:59 PM: I plan to review this around the 31 July or 1 August. I'll have only intermittent internet access between now and then.
Review by jconway on 2009-08-03 07:43:32 PM: Had to fix lots of bit rot, but otherwise looks good. Will post a new patch to HACKERS, and commit in a day or so if I don't see any objections.
Patch by jconway on 2009-08-03 08:35:59 PM: updated version
Comment by jconway on 2009-08-03 08:42:57 PM: Tom Lane wrote:

[ thinks for awhile... ] Actually, it seems to me that the present
patch's definition of the function would be very hard to work with.
You would normally want to work with the events one at a time.
There isn't much you could do with the array result except unnest() it,
and I'm a bit worried that careless usage could result in multiple
evaluation of the function and hence loss of events. I wonder whether
it would be better to have the function return setof record. Which, not
incidentally, would greatly simplify adding in those extra result
fields.
Comment by jconway on 2009-08-03 08:43:13 PM: will revise per Tom's comment
Patch by jconway on 2009-08-03 10:34:04 PM: new patch based on Tom's excellent (as usual) suggestion.
Patch by jconway on 2009-08-04 08:03:01 AM: Modified to use OUT params instead of a custom rowtype per Alvaro's suggestion.
Patch by jconway on 2009-08-04 09:00:56 PM: Modified to make regression test more useful...last call for comments

Add Comment

Please log in to comment on this patch.