Log In - Home Page

Patch: URI connection string support for libpq

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2012-01
Topic Clients
Patch Status Committed
Author Alex Shulgin
Reviewers Greg Smith, Nick Roosevelt, Christopher Maujean, Daniel Farina
Committer Álvaro Herrera
Close Date 2012-04-11
Comments
Patch by ash on 2011-12-12 10:08:24 PM: Initial version.
Review by nroose on 2012-01-13 04:08:23 AM: Seems like the file has changed since this patch was created. Please recreate the patch.
Comment by ash on 2012-01-19 06:31:29 PM: The original patch applies cleanly, please try again.
Review by gsmith on 2012-02-22 05:27:18 PM: Early regression test samples, suggestions for smoothing edge cases
Review by pvh on 2012-02-23 11:35:27 PM: Not much to add to gsmith's review. Applies cleanly and works fine on my system.
Patch by ash on 2012-02-24 02:05:40 PM: Updated, v4.
Patch by ash on 2012-02-28 06:46:57 PM: Updated, v5.
Patch by ash on 2012-03-07 04:32:23 PM: v6
Patch by ash on 2012-03-07 09:57:11 PM: v7: added regression test, fixed a minor bug, simplified some code.
Patch by ash on 2012-03-15 02:38:29 PM: v8: incorporated changes by Daniel, added more sanity checks, improved tests.
Comment by fdr on 2012-03-16 12:40:55 AM: No known correctness or functionality issues remain, AFAIK.
Comment by ash on 2012-03-19 01:41:43 PM: Changed status to 'Waiting on Author' since the patch misses documentation changes.
Comment by markokr on 2012-03-19 08:52:35 PM: Basic use-case not implemented: PQconnectdb()
Patch by ash on 2012-03-22 09:45:48 PM: v9: fix PQconnectdb usecase; rebase against master.
Patch by ash on 2012-03-27 10:51:29 PM: v10: fix minor issues found by Heikki Linnakangas, use a fix from Peter Eisentraut, update documentation(!) Needs a final (hopefully) review.

Add Comment

Please log in to comment on this patch.