Log In - Home Page

Patch: ECPG FETCH readahead

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2012-06
Topic Clients
Patch Status Returned with Feedback
Author Zoltán Böszörményi
Reviewers Noah Misch
Committer Michael Meskes
Close Date 2012-06-13
Comments
Patch by zboszor on 2011-11-16 08:02:08 PM: Initial version.
Patch by zboszor on 2011-12-29 10:48:07 AM: - documented the new ECPG_INVALID_CURSOR error code
- consistently free everything in error paths in cursor.c
Review by nmisch on 2012-03-02 04:43:45 PM: Enable by default? Don't scan entire result to populate sqlerrd[2]. ECPGFETCHSZ trivially broken. Needs more comments. Corner cases, cosmetic points.
Comment by rhaas on 2012-03-15 08:59:30 PM: ping
Comment by zboszor on 2012-03-24 09:50:33 AM: pong with new patch
Review by nmisch on 2012-03-29 12:45:46 AM: Policy questions regarding the various ways of enabling these features. Doc cosmetic points. Nonetheless, ready for a committer's eyes.
Patch by zboszor on 2012-03-29 12:16:05 PM: Fixed some cosmetic points, explained policy
Patch by zboszor on 2012-03-30 04:23:11 AM: No 0-vs-1 distinction in the runtime. Less MOVEs. Documentation updates.
New 2nd patch without NO READAHEAD and modified docs.
Comment by meskes on 2012-04-24 08:10:58 AM: Zoltan himself found a hole and has to redo parts of the patch

Add Comment

Please log in to comment on this patch.