Log In - Home Page

Patch: CHECK FUNCTION statement

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2011-11
Topic Server Features
Patch Status Returned with Feedback
Author Pavel Stehule
Reviewers Laurenz Albe
Committer Nobody
Close Date 2011-12-16
Patch by tgl on 2011-10-29 03:25:01 AM: Initial version.
Review by laurenz on 2011-11-22 02:18:22 PM: Patch does not apply to current master.
Patch by okbobcz on 2011-11-26 12:44:04 PM: refreshed patch
Review by laurenz on 2011-11-29 03:25:26 PM: Patch fails initdb, lacks documentation.
Patch by tgl on 2011-11-29 11:41:20 PM: updated patch
Review by laurenz on 2011-11-30 07:27:30 PM: Patch lacks documentation, relationship to validator function is unclear, checks don't cover everything possible.
Patch by laurenz on 2011-11-30 07:28:21 PM: updated patch with documentation
Comment by laurenz on 2011-11-30 07:34:13 PM: Tom says: not all cases have to be covered initially, there should be a way to pass language-specific options to CHECK FUNCTION.
Review by laurenz on 2011-12-07 03:33:06 PM: Lacks documentation. I'll try to write some.
Patch by laurenz on 2011-12-09 10:54:49 AM: Allow "CHECK FUNCTION ALL" (ignoring pg_catalog and information_schema), ignore SQL functions
Review by laurenz on 2011-12-09 12:27:58 PM: Patch does not apply cleanly, compiler warnings, bugs in statement parsing.
Patch by okbobcz on 2011-12-10 06:56:30 AM: fixed bugs,
merge documentation
update to last changes in HEAD
Review by laurenz on 2011-12-13 11:15:18 AM: Works fine, still lacks support for options.
Patch by okbobcz on 2011-12-14 07:07:35 AM: option support
Review by laurenz on 2011-12-14 03:53:56 PM: fails regression tests, option "quite" is misspelt and seems not useful
Review by laurenz on 2011-12-15 01:41:26 PM: crashes on functions defined with a SET clause
Patch by laurenz on 2011-12-15 01:42:46 PM: new patch without "quiet" option, fix for the crash and improvements for SECURITY DEFINER functions
Review by laurenz on 2011-12-16 03:05:43 PM: Bug if CHECK FUNCTION ALL finds no function, oddness about option "fatal_errors"

Add Comment

Please log in to comment on this patch.