Log In - Home Page

Patch: Optimizing pg_trgm makesign()

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2011-09
Topic GiST
Patch Status Rejected
Author Heikki Linnakangas
Reviewers Kevin Grittner
Committer Nobody
Close Date 2011-10-01
Comments
Patch by heikki on 2011-06-24 04:53:15 PM: Initial version.
Review by kgrittn on 2011-09-25 10:43:38 PM: Patch looks good; performance gains on dictionary and normal text; no regression on short strings.
Comment by kgrittn on 2011-09-26 02:37:24 AM: Changed back to review status because other versions of patch exist which weren't listed in CF app.
Patch by kgrittn on 2011-09-26 02:39:17 AM: Tom reviews and offers alternative patch.
Patch by kgrittn on 2011-09-26 02:40:31 AM: Tom offers patch not quite as fast but more robust in the face of header changes.
Patch by kgrittn on 2011-09-26 02:44:22 AM: Heikki submits patch optimized for x64.
Comment by kgrittn on 2011-09-26 02:46:47 AM: Tom expresses concern about performance of Heikki's patch on 32-bit systems, and expresses concern about changes to HASH macros.
Review by kgrittn on 2011-09-29 06:32:52 PM: Tom's 1st patch improves on Heikki's first patch. Tom's 2nd patch erases performance gain for actual English text. Heikki's 2nd patch crashes on 32-bit compiles. Can either 2nd patch be salvaged?
Comment by tgl on 2011-10-01 04:05:20 AM: Heikki's later idea (eliminate all the redundant calls of makesign) pretty much obsoletes this idea.

Add Comment

Please log in to comment on this patch.