Log In - Home Page

Patch: log_csv_fields ; add current_role log option

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2011-01
Topic Miscellaneous
Patch Status Returned with Feedback
Author Stephen Frost
Reviewers Itagaki Takahiro
Committer Robert Haas
Close Date 2011-02-17
Patch by sfrost on 2011-01-19 09:09:55 PM: Initial version.
Patch by sfrost on 2011-01-19 09:11:28 PM: Latest patch which includes adding a new GUC (log_csv_options), making the list of fields and the order in which they appear in the CSV output configurable by the user. Also includes the (now relatively minor) improvement to allow logging of the current_role.
Review by itagaki on 2011-01-24 04:59:57 AM: Some discussions and requests for code cleanup.
Patch by sfrost on 2011-01-29 07:49:02 AM: Updated patch posted.
Comment by itagaki on 2011-02-02 03:09:19 AM: Will we have a very long line in postgresql.conf?
Patch by sfrost on 2011-02-06 01:54:22 PM: Updated patch posted which improves the documentation.
Review by itagaki on 2011-02-10 05:15:33 AM: The core feature is OK, but needs more comments for cosmetic issues.
Patch by sfrost on 2011-02-11 03:23:44 PM: Updated patch including a bit of rework around how CSV are generated and changed GUC to csvlog_fields instead of log_csv_fields.
Review by rhaas on 2011-02-13 07:44:54 AM: review
Patch by sfrost on 2011-02-13 09:50:47 PM: Updated patch.
Patch by sfrost on 2011-02-14 09:17:11 AM: Updated patch for some minor issues (based on additional review by Itagaki).
Comment by itagaki on 2011-02-15 12:55:53 AM: Ready for Committer, with a few notes.
Comment by rhaas on 2011-02-16 04:07:44 PM: Still no consensus.
Comment by rhaas on 2011-02-17 10:26:00 AM: More problems.
Patch by rhaas on 2011-02-17 02:31:07 PM: Fixed some problems. New patch. Still not sure.

Add Comment

Please log in to comment on this patch.