Log In - Home Page

Patch: Prevent renaming on multiple inherited column

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2010-01
Topic Miscellaneous
Patch Status Committed
Author KaiGai Kohei
Reviewers Bernd Helmle
Committer Robert Haas
Close Date 2010-02-01
Comments
Patch by kaigai on 2009-12-17 06:15:19 PM: Initial version.
Review by rhaas on 2009-12-29 07:57:00 PM: no longer applies
Patch by kaigai on 2010-01-02 09:36:00 AM: Rebased revision
Patch by kaigai on 2010-01-04 04:14:42 AM: Fix matter in the diamond inheritance tree
Patch by kaigai on 2010-01-14 01:16:07 AM: It fixes both of problems in RENAME/ALTER ... TYPE.
Review by psoo on 2010-01-23 12:57:50 PM: Minor fixes, patch seems ready for committer
Comment by rhaas on 2010-01-23 09:39:42 PM: No response to Tom's concerns. Needs perf. testing.
Review by psoo on 2010-01-25 03:46:39 AM: Performance testing in progress
Patch by kaigai on 2010-01-27 03:02:23 AM: Revised patch. It computes expected inhcounts only when find_all_inheritors_with_inhcount()
Review by rhaas on 2010-01-27 04:09:14 PM: Logic is wrong - here's a case where it breaks.
Patch by kaigai on 2010-01-31 10:09:52 PM: Revised patch. Logic and performance issues are solved, and ALTER COLUMN TYPE issue was separated to.
Patch by rhaas on 2010-02-01 12:12:09 PM: the version I intend to commit

Add Comment

Please log in to comment on this patch.