Log In - Home Page

Patch: pgbench setshell command

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2009-11
Topic Tools
Patch Status Committed
Author Michael Paquier
Reviewers Greg Smith
Committer Itagaki Takahiro
Close Date 2009-12-15
Comments
Patch by michael-kun on 2009-10-26 01:15:03 AM: Initial version.
Review by gsmith on 2009-12-02 01:15:22 AM: Patch has become useful already, list of small to medium issues to be resolved
Patch by michael-kun on 2009-12-03 06:06:45 PM: Most of the issues resolved.
Still persists a problem with threads cleared when a variable is read with respipe from setshell. The code will be a little bit reorganized, doCustom is too heavy.
Comment by gsmith on 2009-12-05 07:28:20 PM: Suggestions on variable substitution
Patch by michael-kun on 2009-12-06 11:18:35 PM: Code refactoring, variable substitution stuff completed, thread problem corrected and documentation updated
Patch by itagaki on 2009-12-10 02:45:07 AM: Fix bugs and cleanup.
Patch by michael-kun on 2009-12-14 07:30:57 PM: A couple of minor issues cleaned up
Patch by michael-kun on 2009-12-14 11:39:59 PM: Variable name check added when a variable is put in pgbench. It has to be written with numerical, alphabet or underscore characters.

Add Comment

Please log in to comment on this patch.