Log In - Home Page

Patch: Incorrect behavior with system-column reference in postgres_fdw

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-10
Topic Bug Fixes
Patch Status Committed
Author Etsuro Fujita
Reviewers Ashutosh Bapat
Committer Tom Lane
Close Date 2014-11-22
Comments
Patch by efujita on 2014-10-14 02:30:44 AM: Initial version.
Patch by efujita on 2014-10-14 02:33:14 AM: Updated version
Patch by efujita on 2014-11-12 07:32:07 AM: Split patch into two according to the comment by Ashutosh
Patch by efujita on 2014-11-18 08:29:48 AM: Updated patch postgres_fdw-syscol-v2.patch addressing the comments from Ashutosh
Review by ashutosh_bapat on 2014-11-19 09:20:41 AM: Instead of using rel->reltargetlist, tlist passed as argument to create_foreignscan_plan() should be used in this function. The reasons for the same are discussed in the review mails. Fujita-san suggested that this should be left to the commiter to decide.
Review by efujita on 2014-11-19 11:10:24 AM: See the above discussion here.

Add Comment

Please log in to comment on this patch.