Log In - Home Page

Patch: psql: Unicode UTF-8 table formatting for text output

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2009-09
Topic Clients
Patch Status Committed
Author Roger Leigh
Reviewers Brad Sliger
Committer Nobody
Close Date 2009-10-13
Patch by rleigh on 2009-08-23 03:31:48 AM: Initial version, psql-utf8-table-1.patch.
Patch by rleigh on 2009-08-23 04:43:52 AM: psql-utf8-table-1-8.4rel.patch (patch 1 re-diffed against REL8_4_STABLE)
Patch by rleigh on 2009-08-25 06:22:12 AM: psql-utf8-table-2.patch: Updated patch to rectify criticisms made on list.
Patch by rleigh on 2009-09-10 12:03:02 PM: psql-utf8-table-3.patch: Updated patch to handle line wrapping and newlines in data.
Patch by rleigh on 2009-09-23 03:45:51 AM: psql-utf8-table-4: Address review comments about lint warnings. Remove two spurious commas at the end of lists.
Comment by tgl on 2009-09-29 03:36:30 PM: Per thread here, this will make the regression tests fail if environment selects a UTF8 locale ... we should not apply until that's dealt with. The patch proposed here is not quite right though.
Comment by rhaas on 2009-09-29 04:43:23 PM: I think we should probably mark this Returned with Feedback.
Patch by rleigh on 2009-10-02 06:39:04 AM: psql-utf8-table-5: Address issues with failing "make check" by adding a pset variable "tablestyle" to allow forcing of the table style to "ascii" in the testsuite, which will additionally permit user configuration in their .psqlrc
Review by rhaas on 2009-10-03 07:10:47 PM: A few more comments from Brad Sliger.
Patch by rleigh on 2009-10-05 01:55:00 PM: Rename option to "linestyle" and use client encoding rather than locale codeset
Patch by rleigh on 2009-10-06 12:43:24 PM: psql-utf8-table-9.patch: Remove now unneeded langinfo header use
Review by rleigh on 2009-10-08 07:55:21 AM: Review from Brad Sliger.
Patch by rleigh on 2009-10-11 02:55:59 PM: psql-utf8-table-10.patch: Rename utf-8 to unicode in user-visible situations, and remove references to "locale" from documentation.
Comment by tgl on 2009-10-13 12:33:36 PM: Taking this one ...

Add Comment

Please log in to comment on this patch.