Log In - Home Page

Patch: Change GUC context of log_disconnections

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-08
Topic Miscellaneous
Patch Status Committed
Author Fujii Masao
Reviewers Joe Conway, Amit Kapila
Committer Tom Lane
Close Date 2014-09-14
Comments
Patch by masaofujii on 2014-06-13 02:07:37 PM: Initial version.
Comment by jconway on 2014-06-21 03:44:28 AM: The documentation change to log_connections is incorrect:

test=# set log_connections = on;
ERROR: parameter "log_connections" cannot be set after connection start
test=# select current_user;
current_user
--------------
postgres
(1 row)
Comment by jconway on 2014-06-21 03:48:34 AM: For that matter, the change to log_disconnections is unnecessary too:

test=# set log_disconnections = on;
ERROR: parameter "log_disconnections" cannot be set after connection start
Comment by masaofujii on 2014-07-02 06:57:15 AM: Explained the problem which I'd like to address, again.
Patch by masaofujii on 2014-07-02 07:46:42 PM: Attached the patch which changes the context of log_disconnections to PGC_SIGHUP
Patch by masaofujii on 2014-08-05 02:35:47 PM: I attached the patch which introduces PGC_SU_BACKEND context.
Review by amitkapila on 2014-08-24 06:09:47 AM: one bug and minor coding issue.
Patch by masaofujii on 2014-08-27 11:50:17 AM: Updated version of the patch.
Review by amitkapila on 2014-08-29 01:04:47 PM: Latest patch seems to cause regression failure.
Comment by amitkapila on 2014-09-06 07:55:37 AM: All the comments except one comment change raised for patch are fixed. So marking it as Ready For Committer.

Add Comment

Please log in to comment on this patch.