Log In - Home Page

Patch: Abbreviated keys (Was: Sort support for text with strxfrm() poor man's keys)

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-12
Topic Server Features
Patch Status Committed
Author Peter Geoghegan
Reviewers Robert Haas
Committer Robert Haas
Close Date 2015-01-19
Comments
Patch by pgeoghegan on 2014-06-06 12:40:08 AM: Initial version.
Patch by pgeoghegan on 2014-07-27 07:02:02 AM: Revision of patch addressing open item - win32 non-"C" collation handling
Review by rhaas on 2014-07-30 06:11:50 PM: code license concern, patch needs splitting, other concerns
Patch by pgeoghegan on 2014-08-01 11:02:57 PM: New "Abbreviated keys" revision, with improved, better principled abort logic. New name. Some clarification of why optimization may not be used in certain places.
Patch by pgeoghegan on 2014-08-02 11:36:09 PM: Patch is split in two. Basic fmgr-trampoline-eliding sortsupport for text in the first, and abbreviated keys optimization in the second.
Patch by pgeoghegan on 2014-08-07 06:33:59 PM: Patch set rebased on top of 1d41739e5a04b0e93304d24d864b6bfa3efc45f2
Review by rhaas on 2014-08-22 02:20:12 PM: needs a rebase
Patch by pgeoghegan on 2014-09-02 05:34:58 PM: Rebased patch
Review by rhaas on 2014-09-02 07:25:53 PM: review
Patch by pgeoghegan on 2014-09-03 02:28:20 AM: Revision principally addressing stylistic concerns
Patch by pgeoghegan on 2014-09-06 10:03:59 PM: Revision that formally proposes an opportunistic "memcmp() == 0" comparison in all instances, and not just for abbreviated key tie-breakers
Comment by heikki on 2014-09-11 11:10:45 AM: Need some performance testing to see if testing for equality with memcmp() before calling strcoll() is a good idea.
Comment by pgeoghegan on 2014-09-14 08:46:02 PM: Equality with memcmp() before calling strcoll() shown to be virtually free
Patch by pgeoghegan on 2014-09-15 11:22:47 PM: Much smaller patch that breaks out entirely opportunistic "memcmp() == 0" check.
Patch by pgeoghegan on 2014-09-30 05:38:46 AM: Patch that arranges to only have a single sortsupport state
Patch by pgeoghegan on 2014-10-12 01:36:31 AM: Patch that integrates abbreviated keys with a quasi-independent effort to make the B-Tree and CLUSTER cases use sortsupport. Similar benefits (and costs) to the MinimalTuple case.
Patch by pgeoghegan on 2014-11-10 03:03:38 AM: Rebased patch
Patch by pgeoghegan on 2014-12-03 01:29:22 AM: Revision with minor tweaks requested by Robert

Add Comment

Please log in to comment on this patch.