Log In - Home Page

Patch: Triggers on foreign tables

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-01
Topic Server Features
Patch Status Committed
Author Ronan Dunklau
Reviewers Noah Misch, KaiGai Kohei
Committer Noah Misch
Close Date 2014-03-23
Comments
Patch by rdunklau on 2014-01-07 04:31:59 PM: Initial version.
Review by nmisch on 2014-01-17 10:14:50 PM: AFTER ROW support should be removed or redesigned to give standard firing timing. Suggested borrowing from INSTEAD OF triggers the method for making available the old tuple.
Patch by rdunklau on 2014-01-23 02:35:21 PM: Redesigned AFTER ROW support to give standard firing time. Uses the same approach as INSTEAD OF to keep the old tuple.
Patch by rdunklau on 2014-01-29 11:46:40 AM: Prevents overflow when more than INT_MAX tuples are stored, and other recommendation from Kouhei Kaigai.
Comment by petere on 2014-01-31 02:47:54 AM: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/343/
Review by nmisch on 2014-01-31 05:03:54 AM: Use a tuplestore per AfterTriggerBeginQuery() instead of per xact?
Patch by rdunklau on 2014-02-02 10:55:25 AM: Use a tuplestore per query instead of per xact, and other recommendations from nmisch.
Patch by rdunklau on 2014-02-06 06:32:34 AM: Add proper cleaning in EndSubXact and minor optimizations.
Patch by nmisch on 2014-03-17 06:21:45 PM: Revise numerous details. Open issues: system columns, informing FDW that it must return all columns

Add Comment

Please log in to comment on this patch.