Log In - Home Page

Patch: pg_ctl always uses the same event source

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-06
Topic Monitoring & Control
Patch Status Committed
Author MauMau
Reviewers Amit Kapila
Committer mha
Close Date 2014-07-17
Patch by maumau on 2013-12-08 10:20:26 PM: Initial version.
Patch by maumau on 2013-12-13 02:01:44 PM: correction and code cleanup thanks to Amit Kapila's review
Patch by maumau on 2013-12-23 01:35:39 PM: some minor corrections according to Amit's review
Comment by petere on 2014-01-11 07:09:26 PM: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/294/
Patch by maumau on 2014-01-23 10:06:14 PM: prevent duplicate registration of the same event source, suggested by Amit Kapila
Patch by maumau on 2014-01-24 02:12:05 PM: Prevent duplicate registration of the same event source, suggested by Amit Kapila
Review by amitkapila on 2014-01-29 05:13:10 AM: few minor comments and suggestion to remove the new handling for Default event source as others are not convinced.
Patch by maumau on 2014-01-31 02:59:31 PM: Revert the default event source to PostgreSQL, and correct some fixes.
Comment by andresfreund on 2014-02-15 01:49:27 PM: Tom thinks the entire patch should be rejected.
Comment by amitkapila on 2014-03-11 03:34:02 AM: Objectionable parts are already removed.
Comment by tgl on 2014-04-04 11:29:15 PM: Dubious about the pg_ctl end of it
Comment by amitkapila on 2014-04-10 04:01:57 AM: As per Tom's suggestion, if this bug needs to fixed, it is better to use a new switch for it in pg_ctl.
Patch by maumau on 2014-04-12 08:00:53 AM: Follow Tom's suggestion and add a switch to pg_ctl
Patch by maumau on 2014-04-18 11:56:02 AM: Removed unnecessary function declaration
Review by amitkapila on 2014-05-04 03:11:43 PM: Few minor comments.
Patch by maumau on 2014-05-08 11:35:03 AM: Improve doc, and remove compilation errors on Linux
Review by mha on 2014-07-15 12:16:44 PM: Needs decision about location of parameters

Add Comment

Please log in to comment on this patch.