Log In - Home Page

Patch: Extend createuser to associate a new role with other roles

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-11
Topic Clients
Patch Status Committed
Author Christopher Browne
Reviewers Amit Kapila, Sameer Thakur
Committer Robert Haas
Close Date 2013-12-11
Comments
Patch by cbbrowne on 2013-09-27 10:19:03 PM: Initial version.
Comment by samthakur74 on 2013-11-14 10:58:49 AM: While testing -g got error createuser: invalid option -- 'g'
Seems to work fine with --roles
Patch by cbbrowne on 2013-11-14 09:38:25 PM: Here is a revised patch that alters the call to getopts_long() to include the '-g' option properly.
Comment by petere on 2013-11-15 08:14:59 PM: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/217/
Patch by cbbrowne on 2013-11-15 11:29:33 PM: Patch revised to include run of pgindent against createuser.c
Comment by petere on 2013-11-17 04:55:37 PM: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/228/
Patch by cbbrowne on 2013-11-19 08:39:36 PM: Per Amit Kapila's comments, revised documentation formatting and wording, as well as reordering the code a bit.
Comment by petere on 2013-11-20 04:13:35 AM: needs rebase
Review by amitkapila on 2013-11-20 05:00:56 AM: behavior inconsistency in new option for role names that contain special characters.
Patch by amitkapila on 2013-12-10 02:58:54 PM: patch implementing multiple -g options. All review comments/suggestions are fixed.

Add Comment

Please log in to comment on this patch.