Log In - Home Page

Patch: Patch: pg_stat_statements: query, session, and eviction identification

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-09
Topic Monitoring
Patch Status Returned with Feedback
Author Daniel Farina, Sameer Thakur
Reviewers Fujii Masao, Arne Scheffer
Committer Nobody
Close Date 2013-10-16
Comments
Comment by petere on 2013-09-14 06:38:13 PM: email contains no patch
Comment by samthakur74 on 2013-09-16 04:47:22 AM: Rectified that.
Comment by samthakur74 on 2013-09-17 04:41:46 AM: Version 3 had review comment for adding documentation which is addressed in the version 4, which now needs further review.
Review by masaofujii on 2013-09-17 12:20:32 PM: samthakur74 forgot to include some source files in the patch.
Comment by samthakur74 on 2013-09-17 03:52:46 PM: Corrected the error
Review by masaofujii on 2013-09-18 04:16:09 AM: The patch has not included all required files yet.
Comment by samthakur74 on 2013-09-18 05:45:02 AM: I did not add pg_stat_statements--1.2.sql. I have added that now and
updated the patch again.

The patch attached should contain following file changes
patching file contrib/pg_stat_statements/Makefile
patching file contrib/pg_stat_statements/pg_stat_statements--1.1--1.2.sql
patching file contrib/pg_stat_statements/pg_stat_statements--1.2.sql
patching file contrib/pg_stat_statements/pg_stat_statements.c
patching file contrib/pg_stat_statements/pg_stat_statements.control
patching file doc/src/sgml/pgstatstatements.sgml
Review by masaofujii on 2013-09-18 05:44:06 PM: Got SEGV when testing the patch.
Comment by samthakur74 on 2013-10-03 08:18:35 AM: Fixed segmentation fault error reported and added documentation for statistics session
Review by masaofujii on 2013-10-04 02:29:41 PM: session_start column doesn't seem to need to be exposed in every rows of pg_stat_statements
Patch by samthakur74 on 2013-10-10 10:29:18 AM: Please find patch (version8) attached which adds documentation for session_start
and introduced fields and corrects documentation for queryid to be
query_id. session_start remains in the view as agreed.
Review by arnold_s on 2013-10-10 12:06:56 PM: quick usability review (of V7) suggesting a parameter
Review by masaofujii on 2013-10-10 05:14:08 PM: Some review comments

Add Comment

Please log in to comment on this patch.