Log In - Home Page

Patch: errors free dump with cleaning

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-01
Topic Clients
Patch Status Committed
Author Pavel Stehule
Reviewers Jeevan Chalke
Committer Álvaro Herrera
Close Date 2014-03-03
Comments
Patch by okbobcz on 2013-07-06 04:35:37 AM: it use a conditional DROP IF EXISTS statements, so reload should be without errors although a target database is empty
Comment by maiku41 on 2013-10-16 01:13:06 AM: Active as of 10/14. Moving to CF 2013-11
Comment by maiku41 on 2013-11-22 06:34:09 PM: Send reminder to reviewer.
Patch by okbobcz on 2013-12-13 02:31:54 PM: rebased
Comment by petere on 2013-12-16 03:54:13 PM: kicked off reviewer
Patch by okbobcz on 2013-12-20 07:19:28 PM: pg_restore knows --if-exists option now
Comment by jeevan.chalke on 2014-01-14 08:45:40 AM: Will review these changes in couple of days.
Review by jeevan.chalke on 2014-01-16 10:27:15 AM: Initial review. Reported few points to have attention.
Patch by okbobcz on 2014-01-17 02:32:50 PM: fix issues identified by Jeevan
Review by jeevan.chalke on 2014-01-21 08:24:43 AM: Need serious thought on a bug reported.
Patch by okbobcz on 2014-01-26 10:35:32 AM: reduction patch size
Review by jeevan.chalke on 2014-01-29 10:30:59 AM: Need small clarification. Overall patch looks good to me.
Patch by okbobcz on 2014-01-30 10:55:10 AM: fixed comment
Review by jeevan.chalke on 2014-01-30 01:23:23 PM: Patch looks good. Assigning to committer.
Comment by petere on 2014-01-31 02:46:04 AM: build unstable (whitespace): http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/339/
Comment by jeevan.chalke on 2014-01-31 06:31:11 AM: Can you please use my updated patch. I have fixed those whitespace errors and updated few comments. Entire code and design logic is untouched.
Comment by petere on 2014-02-02 09:45:27 PM: build unstable (whitespace): http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/347/
Comment by jeevan.chalke on 2014-02-03 07:15:29 AM: Hi Peter, Seems like you are applying wrong patch as I see older changes in the current build.
Review by alvherre on 2014-02-17 08:32:01 PM: some questions
Patch by okbobcz on 2014-02-18 03:55:00 PM: removed unused code
Patch by okbobcz on 2014-03-01 09:57:52 AM: fix --if-exists for pg_dumpall

Add Comment

Please log in to comment on this patch.