Log In - Home Page

Patch: Fix conversion of Decimal arguments for plpython

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Procedural Languages
Patch Status Committed
Author Szymon Guz, Ronan Dunklau
Reviewers Steve Singer
Committer Peter Eisentraut
Close Date 2013-07-06
Comments
Patch by szymon on 2013-06-06 08:01:26 AM: Initial version.
Patch by nmisch on 2013-06-22 01:05:56 PM: Fixing patch link
Review by ssinger on 2013-06-25 03:18:39 AM: Need to fix a few minor issues in the patch. Also performance isn't great maybe a different method of conversion would be faster?
Comment by szymon on 2013-06-25 10:21:19 AM: The speed problems are caused by slow Python's Decimal constructors.
Patch by szymon on 2013-06-25 11:00:27 AM: plpython_decimal_v2.patch
Review by ssinger on 2013-06-25 11:41:56 PM: Ready for a committer to take a look
Patch by szymon on 2013-06-26 08:29:37 AM: plpython_decimal_v3.patch
Patch by szymon on 2013-06-26 11:05:25 AM: plpython_decimal_v4.patch - with Ronan's changes.
Patch by szymon on 2013-06-26 08:49:35 PM: plpython_decimal_v5.patch - initialization code is moved from main plpython init function to PLyDecimal_FromNumeric().
Patch by ssinger on 2013-06-27 03:24:28 AM: plpython_decimal_v6.patch - changes the numeric unit test so it outputs the same text in both cases (with and without) cdecimal installed
Patch by szymon on 2013-06-27 10:27:04 AM: plpython_decimal_v7.patch - changes tests to check the class name
Patch by ssinger on 2013-06-28 08:17:36 PM: plpython_decimal_v8.patch - changes tests to also include the value

Add Comment

Please log in to comment on this patch.