Log In - Home Page

Patch: Add basic regression tests for SET xxx

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Regression Tests
Patch Status Returned with Feedback
Author Robins Tharakan
Reviewers Szymon Guz
Committer Nobody
Close Date 2013-07-16
Comments
Patch by robins on 2013-05-26 05:57:36 PM: Initial version.
Review by aglio on 2013-06-17 08:02:04 PM: Review by Szymon Guz. Found some issues.
Patch by robins on 2013-06-18 12:35:25 AM: Patch updated with corrections. Also remove a trailing white-space at the end of SQL script.
Review by kgrittn on 2013-06-18 03:25:40 PM: Szymon Guz says it looks good.
Review by szymon on 2013-06-26 07:41:44 PM: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Patch by robins on 2013-07-07 05:16:26 PM: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15 05:21:14 PM: Needs work.
Comment by maiku41 on 2013-07-16 08:23:45 PM: Needs work at end of CF. Returned with Feedback.

Add Comment

Please log in to comment on this patch.