Log In - Home Page

Patch: Add regression tests for COLLATE

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Regression Tests
Patch Status Rejected
Author Robins Tharakan
Reviewers Fabien Coelho
Committer Robert Haas
Close Date 2013-07-03
Patch by robins on 2013-04-11 07:17:33 AM: Initial version.
Review by calvin on 2013-05-03 01:57:55 PM: Looked at and tested, ok. I wish there could be collate tests in some non-trivial locale.
Comment by robins on 2013-05-07 11:59:45 PM: :( Apologies but I am not very well versed with other LOCALEs (at least not yet). So although I can pick this up as another task (may be another patch) I hope that is not a requirement for these set of tests to go in.
Comment by calvin on 2013-05-08 08:54:57 AM: No, it is not a requirement, just a wish. As the test cannot assume that any locale is installed on the system, it cannot be tested in the general case.
Patch by robins on 2013-05-23 09:16:50 AM: Remove tests that cant work on all systems (for e.g. UTF8 tests). Used DROP COLLATION IF EXISTS where possible.
Comment by rhaas on 2013-07-03 04:36:53 PM: some post-commit cleanup would be appreciated
Comment by rhaas on 2013-07-03 05:29:51 PM: buildfarm sad; patch reverted

Add Comment

Please log in to comment on this patch.