Log In - Home Page

Patch: Lag & Lead Window Functions Can Ignore Nulls

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2014-06
Topic Server Features
Patch Status Returned with Feedback
Author Nick White, Troels Nielsen
Reviewers Jeff Davis, Álvaro Herrera
Committer Jeff Davis
Close Date 2014-07-22
Comments
Patch by njw45 on 2013-03-23 10:20:01 PM: Initial version.
Patch by njw45 on 2013-03-23 10:27:02 PM: Revised version incorporating Tom Lane's comments.
Patch by njw45 on 2013-03-25 12:16:58 AM: Revised version also incorporating Hitoshi Harada's comments.
Review by jdavis on 2013-06-15 08:42:09 PM: Avoid per-tuple allocations.
Patch by njw45 on 2013-06-18 10:33:07 PM: Revised patch incorporating review feedback
Review by rhaas on 2013-06-24 06:39:24 PM: +1 for Troels Nielsen's approach to the grammar difficulties.
Patch by njw45 on 2013-06-26 02:12:45 AM: Revised patch to include Troels' grammar changes
Patch by njw45 on 2013-06-28 02:32:29 AM: Revised algorithm for correctness.
Patch by jdavis on 2013-06-29 05:40:15 PM: A few minor changes.
Review by jdavis on 2013-06-30 05:01:14 PM: Review comments by Dean Rasheed.
Patch by njw45 on 2013-07-01 12:08:34 AM: Fix some of the issues in Dean's review
Patch by njw45 on 2013-07-01 02:08:35 AM: Revised to fix all outstanding issues.
Patch by njw45 on 2013-07-03 07:50:36 AM: Fix pg_get_viewdef issue.
Review by jdavis on 2013-07-05 10:35:40 PM: I suggest eliminating the bitmapset.
Review by jdavis on 2013-07-05 10:36:34 PM: Comments related to transformWindowFuncCall()
Patch by njw45 on 2013-07-12 03:40:30 PM: Address review issues
Comment by aglio on 2013-07-21 06:02:11 AM: Out of time to review patch. Moving to next CommitFest per discussion.
Comment by petere on 2013-08-22 12:43:44 AM: needs rebase
Patch by njw45 on 2013-08-22 02:36:02 AM: Rebased patch
Review by alvherre on 2013-09-26 08:23:58 PM: some comments
Patch by njw45 on 2013-09-30 03:24:17 PM: Fix the issues raised by the most recent review.
Patch by njw45 on 2013-10-02 09:58:13 AM: Narrow API in windowdef.h based on more review comments
Comment by maiku41 on 2013-10-16 01:15:14 PM: Moved to CF 2013-11
Review by jdavis on 2013-11-20 07:16:29 AM: Review by Alvaro
Patch by njw45 on 2014-04-16 03:54:53 PM: I've fixed the outstanding issues from my last review.
Review by jdavis on 2014-07-07 04:12:30 AM: Also a WIP patch to show how I'm refactoring it.
Patch by jdavis on 2014-07-11 06:59:10 AM: Still a few open issues and some refactoring to do.

Add Comment

Please log in to comment on this patch.