Log In - Home Page

Patch: Add more regression tests for SEQUENCE

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Regression Tests
Patch Status Returned with Feedback
Author Robins Tharakan
Reviewers Fabien Coelho
Committer Nobody
Close Date 2013-07-16
Patch by robins on 2013-03-15 08:35:59 PM: Initial version.
Patch by robins on 2013-03-18 10:27:29 PM: Better naming + minor bug-fixes
Review by calvin on 2013-05-03 01:30:19 PM: Looked at and tested, okay. I like that it tests expected errors and border cases. Suggestion: when testing limits (eg seq10), put the first value expected to fail?
Patch by robins on 2013-05-07 10:45:36 PM: Updated patch as per feedback provided. Added an extra test while at it.
Review by calvin on 2013-05-08 08:08:08 AM: Ok!
Review by aglio on 2013-06-28 09:03:33 PM: Checked times of all new regression tests combined except DISCARD per -hackers. This applies to all regression tests in the June commitfest.
Review by rhaas on 2013-07-03 03:13:25 PM: needs a few fixes
Patch by robins on 2013-07-07 01:19:01 PM: Updated as per 3rd July feedback
Comment by calvin on 2013-07-09 04:01:20 PM: Wrong patch.
Patch by robins on 2013-07-15 01:11:45 PM: Attached the correct patch this time.

Add Comment

Please log in to comment on this patch.