Log In - Home Page

Patch: Add SPI_gettypmod() to return a field's typemod from a TupleDesc

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Miscellaneous
Patch Status Rejected
Author Mark Wong
Reviewers Jeevan Chalke
Committer Noah Misch
Close Date 2013-07-12
Comments
Patch by markwkm on 2013-02-09 05:10:51 PM: Initial version.
Comment by c2main on 2013-06-22 01:33:45 PM: First hunk of pl_exec.c contains an error:
*typetypmod = SPI_gettypeid(rec->tupdesc, fno);
Review by jeevan.chalke on 2013-06-25 08:54:36 AM: Initial review and confirmation
Review by jeevan.chalke on 2013-06-26 10:06:21 AM: Patch looks good. Its very simple and straight forward. Has documentation as well. No issue found in testing and code walk-through
Patch by nmisch on 2013-07-07 09:10:37 PM: Latest version
Comment by nmisch on 2013-07-08 12:19:09 AM: Recommend we not add more trivial SPI_* wrappers.

Add Comment

Please log in to comment on this patch.