Log In - Home Page

Patch: UNNEST() (and other functions) WITH ORDINALITY

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-06
Topic Miscellaneous
Patch Status Committed
Author Andrew Gierth, David Fetter
Reviewers Dean Rasheed, Jeevan Chalke
Committer Greg Stark
Close Date 2013-07-29
Comments
Patch by dfetter on 2013-01-23 06:34:28 AM: Initial version.
Patch by dfetter on 2013-02-08 09:16:34 PM: Next revision with more stability.
Patch by dfetter on 2013-06-17 05:44:32 AM: Rebased patch.
Review by deanr on 2013-06-18 10:39:01 AM: Looks to be in good shape. A few minor review comments.
Patch by dfetter on 2013-06-19 03:58:49 AM: Changes per Dean's review & discussion with Andrew Gierth
Review by dfetter on 2013-06-21 05:55:36 AM: More suggestions from Dean Rasheed.
Patch by dfetter on 2013-06-21 05:56:33 AM: Changes per Dean Rasheed, next round.
Comment by maiku41 on 2013-06-21 05:52:55 PM: Changed to Waiting For Author based on recent discussion.
Comment by deanr on 2013-06-24 02:05:59 PM: All review comments addressed. No new opinions on the naming of the new column. Marking ready for committer.
Patch by dfetter on 2013-07-01 01:01:57 AM: Updated per de-reservation of OVER as a keyword.
Comment by jnelson on 2013-07-03 10:08:12 PM: This new functionality looks extremely useful. While I'm not at all qualified to review the code, I tried anyway. The tests look thorough and very useful as potential sources of documentation examples.

I tried applying the patch as of 2ef085d0e6960f5087c97266a7211d37ddaa9f68 and ran into some fuzzy matches as well as one reject (easy to repair) on src/backend/parser/gram.y

and, of course, 'make check' returns that all 138 tests succeed.
Patch by dfetter on 2013-07-03 11:10:51 PM: More re-jiggering to reflect what's gone on on master.
Patch by gsmith on 2013-07-23 01:50:42 AM: Update with some bug fixes
Patch by rhodiumtoad on 2013-07-25 06:53:20 PM: Updated patch with more comments.

Add Comment

Please log in to comment on this patch.