Log In - Home Page

Patch: Index based regexp search for pg_trgm

Edit Patch - Move To Another CommitFest - Delete Patch

CommitFest 2013-01
Topic Performance
Patch Status Committed
Author Alexander Korotkov
Reviewers Heikki Linnakangas, Tom Lane
Committer Tom Lane
Close Date 2013-04-09
Patch by smagen on 2012-11-15 01:47:04 PM: Initial version.
Comment by fuzzycz on 2012-11-18 01:27:02 PM: Seems the message-id is unknown, so it's not possible to do any review of the patch :-(
Comment by smagen on 2012-11-19 09:59:47 PM: Sorry, I've messed up message, it didn't appear in list. Reposted and updated message-id.
Review by fuzzycz on 2012-11-19 11:03:56 PM: Initial review - small compilation hiccup, minor formatting issues etc.
Patch by smagen on 2012-11-19 11:09:24 PM: Small fixes.
Comment by heikki on 2012-11-20 09:31:14 AM: This old feedback still applies: the patch desperately needs high-level comments explaining how the algorithm works. Also, docs need to be updated.
Patch by smagen on 2012-11-20 08:03:08 PM: Small fixes and resources limiting. High-level comments, docs and regression tests are coming coon.
Patch by smagen on 2012-11-25 08:56:44 PM: Updated version of patch.
Review by heikki on 2012-11-26 01:09:29 PM: Needs some more commenting
Patch by smagen on 2012-11-26 07:50:37 PM: Get rid of PG_TRY/CATCH and more comments added.
Patch by smagen on 2012-11-30 11:23:13 AM: Overflow handling is reworked.
Patch by smagen on 2012-12-16 09:26:54 PM: Color expansion is postponed. Path matrix is removed.
Patch by smagen on 2012-12-18 08:58:24 PM: Bug fixed
Patch by ringerc on 2013-01-24 04:04:22 AM: Review and updated patch by Heikki
Comment by ringerc on 2013-01-24 04:04:44 AM: Further work required as identified by Tom
Patch by ringerc on 2013-01-24 04:05:27 AM: Revision addressing some of Tom's concerns
Comment by ringerc on 2013-01-24 04:06:46 AM: May be OK to commit despite need for some regex refactoring. Alternate approach suggested, though; pending Author response.
Patch by smagen on 2013-02-09 09:09:30 AM: Mos part of issues addressed, more comments on CNFA processing.
Patch by tgl on 2013-03-24 08:10:45 PM: patch v13
Review by tgl on 2013-03-24 09:54:45 PM: v13 doesn't seem to be going in the right direction to produce a clean library API.
Patch by smagen on 2013-04-01 09:16:20 PM: v14 New API implementation.
Patch by smagen on 2013-04-02 09:54:52 PM: v15 bug fix
Patch by tgl on 2013-04-08 05:30:36 AM: v16, some bug fixes and a lot of cosmetic changes

Add Comment

Please log in to comment on this patch.