Log In - Home Page

CommitFest 2011-01 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 69, Returned with Feedback: 25, Rejected: 2. Total: 96.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
MERGE command
Patch by gsmith on 2010-12-06: Updated patch
Review by gsmith on 2010-12-29: Problem with older UPSERT test case breaking in new version
Review by gsmith on 2011-01-04: Simple concurrent test case here passes when explicit locking is used.
Returned with Feedback Boxuan Zhai Greg Smith 2011-01-18
pg_dump --split
Patch by gluefinance on 2010-12-28: Initial version.
Returned with Feedback Joel Jacobson Marc Cousin 2011-01-22
EXPLAIN and nfiltered
Patch by johto on 2011-01-15: Initial version.
Review by sfrost on 2011-01-19: Reviewed, looked good with some minor updates, marking for committer.
Review by tgl on 2011-01-24: Needs complete rewrite based on discussion-so-far.
Returned with Feedback Marko Tiikkaja Stephen Frost 2011-01-24
Return command tag 'REPLACE X' for CREATE OR REPLACE statements
Patch by intgr on 2011-01-15: Updated patch in response to feedback.
Comment by rhaas on 2011-01-22: It seems no one wants to put any further effort into this problem.
Comment by rhaas on 2011-01-28: Marked returned with feedback.
Returned with Feedback Marti Raudsepp KaiGai Kohei, Robert Haas 2011-01-28
EXCHANGE TABLE
Patch by simon on 2011-01-15: Initial version.
Review by nmisch on 2011-01-19: WIP patch: design review
Comment by rhaas on 2011-01-28: not code complete at start of CF (or now)
Returned with Feedback Simon Riggs Noah Misch 2011-01-28
ALTER TYPE 0: test cases
Patch by nmisch on 2011-01-15: v3: message wording for TOAST indexes
Patch by nmisch on 2011-01-27: v4: merge with master and ALTER TYPE 2
Comment by rhaas on 2011-01-28: remainder is merged into ALTER TYPE 2, no need for two CF entries
Returned with Feedback Noah Misch Robert Haas 2011-01-28
ALTER TYPE 3: add facility to identify further no-work cases
Review by rhaas on 2011-01-24: No consensus on behavior, needs submission notes and performance testing, separate rewrite-vs-noop from check-vs-noop.
Comment by nmisch on 2011-01-27: Seeking consensus on: eval_const_expressions() vs. coerce_to_target_type() placement. If the former, pg_proc vs. pg_cast attachment. If pg_proc, syntax addition for CREATE FUNCTION.
Comment by rhaas on 2011-01-28: no consensus on design, needs more time than we can give it now
Returned with Feedback Noah Misch Robert Haas 2011-01-28
ALTER TYPE 4: temporal data types
Patch by nmisch on 2011-01-12: Initial version.
Comment by rhaas on 2011-01-28: no consensus on design, needs more time than we can give it now
Returned with Feedback Noah Misch Nobody 2011-01-28
ALTER TYPE 5: varbit and bit
Patch by nmisch on 2011-01-12: Initial version.
Comment by rhaas on 2011-01-28: no consensus on design, needs more time than we can give it now
Returned with Feedback Noah Misch Nobody 2011-01-28
ALTER TYPE 6: numeric
Patch by nmisch on 2011-01-12: Initial version.
Comment by rhaas on 2011-01-28: no consensus on design, needs more time than we can give it now
Returned with Feedback Noah Misch Nobody 2011-01-28
ALTER TYPE 7: avoid index rebuilds/FK validations
Patch by nmisch on 2011-01-13: Initial version.
Comment by rhaas on 2011-01-28: no consensus on design, needs more time than we can give it now
Returned with Feedback Noah Misch Nobody 2011-01-28
limiting hint bit I/O
Patch by rhaas on 2011-01-14: Initial version.
Review by rhaas on 2011-02-05: v3
Review by rhaas on 2011-02-07: Not clear that this is a good idea, let's mark it Returned with Feedback.
Returned with Feedback Robert Haas Nobody 2011-02-07
early detoasting of varlena values inside plpgsql
Review by nmisch on 2011-01-24: Updated review
Comment by okbobcz on 2011-01-27: I sent a both variants of this patch - now a commiters should to decide
Review by rhaas on 2011-02-04: Review.
Returned with Feedback Pavel Stehule Noah Misch, Robert Haas 2011-02-08
Range Types
Patch by jdavis on 2011-02-06: New patch. Known TODO items closed.
Review by breinbaas on 2011-02-08: Review (partly)
Patch by breinbaas on 2011-02-14: rangetypes-20110208.patch.gz
Returned with Feedback Jeff Davis Erik Rijkers 2011-02-10
Self-tuning checkpoint sync spread
Patch by rhaas on 2011-01-30: More random brainstorming, and a rebase of an old patch.
Patch by gsmith on 2011-02-07: Updated patch with auto-tuning logic
Review by gsmith on 2011-02-10: Mixed performance test results
Returned with Feedback Greg Smith Nobody 2011-02-10
parallel pg_dump
Comment by itagaki on 2011-02-03: Two issues.
Comment by rhaas on 2011-02-07: Not committable yet - do we need to push this out to 9.2?
Comment by rhaas on 2011-02-10: Still some open TODOs.
Returned with Feedback Joachim Wieland Jaime Casanova 2011-02-10
Add table function to PL/Tcl [TODO]
Patch by karl on 2011-01-04: Initial version.
Comment by rhaas on 2011-02-07: Needs review! Can anyone pick this up?
Review by adunstan on 2011-02-11: returning. Among other things, needs documentation.
Returned with Feedback Karl Lehenbauer Andrew Dunstan 2011-02-11
PL/Python custom datatype parsers
Review by umitanuki on 2011-02-04: The first review. The feature didn't work.
Patch by wulczer on 2011-02-06: Fixes.
Comment by rhaas on 2011-02-11: Which way are we going with this?
Returned with Feedback Jan Urbański Hitoshi Harada 2011-02-11
FOR KEY LOCK foreign keys
Patch by alvherre on 2011-01-14: Initial version.
Review by dim on 2011-01-22: quick review, to be continued. What about the user docs?
Review by nmisch on 2011-02-11: Code/functional review
Returned with Feedback Álvaro Herrera Dimitri Fontaine, Noah Misch 2011-02-15
MULTISET functions
Patch by itagaki on 2011-02-15: Special syntax are removed. Now it adds only array functions and aggregates.
Review by rhaas on 2011-02-15: Latest review.
Comment by rhaas on 2011-02-16: Marking returned with feedback.
Returned with Feedback Itagaki Takahiro Pavel Stehule, Robert Haas, Stephen Frost 2011-02-16
widen scale factor limit from pgbench
Patch by gsmith on 2011-02-09: Updated patch, basics all work now. Concerns about random generation, not necessarily a commit blocker however.
Comment by gsmith on 2011-02-10: Should switch to using erand48 to resolve random number generation issues
Comment by gsmith on 2011-02-16: Portability concerns with threading and erand48
Returned with Feedback Euler Taveira de Oliveira, Greg Smith Greg Smith, Stephen Frost 2011-02-16
log_csv_fields ; add current_role log option
Comment by rhaas on 2011-02-16: Still no consensus.
Comment by rhaas on 2011-02-17: More problems.
Patch by rhaas on 2011-02-17: Fixed some problems. New patch. Still not sure.
Returned with Feedback Stephen Frost Itagaki Takahiro 2011-02-17
synchronized snapshots
Review by nmisch on 2011-01-20: Re-review based on v2; getting closer.
Patch by jwieland on 2011-01-30: A new patch, adopting most of Noah's suggestions
Comment by alvherre on 2011-02-23: A new proposal for how this should work, incorporating current and previous feedback
Returned with Feedback Joachim Wieland Noah Misch 2011-02-23
SQL/MED - postgresql_fdw
Comment by tgl on 2011-02-21: Needs revision to match committed FDW API patch
Comment by rhaas on 2011-02-22: Is anyone working on this?
Patch by hanada on 2011-02-24: rebased, support EXPLAIN output and EXTENSION framework (almost based on Heikki's patch)
Returned with Feedback Shigeru Hanada Heikki Linnakangas 2011-02-25
PL/Python don't remove arguments
Patch by wulczer on 2011-02-09: Merged with master.
Comment by rhaas on 2011-02-25: Suggest marking this RWF and moving it to the TODO list.
Comment by rhaas on 2011-02-28: added link to Todo list based on dicussion
Returned with Feedback Jan Urbański Hitoshi Harada 2011-02-28