Log In - Home Page

CommitFest 2010-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Rejected".

Status Summary. Committed: 23, Returned with Feedback: 14, Rejected: 6. Total: 43.

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Extensible executor nodes
Patch by itagaki on 2010-10-26: Initial version.
Comment by tgl on 2010-11-16: This is trying to do way too much. Let's just pull out the idea of a function pointer for ExecProcNode.
Comment by itagaki on 2010-11-17: There is no measurable improvement actually.
Rejected Itagaki Takahiro Tom Lane 2010-11-17
Issue with non-unicode aware downcase_truncate_identifier() function.
Patch by rdchirmade on 2010-10-13: Initial version.
Comment by rhaas on 2010-11-21: tgl says this approach isn't really standards complaint; and it seems likely also to be slow.
Rejected Rajanikant Chirmade Nobody 2010-11-21
for-in-array
Patch by okbobcz on 2010-09-30: This patch allows iteration over a array via "FOR" statement
Patch by okbobcz on 2010-10-04: this patch contains a implementation of "subscripts" function. It is important for iteration "for-in-array" of multidimensional arrays.
Review by jcasanov on 2010-11-22: Tom objects to this patch for beign syntactic sugar that will complicate the various FOR sub-syntaxes while it's better to accomplish the same performance benefit this patch provides to this specific case by internal optimizations
Rejected Pavel Stehule Jaime Casanova 2010-11-22
column-level update privs + lock table
Review by kaigai on 2010-11-25: It seems to me reasonable.
Review by rhaas on 2010-11-27: Not sure this is the right behavior.
Comment by rhaas on 2010-12-03: comments from tgl
Rejected Josh Kupershmidt KaiGai Kohei 2010-12-03
ALTER EXTENSION ... SET SCHEMA ...
Patch by dim on 2010-11-04: Update v2, implement AlterObjectNamespace_internal in alter.c
Patch by dim on 2010-11-05: Update v3, cleanup (#includes in particular)
Comment by dim on 2010-12-09: Now included in the main Extensions patch where we already need it to implement relocatable extensions.
Rejected Dimitri Fontaine Nobody 2010-12-09
serializable lock consistency
Patch by rhaas on 2010-10-21: Merged up to head of master branch, other minor cleanups.
Patch by fgp on 2010-12-15: Merged up to head of master branch, improved documentation and added additional asserts for safety.
Patch also available via https://github.com/fgp/postgres/tree/serializable_lock_consistency
Comment by heikki on 2010-12-20: Fatal bug found, marking as "rejected".
Rejected Florian G. Pflug Kevin Grittner 2010-12-20