Log In - Home Page

CommitFest 2010-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 23, Returned with Feedback: 14, Rejected: 6. Total: 43.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Field-specific keywords in pg_hba.conf
Patch by direvus on 2010-10-16: Initial version.
Patch by direvus on 2010-10-16: Original email describes patch but didn't have it attached. See this mail for the patch.
Comment by tgl on 2010-11-17: This patch was already reviewed, and author agreed to pursue a different approach.
Returned with Feedback Brendan Jurd Nobody 2010-11-17
Improving perfromance of prep_buildtree script used in VPATH builds
Review by gsmith on 2010-11-18: Initial performance test doesn't show an improvement
Comment by gsmith on 2010-11-18: Some portability concerns with older BSD systems
Comment by rhaas on 2010-11-21: Marking as Returned With Feedback.
Returned with Feedback Gurjeet Singh Nobody 2010-11-21
JDBC Statement Timout - Client Side
Patch by rsmogura on 2010-10-14: The massage containing patch.
Comment by rhaas on 2010-11-23: JDBC patches do not go through the core CF process.
Returned with Feedback Radosław Smogura Nobody 2010-11-23
Review by RhodiumToad on 2010-09-22: Preliminary review
Comment by tgl on 2010-12-03: Applied except for the contrib/btree_gist additions, which I lack the patience to fix, so that part is RWF.
Patch by oleg on 2011-01-21: Revised version of contrib/btree_gist compatible with new API
Returned with Feedback teodor, oleg Andrew Gierth 2010-12-03
Spread checkpoint sync
Comment by rhaas on 2010-11-15: Some preliminary thoughts; needs more review.
Comment by jjanes on 2010-11-20: Applies over "Instrument checkpoint sync calls", so waiting on update of that.
Patch by gsmith on 2010-12-01: Updated patch to address bit-rot
Returned with Feedback Greg Smith, Simon Riggs Nobody 2010-12-05
PLpython exception handling is suprising
Comment by gsmith on 2010-11-18: Tom suggests fixing the underlying behavior may be the right approach here
Comment by gsmith on 2010-12-01: Suggested improved behavior
Comment by gsmith on 2010-12-05: Preferred cleanup added as TODO item
Returned with Feedback Marti Raudsepp Nobody 2010-12-05
Explain Analyze Getrusage Resource tracking
Review by rhaas on 2010-11-15: A few gripes.
Review by gsmith on 2010-12-05: Windows build issues
Comment by rhaas on 2010-12-13: no updates since 11/22
Returned with Feedback Gregory Stark Robert Haas 2010-12-13
Synchronous Replication
Patch by MasaoFujii on 2010-09-15: Updated version
Patch by MasaoFujii on 2010-12-06: Initial patch for replication timeout (I extracted the timeout feature part from synchronous replication)
Review by rhaas on 2010-12-13: Does not apply.
Returned with Feedback Fujii Masao Thom Brown 2010-12-13
Synchronous Replication, transaction-controlled
Comment by simon on 2010-09-16: v4 added below main post
Patch by simon on 2010-10-08: New v5 first hack with changes suggested by Dimitri and Heikki
Review by rhaas on 2010-12-13: Does not apply.
Returned with Feedback Simon Riggs Nobody 2010-12-13
Add a primary key using an existing index
Patch by singh.gurjeet on 2010-11-22: Revised patch, per Steve's review.
Patch by ssinger on 2010-11-25: Fixes issue in regression test expected output
Review by itagaki on 2010-11-29: We need another syntax and checking for TABLESPACE.
Returned with Feedback Gurjeet Singh Steve Singer, Itagaki Takahiro 2010-12-14
Comment by gsmith on 2010-12-05: Concerns about levels/flags sizes
Review by kgrittn on 2010-12-05: Passes regression tests, useful for SSI, minor formatting complaint, still needs review for hot standby purposes.
Review by rhaas on 2010-12-14: Possible alternate approach?
Returned with Feedback Andres Freund Kevin Grittner, Robert Haas 2010-12-16
Per-column collation
Patch by gsmith on 2010-12-05: Updated patch addressing feedback
Review by itagaki on 2010-12-09: Issues in contrib/citext and ILIKE.
Patch by gsmith on 2010-12-16: Updated patch to fix issues found
Returned with Feedback Peter Eisentraut Itagaki Takahiro 2010-12-16
Tab completion in psql for triggers on views
Patch by dfetter on 2010-11-30: Fixed CREATE TRIGGER trg [TIMING] [tab]
Patch by itagaki on 2010-11-30: Fixed unexpected schema expansion
Patch by rhaas on 2010-12-13: Partially committed, rest is here.
Returned with Feedback David Fetter Itagaki Takahiro, Robert Haas 2010-12-16
Patch by dim on 2010-12-12: Update v17, remove control.in mechanism and rework psql interface (\dx, \dx[+] PATTERN, \dX)
Patch by dim on 2010-12-16: Update v18, bitrot fixes after pg_execute_from_file went in
Patch by dim on 2010-12-16: Update v19, 2 one-liner fixes for 2 problems with script file encoding (that just got removed from the pg_execute_from_file() patch)
Returned with Feedback Dimitri Fontaine David Wheeler 2010-12-16