Log In - Home Page

CommitFest 2010-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Committed".

Status Summary. Committed: 26, Returned with Feedback: 25, Rejected: 1. Total: 52.

Committed Patches

Patch Name Status Author Reviewers Date Closed
utf8_to_unicode
Patch by joeyadams on 2010-07-24: Initial version.
Patch by joeyadams on 2010-08-13: Variation of initial patch with utf8_to_unicode in src/port
Committed Joey Adams Nobody 2010-08-18
Vacuum and analyze counters for pg_stat_*_tables
Patch by mha on 2010-08-20: Initial version.
Committed Magnus Hagander Tom Lane 2010-08-21
formating functions
Patch by okbobcz on 2010-07-30: documentation patch - rename function from example of variadic function
Comment by kgrittn on 2010-08-03: Review delayed. Patch moved to next CF for tracking purposes.
Comment by itagaki on 2010-08-24: Applied concat(), concat_ws(), left(), right(), and reverse(),
but not included format() nor sprintf().
Committed Pavel Stehule Itagaki Takahiro 2010-08-24
WIP patch for serializable transactions with predicate locking
Patch by kgrittn on 2010-07-18: minor revision to patch, extra tests included, accidentally posted to wrong thread
Patch by kgrittn on 2010-09-13: Noop patch as edited and committed by Joe after a couple preliminary posts and some discussion.
Comment by kgrittn on 2010-10-11: Related patch at https://commitfest.postgresql.org/action/patch_view?id=386
Committed Kevin Grittner & Dan Ports Joe Conway 2010-09-11
Warning about shutdown during online backup
Patch by MasaoFujii on 2010-09-13: Initial version.
Patch by MasaoFujii on 2010-09-14: Updated version
Committed Fujii Masao Heikki Linnakangas 2010-09-14
INSERT and parentheses
Comment by johto on 2010-07-06: Bumped to next commitfest. The author has less time available than he originally thought and has to prioritize.
Review by ipolishchuk on 2010-08-12: The patch works as advertised, though the HINT text requires clarification.
Comment by tgl on 2010-09-18: Committed a significantly revised version.
Committed Marko Tiikkaja Tom Lane 2010-09-18
Follow protocol for binary COPY with EOF marker
Patch by kjurka on 2010-08-03: Initial version.
Patch by kjurka on 2010-08-07: Updated patch.
Patch by kjurka on 2010-08-09: Hopefully final version.
Committed Kris Jurka Tom Lane 2010-09-18
ALTER TYPE extensions
Patch by kaigai on 2010-09-21: revised patch
Review by kaigai on 2010-09-21: Found a matter
Patch by kaigai on 2010-09-21: revised patch
Committed Peter Eisentraut KaiGai Kohei 2010-09-26
Security Label support
Patch by kaigai on 2010-08-31: Initial version.
Patch by kaigai on 2010-09-14: Hook was revised - All the ESP shall be called, even if it does not own the label to be changed.
Patch by rhaas on 2010-09-26: Proposed final version.
Committed KaiGai Kohei Robert Haas 2010-09-27
Fix to add some missing SQLCODEs and SQLSTATEs in the ECPG manual.
Patch by snaga on 2010-09-27: A patch revised. Please check it out.
Patch by snaga on 2010-09-27: As a comment from Álvaro Herrera, I have made some changes around ENOMEM
from quotes to tags.
Patch by snaga on 2010-09-27: Revised to be applicable to the git repository.
Committed Satoshi Nagayasu Peter Eisentraut 2010-09-29
significant reduce of tsearch ispell dictionary memory usage
Patch by okbobcz on 2010-09-07: Initial version.
Review by rhaas on 2010-09-27: Generally, +1.
Comment by rhaas on 2010-10-06: Tom will take this one.
Committed Pavel Stehule Robert Haas 2010-10-06
sequence scan + sort for CLUSTER
Comment by kgrittn on 2010-08-03: Review delayed. Patch moved to next CF for tracking purposes.
Review by itagaki on 2010-08-31: Almost OK, but simplified documentation and CLUSTER VERBOSE supports are preferred.
Patch by itagaki on 2010-09-27: Cost estimation is based on maintenance_work_mem.
Committed Leonardo Francalanci Itagaki Takahiro 2010-10-07
Make CLUSTER VERBOSE more verbose
Review by ams on 2010-09-16: Doesn't apply to HEAD:src/backend/commands/cluster.c, but shouldn't be too hard to fix.
Comment by itagaki on 2010-09-16: The patch needs to be applied after "sequence scan + sort for CLUSTER" patch.
Comment by ams on 2010-09-17: Sorry, I missed that. Looks fine, then.
Committed Itagaki Takahiro Abhijit Menon-Sen 2010-10-07
Triggers on VIEWs
Patch by deanr on 2010-09-08: Wording and formatting improvements to triggers chapter of docs
Review by psoo on 2010-09-30: New patch version fixes patch rejects. Will continue review until weekend and provide a summary then.
Review by psoo on 2010-10-05: Summary and patch remarks
Committed Dean Rasheed Bernd Helmle 2010-10-10
tabcomplete for \set command
Review by itagaki on 2010-10-04: Buffer overrun and suggestion for usage of realloc.
Patch by okbobcz on 2010-10-04: fixed issue with buffer overrun
Comment by itagaki on 2010-10-04: Patch seems OK as long as no objections for realloc usage.
Committed Pavel Stehule Itagaki Takahiro 2010-10-10
ECPG Documentation Improvement
Comment by snaga on 2010-09-02: Some people are wanting to have intensive work to review and apply changes on the ECPG docs.
Comment by ams on 2010-09-16: Please submit the improvements as a documentation patch attached to your email.
Patch by snaga on 2010-09-28: The patch is split into total 15 patches for each chapter of the ecpg doc,
and every patch could be applied to the Git version with only itself.
So you can review every patch chapter by chapter.
Committed Satoshi Nagayasu Peter Eisentraut 2010-10-10
working has_table_privilege('public') and friends
Comment by itagaki on 2010-10-04: Tom said "missing_ok" argument should be kept.
Review by kaigai on 2010-10-04: Most of the patch seems to me fair enough. Please fix up missing_ok argument.
Comment by kaigai on 2010-10-06: Suggestion about 'missing_ok' was my misunderstanding.
Committed Alvaro Herrera KaiGai Kohei 2010-10-13
merge_append
Patch by dfetter on 2010-09-20: Initial version.
Patch by rhaas on 2010-10-01: Updated patch.
Committed Hans-Jürgen Schönig, based on a patch by Greg Stark Robert Haas 2010-10-14
top-level DML under CTEs
Patch by umitanuki on 2010-10-03: Fixing LIMIT and etc. bug and it now works very nice in INSERT as in others.
Patch by johto on 2010-10-05: Newest version of the patch.
Comment by johto on 2010-10-05: Ready for committer.
Committed Hitoshi Harada Marko Tiikkaja 2010-10-15
new option to register windows service
Patch by quan74 on 2010-08-17: Initial version.
Patch by alvherre on 2010-09-06: updated per review
Committed Quan Zongliang Steve Atkins 2010-10-15
host name support in pg_hba.conf
Comment by rhaas on 2010-10-13: Minor gripes from tgl.
Comment by rhaas on 2010-10-13: An idea for a small improvement from tgl.
Comment by rhaas on 2010-10-13: Sounds like this is about ready for commit...
Committed Peter Eisentraut KaiGai Kohei 2010-10-15
gincostestimate
Patch by tgl on 2010-08-07: Or this ...
Patch by teodor on 2010-09-07: Slightly reworked by Tom's objection
Comment by itagaki on 2010-10-06: It's better to initialize the meta page on index build.
Committed teodor Jan Urbański 2010-10-17
Accelerated version of levenshtein function for small distances
Review by rhaas on 2010-10-07: Does not apply.
Patch by smagen on 2010-10-12: Correct version of patch
Patch by rhaas on 2010-10-13: Updated patch, after some hacking. Comments?
Committed Alexander Korotkov Robert Haas 2010-10-19
contrib/isn isbn update
Comment by sternocera on 2010-09-29: Hi,

The diff output from your patch looks a little bit odd. How did you produce it?

Thanks,
Peter Geoghegan
Comment by rhaas on 2010-10-13: Active discussion continues.
Comment by rhaas on 2010-10-18: I don't see that we gain anything from refusing to commit this.
Committed Jan Otto Peter Geoghegan 2010-10-19
WIP: extensible enums
Patch by rhaas on 2010-10-13: Updated patch from adunstan.
Patch by deanr on 2010-10-15: Minor updates to docs and regression tests
Review by deanr on 2010-10-16: Still some issues to resolve
Committed Andrew Dunstan Brendan Jurd 2010-10-24
client authentication hook
Patch by kaigai on 2010-08-24: Initial version.
Comment by rhaas on 2010-10-19: Still not clear that we need a hook here, or that this is the right place for it.
Committed KaiGai Kohei Robert Haas 2010-10-26