Log In - Home Page

CommitFest 2010-07 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 34, Returned with Feedback: 18, Rejected: 1. Total: 53.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Access control reworks on ALTER TABLE
Patch by kaigai on 2010-03-17: Initial version.
Comment by kaigai on 2010-05-24: We agreed not to be consolidate checks between prep and exec stages.
Returned with Feedback KaiGai Kohei Nobody 2010-05-24
add a hook on ClientAuthentication()
Patch by kaigai on 2010-06-15: The hook was moved to ClientAuthentication() for more clarification of the purpose.
Comment by rhaas on 2010-07-08: I think we've decided not to pursue this, at least for now; and maybe not ever.
Comment by rhaas on 2010-07-08: comments from tgl
Returned with Feedback KaiGai Kohei Robert Haas 2010-07-08
Partitioning syntax
Review by kgrittn on 2010-06-23: doesn't apply to head anymore
Patch by kgrittn on 2010-06-23: updated patch
Review by rhaas on 2010-07-06: Needs quite a bit of work.
Returned with Feedback Itagaki Takahiro Jaime Casanova, Robert Haas 2010-07-12
ispell dictionary preloading
Patch by okbobcz on 2010-04-01: actualised version - modificated AllocSet allocator
Review by itagaki on 2010-07-07: Basically OK, but required test cases and plan for Windows port.
Comment by rhaas on 2010-07-08: tgl advocates precompiler approach.
Returned with Feedback Pavel Stehule Itagaki Takahiro 2010-07-20
Fix leaky VIEWs for RLS
Review by rhaas on 2010-07-08: use explicit pg_proc flag?
Comment by rhaas on 2010-07-19: Does anyone else have an opinion on this?
Comment by rhaas on 2010-07-21: Marking Returned with Feedback, per discussion.
Returned with Feedback KaiGai Kohei Robert Haas 2010-07-21
Snapshot materialized views
Comment by kgrittn on 2010-07-12: Discussion on refreshing the view.
Comment by kgrittn on 2010-07-12: Discussion on initial implementation work.
Comment by kgrittn on 2010-07-12: Robert Haas comments on patch.
Returned with Feedback Pavel Baros Nobody 2010-07-23
Synchronous replication via SR
Patch by zboszor on 2010-04-29: Initial version.
Comment by Harald Kolb on 2010-07-15: After setting up a cluster with strict sync. replication and using pgbench to verify transaction performance, it's obvious that the current performance (about 10 TPS) is not sufficient. Can you explain the performance limitation and what is necessary to improve the situation ? Is there a plan to continue with this solution ?

Thanks, Harald.
Review by yhavinga on 2010-07-26: Besides that the patch was a bit outdated, the bulk of the patch was handling the acknowledged XIDs on the master, which was more complex and intrusive than the way the other syncrep patch waited for standby's. The guc parameters however were more clear to me than the other patch.
Returned with Feedback Zoltán Böszörményi Yeb Havinga 2010-07-26
Another synchronous replication
Patch by MasaoFujii on 2010-07-14: Initial version.
Patch by MasaoFujii on 2010-07-21: Updated version
Review by yhavinga on 2010-07-26: Besides the already mentioned TODOs for this patch (remove poll loops), some comments, unification with the other syncrep patch would be nice.
Returned with Feedback Fujii Masao Yeb Havinga 2010-07-26
initdb add to postgresql.conf
Patch by bmomjian on 2010-03-31: Initial version.
Comment by kaigai on 2010-07-15: Here was previous suggestions.
Comment by rhaas on 2010-07-26: Remarks from kgrittn; patch appears to have minimal benefit.
Returned with Feedback David Christensen KaiGai Kohei 2010-07-26
support multiple -f options
Patch by rhaas on 2010-03-08: Initial version.
Review by kgrittn on 2010-06-17: Some problems, including a segfault.
Patch by markwkm on 2010-07-20: proposed change to original patch
Returned with Feedback David Christensen Mark Wong & Gabrielle Roth 2010-07-28
dynamically allocating chunks from shared memory
Patch by markus on 2010-07-16: Initial version.
Returned with Feedback Markus Wanner Nobody 2010-07-28
internal messaging
Patch by markus on 2010-07-16: Initial version.
Returned with Feedback Markus Wanner Nobody 2010-07-28
lock_timeout GUC
Comment by marco44 on 2010-08-02: lock_timeout is triggered at deadlock_timeout if lock_timeout > deadlock_timeout

Asked -hackers for advice
Comment by kgrittn on 2010-08-02: Both author and reviewer think Zoltán's WiP patch for a timeout framework would be a better approach. Marking Returned with Feedback.
Comment by gbatumbya on 2011-06-29: Just wondering, what is the status on implementing lock_timeout, the reason i ask is that I couldn't seem to find any thing about the timeout framework
Returned with Feedback Zoltán Böszörményi Marc Cousin 2010-08-02
COPY optimization in pg_restore
Review by marco44 on 2010-07-06: No problem found during review. Neat win in a very simple non-indexed table test.
Comment by rhaas on 2010-07-14: Need to address Tom's concerns.
Comment by rhaas on 2010-07-25: changed status to 'Waiting on Author', pending resolution of Tom's concerns
Returned with Feedback Itagaki Takahiro Marc Cousin 2010-08-03
SQL/MED foreign table
Patch by kgrittn on 2010-07-20: Revised patch by Itagaki.
Comment by okbobcz on 2010-07-21: is some reason why non super user cannot to use a foreign tables based on files?
Comment by okbobcz on 2010-07-30: current patch has a security issue
Returned with Feedback Itagaki Takahiro Pavel Stehule 2010-08-03
Performance improvements for Array utility functions with large arrays
Patch by mikelewis on 2010-06-16: Fixed naming issue.
Comment by tgl on 2010-07-16: Concerned about added costs for cases it doesn't optimize.
Comment by rhaas on 2010-07-27: Setting to "Waiting on Author".
Returned with Feedback Mike Lewis Daniel Farina (fdr) 2010-08-05
Security Label support
Review by rhaas on 2010-07-22: Some concerns about the design.
Patch by kaigai on 2010-07-26: Revised patch (part.1 and 2)
Comment by rhaas on 2010-08-09: Would like to apply this after the comment.c refactoring patch, and other comments. Looks generally good.
Returned with Feedback KaiGai Kohei Robert Haas 2010-08-09
WiP: Per-column collation
Patch by petere on 2010-07-14: Initial version.
Review by jcasanov on 2010-08-02: Main question i have is if lc_collate (in CREATE DATABASE) should use pg_collation
Comment by kgrittn on 2010-08-03: Peter responds to questions.
Returned with Feedback Peter Eisentraut Jaime Casanova 2010-08-14