Log In - Home Page

CommitFest 2009-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 27, Returned with Feedback: 11. Total: 38.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Encoding issues in console and eventlog on win32
Review by rhaas on 2009-10-06: Magnus thinks this needs some cleanup.
Patch by rhaas on 2009-10-10: 2009-10-07 version
Patch by itagaki on 2009-10-12: Fix bugs and cleanup.
Committed Itagaki Takahiro Josh Williams, Magnus Hagander 2009-10-17
Patch by itagaki on 2009-10-14: Initial version.
Committed Itagaki Takahiro Simon Riggs, Heikki Linnakangas 2009-11-04
Drop the signal support for pg_standby in Win32
Patch by MasaoFujii on 2009-11-04: Initial version.
Committed Fujii Masao Heikki Linnakangas 2009-11-04
test_fsync file overrun
Patch by jjanes on 2009-09-17: Initial version.
Comment by gsmith on 2009-11-12: Updated version committed
Committed Jeff Janes Bruce Momjian 2009-11-12
Fix for: Text Search parser does not identify xml tag when attribute name's contains underscore
Patch by selenamarie on 2009-09-27: Initial version.
Committed Euler Taveira de Oliveira Peter Eisentraut 2009-11-15
New VACUUM options syntax
Patch by jdavis on 2009-11-14: Initial version by Itagaki Takahiro, separated from original VACUUM FULL rewrite.
Comment by jdavis on 2009-11-14: Two very minor issues.
Patch by itagaki on 2009-11-15: Fixed.
Committed Itagaki Takahiro Jeff Davis 2009-11-16
Hook and contrib module for checking password strength
Patch by laurenz on 2009-10-09: Small bugfix.
Review by itagaki on 2009-11-15: Needs some cleanup.
Patch by laurenz on 2009-11-17: Modified the patch according to Itagaki Takahiro's feedback. Added "isencrypted" parameter on Heikki Linnakangas' suggestion.
Committed Laurenz Albe Itagaki Takahiro 2009-11-18
TRIGGER with WHEN clause
Comment by kaigai on 2009-11-17: well improved, but a few bugs still remained.
Patch by itagaki on 2009-11-18: Fix remaining bugs (COPY, TOAST).
Review by kaigai on 2009-11-18: It should be reviewed by committers.
Committed Itagaki Takahiro KaiGai Kohei 2009-11-20
Comment by rleigh on 2009-11-15: One thing I've picked up on tonight is that the spacing between columns is wrong when border=0. I'll have a look into this tomorrow. That's the only formatting defect I've seen so far though.
Patch by rleigh on 2009-11-15: psql-wrap-formatting3.patch: Fix alignment and formatting when border=0. Now looks OK for all combinations of border and linestyle using the test script included with the previous patch, though more complex queries may be needed to fully exercise the code.
Review by gabrielle on 2009-11-18: see review posted to mail list
Committed Roger Leigh PDXPUG (contact Gabrielle Roth) 2009-11-21
UTF8 with BOM support in psql
Patch by itagaki on 2009-10-20: Initial version.
Patch by itagaki on 2009-11-16: A new proposal.
Committed Itagaki Takahiro Peter Eisentraut 2009-11-21
Dynamic cursor support for ECPG
Comment by alvherre on 2009-11-11: the "1a" part of this patch has been applied
Comment by alvherre on 2009-11-11: Part "1b" is applied too.
Patch by zboszor on 2009-11-16: Re-united the split-up patches without the committed parts
Committed Zoltan Boszormenyi Michael Meskes 2009-11-26
PL/Perl Inline Function Support
Patch by direvus on 2009-11-17: Revised patch from Joshua resolved my feedback, marking ready for committer.
Comment by eggyknap on 2009-11-17: Some other issues have come up, which need some work.
Patch by eggyknap on 2009-11-26: Updated version
Committed Joshua Tolley Brendan Jurd 2009-11-28
Application Name
Comment by kaigai on 2009-11-20: I checked this patch, but could not find any problem.
Patch by andresfreund on 2009-11-25: Minor Bug/Typo + Trailing Whitespace
Patch by dpage on 2009-11-26: Updated patch with non-ASCII filtering per discussion.
Committed Dave Page Andres Freund 2009-11-28
information_schema performance
Patch by jwieland on 2009-10-26: Initial version.
Committed Joachim Wieland Peter Eisentraut 2009-12-05
Operator Exclusion Constraints (was: Generalized Index Constraints)
Patch by jdavis on 2009-11-26: Improve docs and error messages.
Patch by jdavis on 2009-11-27: All open issues closed.
Patch by jdavis on 2009-12-01: Error message changed to be more like UNIQUE, and minor cleanup. All open issues closed.
Committed Jeff Davis Robert Haas 2009-12-06
pg_ctl init extension
Patch by gsmith on 2009-12-06: Updated patch with documentation
Review by gsmith on 2009-12-06: Have some concerns with the documentation changes
Patch by hlipa on 2009-12-07: updated documentation patch (v02)
Committed Zdenek Kotala Peter Eisentraut, Greg Smith 2009-12-10
PL/Python array support
Patch by petere on 2009-11-12: Initial version.
Patch by gsmith on 2009-11-21: Updated patch
Review by gsmith on 2009-12-02: Changes needed to regression test output
Committed Peter Eisentraut Josh Tolley 2009-12-10
Add YAML output to EXPLAIN
Review by itagaki on 2009-11-29: Remove undesirable line-breaks.
Comment by rhaas on 2009-12-04: I suggest we reject this.
Comment by gsmith on 2009-12-08: Once committed, need to confirm whether the outstanding JSON auto_explain issue is also in this patch, and if so fix them both at once
Committed Greg Sabino Mullane Itagaki Takahiro 2009-12-10
Largeobject access controls
Review by kaigai on 2009-12-03: not works well on the latest CVS HEAD, and strange English.
Patch by kaigai on 2009-12-03: revised patch based on the comments.
Patch by itagaki on 2009-12-09: patch r2461.
Committed KaiGai Kohei Jaime Casanova 2009-12-11
LDAP search during authentication
Patch by mha on 2009-11-14: Initial version.
Review by mha on 2009-11-29: Some comments
Patch by rhaas on 2009-12-11: most recent patch version, still has open items
Committed Robert Fleming Magnus Hagander 2009-12-12
Patch by itagaki on 2009-12-08: Merged two comments.
Patch by itagaki on 2009-12-10: Omit zero values in text format.
Patch by itagaki on 2009-12-13: Fixed bugs and documentation.
Committed Itagaki Takahiro Euler Taveira de Oliveira 2009-12-14
tsearch parser inefficiency with urls or emails.
Comment by andresfreund on 2009-12-09: Reply to the run time increases and method of reproducing the original issue (i.e. showing the benefit)
Review by kgrittn on 2009-12-10: Performance benefit confirmed. Three minor (and easily fixed) problems found.
Patch by kgrittn on 2009-12-10: Andres submitted patch to address concerns.
Committed Andres Freund Kevin Grittner 2009-12-15
Comment by eulerto on 2009-11-18: Initial review.
Patch by itagaki on 2009-11-30: Updated.
Patch by itagaki on 2009-12-03: Updated per Tom's comment.
Committed Itagaki Takahiro Euler Taveira de Oliveira 2009-12-15
pgbench setshell command
Patch by itagaki on 2009-12-10: Fix bugs and cleanup.
Patch by michael-kun on 2009-12-14: A couple of minor issues cleaned up
Patch by michael-kun on 2009-12-14: Variable name check added when a variable is put in pgbench. It has to be written with numerical, alphabet or underscore characters.
Committed Michael Paquier Greg Smith 2009-12-15
Aggregate ORDER BY support
Review by umitanuki on 2009-11-15: My first review. Looks good, with some questions.
Patch by RhodiumToad on 2009-11-30: Updated patch including docs.
Review by umitanuki on 2009-12-02: Looks good to me.
Committed Andrew Gierth Hitoshi Harada 2009-12-15
Python 3.1 support
Comment by nboley on 2009-11-18: Is supporting python 3.x via preprocessor directives in the 2.x source tree the best approach?
Comment by nboley on 2009-11-18: There is some agreement that we need to support 2.x and 3.x as separate pl's.
Comment by gsmith on 2009-11-22: Next step here looks to be adding build support infrastructure
Committed Peter Eisentraut Jan Urbański, Nathan Boley 2009-12-16
Hot Standby
Comment by rhaas on 2009-09-24: waiting on author
Comment by rhaas on 2009-09-30: Discussion of Heikki's plans.
Comment by heikki on 2009-10-15: Current status and updated patch
Committed Simon Riggs Heikki Linnakangas 2009-12-19

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
query cancel issues in dblink
Comment by rhaas on 2009-09-30: Joe Conway isn't sure we need this.
Comment by rhaas on 2009-10-03: Itagaki Takahiro thinks this is needed to fix a memory leak.
Comment by rhaas on 2009-10-05: Tom Lane & Joe Conway prefer another approach
Returned with Feedback Itagaki Takahiro Joe Conway 2009-11-12
typmode for function arguments and function result
Patch by okbobcz on 2009-11-04: Initial version.
Patch by okbobcz on 2009-11-15: Actualisation, older version wasn't consistent
Review by dim on 2009-11-17: Design discussion now opens
Returned with Feedback Pavel Stehule Dimitri Fontaine 2009-11-17
per-tablespace random_page_cost/seq_page_cost
Patch by rhaas on 2009-11-14: Initial version.
Returned with Feedback Robert Haas Bernd Helmle 2009-11-22
Partitioning option for COPY
Review by wulczer on 2009-11-21: second review
Patch by wulczer on 2009-11-22: new patch version
Review by wulczer on 2009-11-22: another review
Returned with Feedback Emmanuel Cecchet Jan Urbański 2009-11-23
Syntax for partitioning
Patch by itagaki on 2009-11-25: Updated.
Patch by itagaki on 2009-12-03: Fix bugs.
Comment by johto on 2009-12-06: Simon's thoughts
Returned with Feedback Itagaki Takahiro Marko Tiikkaja, Simon Riggs 2009-12-06
add more frame types in window functions (ROWS)
Patch by umitanuki on 2009-12-05: Add AggGetMemoryContext() API as suggested.
Review by RhodiumToad on 2009-12-06: A possible problem with the regression test, and not happy about the details of the new API.
Comment by gsmith on 2009-12-06: Clarification of regression test issues
Returned with Feedback Hitoshi Harada Andrew Gierth 2009-12-06
Writeable CTEs
Patch by johto on 2009-11-24: Patch v2
Comment by alexhunsaker on 2009-11-25: ready for commiter
Review by tgl on 2009-11-28: Still needs considerable work, particularly in the interactions with rules.
Returned with Feedback Marko Tiikkaja Alex Hunsaker 2009-12-08
Review by itagaki on 2009-11-23: Mainly syntax review.
Comment by itagaki on 2009-11-25: Comments about design and concepts.
Patch by kaigai on 2009-11-30: revised patch
Returned with Feedback KaiGai Kohei BWPUG 2009-12-10
Memory management probes
Review by psoo on 2009-12-09: New patch version and ongoing benchmark testing
Comment by rhaas on 2009-12-10: Please clarify performance impact and testing methodology.
Review by psoo on 2009-12-11: Additional results with new patch version
Returned with Feedback Zdenek Kotala Bernd Helmle 2009-12-11
XLogInsert: move some work out of critical section
Review by jcasanov on 2009-12-09: Initial review... seems good to me...
Review by gsmith on 2009-12-09: We really need a scripted test case for the performance change
Review by jcasanov on 2009-12-14: Trying a simple test, the benefit seems marginal even in extreme cases...
Returned with Feedback Jeff Janes Jaime Casanova 2009-12-15
SLRU and executor probes
Patch by hlipa on 2009-11-14: Initial version.
Review by psoo on 2009-12-07: Patch doesn't seem to address all issues mentioned earlier.
Review by psoo on 2009-12-10: Patch split up and documentation enhancements.
Returned with Feedback Robert Lor, Theo Schlossnagle Bernd Helmle 2009-12-15

Rejected Patches

No patches.