Log In - Home Page

CommitFest 2014-12 (In Progress)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Needs Review".

Status Summary. Needs Review: 34, Waiting on Author: 6, Ready for Committer: 5, Committed: 16, Returned with Feedback: 12, Rejected: 5. Total: 78.

Pending Patches

Patch Name Status Author Reviewers Last Activity

Server Features

 
Using Levenshtein distance to HINT a candidate column name
Comment by pgeoghegan on 2014-11-26: Final steps?
Patch by pgeoghegan on 2014-12-04: Revision with simplified costing logic and final, absolute suggestion quality test for best match
Patch by pgeoghegan on 2014-12-20: Revision that adds cost of distance of alias to would-be correct alias iff user specified an alias in faulty ad-hoc query (i.e. Tom and Stephen's preferred alias handling).
Needs Review Peter Geoghegan Robert Haas 2014-12-20
Add ssl_protocols configuration option
Review by ash on 2014-11-19: Review of the patch against master branch.
Patch by ash on 2014-11-27: v2: add sslprotocols libpq conn. keyword
Patch by ash on 2014-12-15: v3
Needs Review Dag-Erling Smørgrav / University of Oslo Alex Shulgin 2014-12-15
Custom/Foreign-Join-APIs
Patch by kaigai on 2014-12-03: Initial version.
Patch by kaigai on 2015-01-06: fixup a few oversights on the v1 patch.
Needs Review KaiGai Kohei Nobody 2015-01-06
ctidscan as an example of custom-scan
Patch by kaigai on 2014-12-15: Initial version.
Comment by kaigai on 2014-12-25: module was relocated to test/modules, instead of contrib
Patch by kaigai on 2015-01-06: Several fixups according to the comment from Jim Nasby
Needs Review KaiGai Kohei Nobody 2015-01-06
parallel mode/contexts
Patch by rhaas on 2014-12-15: Initial version.
Patch by michael-kun on 2014-12-22: New patch, with improved APIs after IM discussion with Heikki
Review by andresfreund on 2015-01-04: Initial review of infrastructure
Needs Review Robert Haas & others Nobody 2015-01-04
Send server_version_num in reply to startup packet (GUC_REPORT)
Patch by ringerc on 2015-01-19: Initial version.
Needs Review Craig Ringer Nobody 2015-01-19

Performance

 
group locking
Comment by pgeoghegan on 2014-12-09: Group locking testing framework (test_group_locking-v0.1.patch)
Patch by pgeoghegan on 2014-12-10: Revised patch (group-locking-v0.1.patch), plus original explanation of testing framework (don't use this version of testing framework, though - use test_group_locking-v0.1.patch from prior link)
Comment by nmisch on 2014-12-25: Other essential thread
Needs Review Robert Haas Nobody 2014-12-25
btree_gin and ranges
Review by michael-kun on 2014-12-22: Refactoring patch for a set of macros. Main patch will need a rebase once this is pushed.
Patch by heikki on 2014-12-22: Refactoring patch pushed, here's a rebased version of the original patch.
Patch by sigaev on 2014-12-26: split patch to gin's patch and module's patch
Needs Review Teodor Sigaev Nobody 2014-12-26
INNER JOIN removals
Patch by davidrowley on 2014-11-23: Initial version.
Patch by davidrowley on 2014-11-30: Fixes problem with PREPAREd statements
Patch by davidrowley on 2014-12-10: Changes made to allow generation of 2 plans, the correct plan is selected at execution time.
Needs Review David Rowley Nobody 2014-12-10
hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching
Patch by fuzzycz on 2014-12-07: Initial version.
Comment by fuzzycz on 2015-01-16: IMHO we should reject this, as we have no idea how to decide whether it's better than batching
Needs Review Tomas Vondra Nobody 2015-01-16
Avoiding plan disasters with LIMIT
Patch by simon on 2014-12-12: 2 patches: enable_sortedpath.v1.patch, avoid_limit_pushdown.v4.patch
Needs Review Simon Riggs Nobody 2014-12-12
Turning off HOT for larger SQL queries
Patch by simon on 2014-12-12: v7
Comment by jjanes on 2014-12-15: contrib/pgstattuple needs to be updated.
Patch by simon on 2014-12-17: v8
Needs Review Simon Riggs Nobody 2014-12-17

SQL Commands

 
Grouping Sets
Comment by michael-kun on 2014-12-15: Making as returned with feedback based on previous comments from Tom. This patch status was "waiting on author" either way.
Comment by rhodiumtoad on 2014-12-15: Moved to new CF and set back to "Waiting on Author"
Patch by rhodiumtoad on 2015-01-06: Updated patch.
Needs Review Andrew Gierth, Atri Sharma Tom Lane 2015-01-06
INSERT ... ON CONFLICT {UPDATE | IGNORE}
Review by pgeoghegan on 2015-01-03: Doubts emerge about the ability of any value locking implementation to maintain the useful ON CONFLICT guarantees with exclusion constraints (which might otherwise work with IGNORE).
Patch by pgeoghegan on 2015-01-11: V2.0 - Revision that adds RLS support. This closes out all open issues with support for/by interrelated features (e.g. inheritance, updatable views). Semantics now seem all but settled.
Comment by pgeoghegan on 2015-01-18: Can we cut scope, by removing the problematic exclusion constraint support for the IGNORE variant?
Needs Review Peter Geoghegan Nobody 2015-01-18
alter user/role CURRENT_USER
Review by abrightwell on 2014-10-27: Review of v2 of patch. Concerns about security and implications on items like auditing.
Patch by horiguti on 2014-11-13: I think this version takes in all the comments. Please let me know if missing something.
Patch by horiguti on 2014-11-14: V3 patch in which the new node name was changed to RoleSpec and some other chagnes made.
Needs Review Kyotaro Horiguchi Rushabh Lathia, Adam Brightwell 2014-11-14
TABLESAMPLE clause
Review by michael-kun on 2015-01-06: Patch needs a rebase, questions about structure and naming that could be improved IMO.
Patch by michael-kun on 2015-01-09: New patch, split of refactoring.
Review by michael-kun on 2015-01-09: Review of patch 1: simplification of seed generation should be done, compilation errors.
Needs Review Petr Jelinek Nobody 2015-01-09

Security

 
Row-level security
Comment by ringerc on 2014-10-17: Thread on permissive vs restrictive combinations of policies (Thom Brown)
Comment by ringerc on 2014-10-17: copy.c handling for RLS is insecure (Robert)
Comment by ringerc on 2014-10-17: WITH CHECK OPTION design concerns (Pavel)
Needs Review Many Robert Haas, Andres Freund 2014-10-17
pgaudit extension
Review by michael-kun on 2014-12-15: Review from Maumau. What's the performance impact? Temporary objects being audited is an annoyance for the lambda user.
Comment by michael-kun on 2014-12-15: Marking as returned with feedback.
Patch by ams on 2015-01-09: Updated to address Stephen's wishlist
Needs Review Ian Barwick, Abhijit Menon-Sen Nobody 2015-01-09
GetUserId() to has_privs_of_role() cleanup.
Patch by abrightwell on 2014-10-18: Initial version.
Needs Review Adam Brightwell Satoshi Nagayasu 2014-10-18

Replication & Recovery

 
Turn recovery.conf parameters into GUCs
Patch by ash on 2014-12-01: Rebased on current HEAD.
Patch by ash on 2014-12-15: v5.5
Review by pjmodos on 2014-12-23: Few issues/comments about code
Needs Review Fujii Masao, Michael Paquier, Jaime Casanova Andres Freund, Petr Jelinek 2014-12-23
Sequence Access Method
Review by heikki on 2014-11-04: Some comments on the design
Patch by pjmodos on 2014-12-12: New version - make AM fully responsible for the data in the sequence, allow AMs to specify custom columns in sequence tuple instead of single opaque amdata column
Patch by pjmodos on 2014-12-15: better ALTER SEQUENCE USING implementation
Needs Review Petr Jelinek Heikki Linnakangas 2014-12-15
Logical Replication Helper Functions
Patch by pjmodos on 2014-12-15: Initial version.
Needs Review Petr Jelinek Nobody 2014-12-15
WALWriter during Recovery
Patch by simon on 2014-12-15: Initial version.
Needs Review Simon Riggs Nobody 2014-12-15

System Administration

 
Additional role attributes
Comment by okbobcz on 2014-10-24: waiting on new syntax
Comment by michael-kun on 2014-12-08: Patch status not updated for a while. Returned with feedback?
Patch by abrightwell on 2015-01-15: updated patch - role-attributes-v2.patch
Needs Review Stephen Frost, Adam Brightwell Pavel Stehule 2015-01-15
Add restore_command_retry_interval option to control timeout of restore_command nonzero status code
Review by michael-kun on 2015-01-05: Patch unable to perform with retry intervals lower than 1s. Rewrote the patch to use TimestampTz instead, fixing at the same time issues here and there..
Patch by leopard on 2015-01-05: Michael Paquier patch
Review by andresfreund on 2015-01-16: Has wider implications than intended.
Needs Review Alexey Vasyliev Michael Paquier 2015-01-16

Monitoring & Control

 
pg_stat_ssl view
Patch by mha on 2014-11-19: Initial version.
Review by ash on 2014-12-11: Looks good, minor details spotted.
Review by michael-kun on 2014-12-22: More review comments from Heikki
Needs Review Magnus Hagander Nobody 2014-12-22

Clients

 
Allow parallel cores to be used by vacuumdb
Patch by amitkapila on 2015-01-02: cosmetic fixes.
Review by andresfreund on 2015-01-04: Not yet there.
Comment by michael-kun on 2015-01-16: Alvaro is going to have a look at it.
Needs Review Dilip Kumar Alvaro Herrera, Sawada Masahiko, Jeff Janes, Amit Kapila 2015-01-16

Procedural Languages

 
transforms
Patch by petere on 2014-12-15: Initial version.
Comment by petere on 2014-12-15: see also previous entry: https://commitfest.postgresql.org/action/patch_view?id=1067
Review by michael-kun on 2014-12-22: Little comment from Tom.
Needs Review Peter Eisentraut Nobody 2014-12-22

Miscellaneous

 
adaptive ndistinct estimator
Patch by fuzzycz on 2014-11-23: Initial version.
Patch by fuzzycz on 2014-12-07: v3 of the patch, implementing the 'minimal' case and various other improvements
Needs Review Tomas Vondra Nobody 2014-12-07
decreasing array_agg memory consumption
Comment by fuzzycz on 2015-01-07: marked as 'needs review' as the status was obsolete
Comment by apaan on 2015-01-08: element checking, behavior of makeArrayResult if release=true while subcontext=false
Patch by fuzzycz on 2015-01-16: v8 - added/fixed a few comments, agree with marking as ready for committer
Needs Review Tomas Vondra Ali Akbar 2015-01-16

Bug Fixes

 
Error when creating names too long for tar format
Patch by petere on 2014-12-04: Initial version.
Comment by petere on 2014-12-04: Part of this ought to be backpatched. Part of it depends on the outcome of <https://commitfest.postgresql.org/action/patch_view?id=1512>.
Needs Review Peter Eisentraut Nobody 2014-12-04
Perl coding error in msvc build system
Patch by petere on 2014-12-04: Initial version.
Needs Review Peter Eisentraut Nobody 2014-12-04
Track TRUNCATE via pgstat: reset live/dead tuple counters
Comment by decibel on 2014-12-15: Not sure how patch was created, but git apply and am couldn't handle it. Ended up using patch -p1 --dry-run <~/Downloads/truncate-and-pgstat-v0.2.patch
Review by decibel on 2014-12-16: Review + test patch
Patch by michael-kun on 2014-12-22: Patch v0.3, addressing problem with 2PC
Needs Review Alex Shulgin Jim Nasby 2014-12-22

Code Comments

 
Clarify need for memory barriers in bgworkers
Patch by decibel on 2014-11-06: Initial version.
Needs Review Jim Nasby Nobody 2014-11-06