Log In - Home Page

CommitFest 2014-10 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 36, Returned with Feedback: 22, Rejected: 4. Total: 62.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Lowest LSN value as #define
Patch by michael-kun on 2014-09-13: Initial version.
Returned with Feedback Michael Paquier Nobody 2014-11-15
Improve automatic analyze messages for inheritance trees
Patch by efujita on 2014-10-06: Initial version.
Comment by decibel on 2014-10-29: Marking Waiting on Author per Etsuro's comment
Patch by efujita on 2014-10-30: v2 addressing the comment by Simon
Returned with Feedback Etsuro Fujita Simon Riggs 2014-11-15
Additional Shutdown Logging
Patch by mbanck on 2014-10-16: Initial version.
Returned with Feedback Michael Banck Simon Riggs 2014-11-15
INNER JOIN removals
Patch by davidrowley on 2014-10-15: Initial version.
Comment by simon on 2014-11-15: Looks good, but I personally think more work required yet.
Returned with Feedback David Rowley Simon Riggs 2014-11-18
Patch by michael-kun on 2014-10-30: Patch addressing previous comments, mainly docs and comments + a wart fix.
Patch by jjanes on 2014-11-17: rebased
Comment by michael-kun on 2014-11-20: Note: marked as returned with feedback by the author himself. I don't see much how things would move on for this CF.
Returned with Feedback Michael Paquier Nobody 2014-11-20
pg_background (and more parallelism infrastructure patches)
Patch by rhaas on 2014-09-09: Initial version.
Review by amitkapila on 2014-09-26: Few issues and suggestions.
Comment by rhaas on 2014-11-24: parallelism infrastructure patches committed; pg_background itself returned with feedback
Returned with Feedback Robert Haas, Amit Khandekar, Noah Misch Petr Jelinek, Andres Freund, Amit Kapila 2014-11-24
Access methods extendability
Patch by smagen on 2014-10-15: Initial version.
Review by heikki on 2014-11-24: Review
Returned with Feedback Alexander Korotkov Nobody 2014-11-24
Add ready_count counter to pg_stat_archiver
Review by abrightwell on 2014-10-21: Initial Review.
Patch by michael-kun on 2014-11-18: Rewrote the patch, current approach was not appropriate.
Review by michael-kun on 2014-11-18: Previous version counts as well as a review of the patch.
Returned with Feedback Julien Rouhaud Adam Brightwell 2014-11-24
Function returning the timestamp of last transaction
Patch by masaofujii on 2014-08-15: Per discussion, the problem which exists in current code should be fixed first. I attached the patch for that.
Comment by heikki on 2014-08-25: Marking this as "Waiting on Author" until the patch fixing the current code is committed
Comment by michael-kun on 2014-12-02: First patch adding barriers for pg_stat counter should be committed. Now main feature would be covered by commit timestamp machinery from Alvaro, so marking it as "returned with feedback".
Returned with Feedback Fujii Masao Nobody 2014-12-02
psql support for asciidoc table output
Review by okbobcz on 2014-11-02: no objections
Comment by simon on 2014-11-18: Alvaro found some bugs, Szymon/Pavel to fix
Comment by michael-kun on 2014-12-03: Some issues still not addressed. Marking as returned with feedback.
Returned with Feedback Szymon Guz Pavel Stehule 2014-12-03
Superuser Shortcut Cleanup
Patch by abrightwell on 2014-11-05: Addresses comments from review.
Patch by abrightwell on 2014-11-21: updated patch focusing solely on superuser shortcut cleanup.
Review by petere on 2014-12-06: still issues
Returned with Feedback Adam Brightwell Peter Eisentraut 2014-12-06
Selectivity estimation for inet operators
Patch by hasegeli on 2014-09-27: Version 12.
Patch by tgl on 2014-12-01: Updated patch, also some gripes about remaining loose ends.
Comment by tgl on 2014-12-01: We need to reduce the runtime when there are a lot of statistics, too.
Returned with Feedback Emre Hasegeli Tom Lane 2014-12-08
scalable LWLocks
Review by amitkapila on 2014-06-26: Findings related to modifications in lwlock variants.
Review by amitkapila on 2014-10-22: tpc-b results seems to be okay, however observed one intermittent hang
Review by amitkapila on 2014-10-22: Few comments are yet to be addressed.
Returned with Feedback Andres Freund Peter Geoghegan, Amit Kapila 2014-12-08
GIST vacuum sequential access
Patch by chapaev28 on 2014-09-07: Initial version.
Comment by chapaev28 on 2014-09-11: Discussion of patch.
Comment by jjanes on 2014-10-17: I think it can't benefit from further review in its current state.
Returned with Feedback Constantine Kuznetsov Nobody 2014-12-08
Event triggers: object creation support
Review by michael-kun on 2014-11-05: Extra review of patches 1-3.
Review by michael-kun on 2014-11-05: Some input on patch 4.
Review by michael-kun on 2014-11-05: More infrastructure for jsonb should be implemented instead of the ObjTree stuff to allow in-memory manipulation of JSONB data, useful for this feature, and for potential extensions playing with JSONB.
Returned with Feedback Álvaro Herrera Michael Paquier 2014-12-08
Detect custom-format dumps as psql input and suggest pg_restore
Patch by ringerc on 2014-10-17: Initial version.
Review by jeevan.chalke on 2014-10-17: Initial Review with few comments
Returned with Feedback Craig Ringer Jeevan Chalke 2014-12-08
Scaling shared buffer eviction
Review by andresfreund on 2014-09-11: Review spotting some minor/medium things, looking good otherwise
Patch by amitkapila on 2014-09-20: Fixed review comments raised by Andres
Patch by amitkapila on 2014-10-14: Rebased the remaining patch to add a new process bgreclaimer to move buffers to free list.
Returned with Feedback Amit Kapila Andres Freund 2014-12-09
deparse DDL in event triggers
Review by michael-kun on 2014-12-15: Concerns by Tom about the overhead this feature would create for developers.
Comment by michael-kun on 2014-12-15: Other concerns from Robert.
Review by michael-kun on 2014-12-15: Marking as returned with feedback. On top of the other concerns expressed, having ObjTree instead of a better API base for jsonb is not a good thing thinking long-term maintenance.
Returned with Feedback Álvaro Herrera Nobody 2014-12-15
KNN-GiST with recheck
Review by hasegeli on 2014-09-25: Code review
Comment by smagen on 2014-10-15: Architecture thoughts.
Comment by michael-kun on 2014-12-15: Based on those comments, binary heap method is preferable, hence marking this patch as returned with feedback.
Returned with Feedback Alexander Korotkov Emre Hasegeli 2014-12-15
WIP: dynahash replacement for buffer table
Patch by rhaas on 2014-10-14: Initial version.
Review by michael-kun on 2014-12-15: Review by Andres.
Comment by michael-kun on 2014-12-15: Switching to returned with feedback because of lack of activity.
Returned with Feedback Robert Haas Andres Freund 2014-12-15
Lockless StrategyGetBuffer
Patch by andresfreund on 2014-10-17: Initial version.
Comment by michael-kun on 2014-12-15: Marked as returned with feedback due to lack of activity lately as there are still problems with in buffer mapping locks. Note that this last problem may be due to problems with HEAD as well on ppc.
Returned with Feedback Andres Freund Nobody 2014-12-15
pgcrypto: support PGP signatures
Patch by johto on 2014-10-28: Patch v8, v6 re-rebased
Patch by johto on 2014-11-01: Patch v9, bug fix of MDC handling
Comment by michael-kun on 2014-12-15: v9 still has some bugs and has not been updated in a while. Switching back to returned with feedback.
Returned with Feedback Marko Tiikkaja Joel Jacobson, Jeff Janes, Thomas Munro 2014-12-15