Log In - Home Page

CommitFest 2014-08 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 43, Returned with Feedback: 46, Rejected: 4. Total: 93.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Providing catalog view to pg_hba.conf file
Patch by vaishnavi on 2014-03-19: Initial version.
Review by jcasanov on 2014-06-08: This function should be superuser only or only show info related for
current_user if it user is not superuser?
Review by ams on 2014-06-29: Extensive changes needed
Returned with Feedback Vaishnavi Prabakaran Jaime Casanova, Abhijit Menon-Sen 2014-06-30
idle_in_transaction_session_timeout
Review by kgrittn on 2014-06-21: Want new patch based on v1 with new name and units.
Patch by xocolatl on 2014-06-21: v3: new patch based on v1 with new name and units
Comment by tgl on 2014-06-29: I don't think this is a safe implementation.
Returned with Feedback Vik Fearing Kevin Grittner 2014-07-30
Postgres Hibernator contrib module
Patch by singh.gurjeet on 2014-06-02: Bug-fix and other improvements.
Review by maumau on 2014-07-05: Build failure on Windows, and comments on files except for the main pg_hibernator.c
Review by maumau on 2014-07-10: Review of pg_hibernator.c, and finished reviewing code
Returned with Feedback Gurjeet Singh MauMau 2014-08-05
Facility for FPW consistency at WAL replay and page masking
Patch by michael-kun on 2014-07-23: Initial version.
Returned with Feedback Michael Paquier Nobody 2014-08-13
lowering array_agg memory requirements
Patch by fuzzycz on 2014-03-28: Initial version.
Comment by ams on 2014-07-02: New version to be posted.
Comment by heikki on 2014-08-20: Nothing's happened, so marking as returned with feedback.
Returned with Feedback Tomas Vondra Pavel Stehule 2014-08-20
Add backup profile to base backup
Patch by mnencia on 2014-08-18: Initial version.
Returned with Feedback Marco Nenciarini Heikki Linnakangas 2014-08-20
Ignore Ctrl-C/Break on Windows
Patch by chrullrich on 2014-04-20: Initial version.
Review by maumau on 2014-06-21: Doesn't apply to HEAD, and some issues
Comment by heikki on 2014-08-20: No activity since July, marking as returned with feedback
Returned with Feedback Christian Ullrich MauMau 2014-08-20
more active plugins support
Review by johto on 2014-01-16: Initial review
Patch by okbobcz on 2014-02-10: plugin info per plugin and plpgsql exec state
Comment by heikki on 2014-08-21: waiting for a new version using different approach to plugin registration
Returned with Feedback Pavel Stehule Marko Tiikkaja 2014-08-21
Memory-bounded HashAgg
Patch by jdavis on 2014-08-10: Initial version.
Comment by heikki on 2014-08-26: Summary
Returned with Feedback Jeff Davis Nobody 2014-08-26
CSN snapshots
Patch by heikki on 2014-06-16: Initial version.
Returned with Feedback Heikki Linnakangas Kevin Grittner 2014-08-27
Memory accounting towards memory-bounded HashAgg
Patch by jdavis on 2014-08-10: Fixed problem.
Patch by jdavis on 2014-08-20: Uses smaller fields for MemoryContextData.
Review by fuzzycz on 2014-08-23: benchmarking the current patches, proposal of separating the accounting hierarchy
Returned with Feedback Jeff Davis Tomas Vondra 2014-08-29
REINDEX USER TABLES
Patch by xocolatl on 2014-08-01: Initial version.
Review by johto on 2014-09-02: Looks like a way forward
Comment by sfrost on 2014-09-10: Further comments.
Returned with Feedback Vik Fearing Marko Tiikkaja 2014-09-10
Synchronous replication for multiple standbys
Review by rajeevrastogi03 on 2014-08-27: Provided few more comments.
Patch by michael-kun on 2014-08-30: v8: Comments addressed, docs improved, simplified priority calculation.
Comment by michael-kun on 2014-09-12: Marking as returned with feedback. An agreement on the next directions for this patch would be great.
Returned with Feedback Michael Paquier Kumar Rajeev Rastogi 2014-09-12
Event triggers: object creation support
Patch by alvherre on 2014-06-13: updated version
Review by michael-kun on 2014-08-27: Review of patches 2,5,8,9,10,11,12,13. Necessary to get that done first before looking at the core part.
Comment by michael-kun on 2014-09-20: Patches up to 14 reviewed. A rebase is necessary.
Returned with Feedback Álvaro Herrera Michael Paquier 2014-09-20
pg_shmem_allocations view
Review by michael-kun on 2014-08-18: Comments for patch 1.
Review by michael-kun on 2014-08-18: Comments for patch 2: some minor problems found.
Comment by michael-kun on 2014-09-20: No new patch version since security issues have been discussed and review has been done...
Returned with Feedback Andres Freund Euler Taveira, Michael Paquier 2014-09-20
Specifying the unit in storage parameter
Patch by masaofujii on 2014-08-25: Fixed the reported issue. Updated version of the patch.
Comment by masaofujii on 2014-09-01: Marked as waiting on author again because the committed patch has the problem and we reverted the commit.
Comment by michael-kun on 2014-09-20: Patch is proving to need more care because of the way reloptions are stored for pg_class.
Returned with Feedback Fujii Masao Michael Paquier 2014-09-20
Minmax indexes
Comment by heikki on 2014-06-23: Need some comments from author on generalizing the opclasses.
Patch by alvherre on 2014-09-08: v18
Review by heikki on 2014-09-10: Review comments on v18
Returned with Feedback Álvaro Herrera Heikki Linnakangas 2014-09-23
Handler for temporary/transient tablespaces
Patch by matheus.oliveira on 2014-06-28: Initial version.
Review by masaofujii on 2014-08-19: pg_dumpall generates problematic SQL regarding temporary tablespace.
Returned with Feedback Matheus de Oliveira <matioli.matheus@gmail.com> Viswanatham KiranKumar, Fujii Masao 2014-09-23
New Model For Role Attributes and Fine Grained Permssions
Review by heikki on 2014-08-20: Quick review: docs missing, not sure if the syntax is OK
Review by sfrost on 2014-09-23: Additional review
Comment by sfrost on 2014-09-23: Sufficient review for POC in this CF (which needs to be moving along...). Marking returned-with-feedback.
Returned with Feedback Adam Brightwell Nobody 2014-09-23
Partial sort
Patch by smagen on 2014-09-13: Revised version of patch
Comment by pgeoghegan on 2014-09-14: Can we save some more (potentially expensive) B-Tree support function 1 comparisons as we group tuples into groupings to be sub-sorted (tuples returned by leading attribute index scan)?
Review by pgeoghegan on 2014-09-14: Thoughts on structure of patch, tuplesort interfacing
Returned with Feedback Alexander Korotkov David Rowley, Peter Geoghegan 2014-09-23
XLogLockBlockRangeForCleanup
Comment by amitdkhan on 2014-07-07: Assigned to author, since performance results are pending.
Patch by ams on 2014-07-07: Updated patch
Review by heikki on 2014-08-20: Opinion on the chosen API.
Returned with Feedback Simon Riggs, Abhijit Menon-Sen Nobody 2014-09-23
Optimization for updating foreign tables in Postgres FDW
Comment by sfrost on 2014-09-23: Comments that this is most likely not the right approach.
Comment by sfrost on 2014-09-23: Furhter comments on approach.
Comment by sfrost on 2014-09-23: Comments from author and indication that it'll be worked on in the next CF, marking 'returned with feedback'
Returned with Feedback Etsuro Fujita Shigeru Hanada, Laurenz Albe 2014-09-23
Index-only scans for GIST
Comment by heikki on 2014-08-20: Memory leak needs to be fixed.
Comment by hasegeli on 2014-10-07: Previous discussion about the patch.
Comment by hasegeli on 2014-10-07: Discussion about the changes in amcanreturn() interface to support multicolumn indexes.
Returned with Feedback Lubennikova Anastasia Nobody 2014-09-23
Extended Prefetching using Asynchronous IO
Patch by johnlumby on 2014-08-19: Initial version.
Review by heikki on 2014-08-20: Still sharing aiocb structs across backends, plus a bunch of other issues.
Returned with Feedback John Lumby & Claudio Freire Heikki Linnakangas 2014-09-23
KNN for SP-GiST
Patch by quadrocube on 2014-08-20: Initial version.
Review by heikki on 2014-08-20: Cleanup required. Should use a binary heap.
Returned with Feedback Vlad Sterzhanov / Quadrocube Heikki Linnakangas 2014-09-23
Better syntax for REINDEX
Patch by xocolatl on 2014-08-01: Initial version.
Comment by xocolatl on 2014-08-01: this is based on top of the REINDEX USER TABLES patch
Returned with Feedback Vik Fearing Álvaro Herrera 2014-09-23
pg_resetxlog option to change system identifier
Review by masahikosawada on 2014-06-26: reviewed
Patch by pjmodos on 2014-06-26: some more refinements
Review by heikki on 2014-08-25: The user interface and documentation needs work.
Returned with Feedback Petr Jelinek Sawada Masahiko 2014-09-23
Enable WAL archiving even in standby
Patch by masaofujii on 2014-08-13: Initial version.
Review by alexk on 2014-09-08: Some implementation-related questions
Returned with Feedback Fujii Masao Alexey Klyukin 2014-09-23
Immediate standby promotion
Patch by masaofujii on 2014-08-14: Initial version.
Review by amitkapila on 2014-09-02: Review comments and one issue.
Returned with Feedback Fujii Masao Amit Kapila 2014-09-23
WAL format & API changes
Review by michael-kun on 2014-08-20: Review of patches 1 and 2. Patch 1 looks good to go after renaming XLogReplayBuffer.
Patch by michael-kun on 2014-09-23: Updated patch by Heikki, with performance tests.
Review by michael-kun on 2014-09-23: Some comments at code level for 1st patch.
Returned with Feedback Heikki Linnakangas Michael Paquier 2014-09-23
[TODO] Process pg_hba.conf keywords as case-insensitive
Patch by kiranviswa on 2014-07-23: Fixed Tom Lane comments.
Review by heikki on 2014-08-21: Small bug fix and doc update required
Review by horiguti on 2014-09-09: Dittto.
Returned with Feedback Viswanatham Kiran Kumar, Dilip Kumar Kyotaro Horiguchi 2014-09-23
add modulo operator to pgbench
Patch by calvin on 2014-09-08: v4 is v3 with a better doc suggested by the review.
Patch by mitsu-ko on 2014-09-08: fix document.
Comment by heikki on 2014-09-23: We need infrastructure for operators/functions in pgbench
Returned with Feedback Fabien Coelho Mitsumasa KONDO 2014-09-23
PL/PgSQL warning - num_into_expressions
Patch by johto on 2014-07-21: Initial version.
Patch by johto on 2014-08-06: Patch v1
Review by heikki on 2014-08-21: One little suggestion, looks good otherwise
Returned with Feedback Marko Tiikkaja Pavel Stehule 2014-09-23
contrib/fastbloat - tool for quickly assessing bloat stats for a table
Patch by ams on 2014-04-25: Initial version.
Review by amitkapila on 2014-08-05: review comments and suggestions
Returned with Feedback Abhijit Menon-Sen Jaime Casanova, Amit Kapila 2014-09-23
pg_copy - a command for reliable WAL archiving
Patch by maumau on 2014-06-19: Removed an extra hunk for dblink fix
Patch by maumau on 2014-08-14: some minor fixes
Comment by masaofujii on 2014-08-15: "copy to temp + rename to actual name" feature should be supported, I think.
Returned with Feedback MauMau Fujii Masao 2014-09-23
improving speed of make check-world
Patch by petere on 2014-08-15: Initial version.
Review by heikki on 2014-08-25: Needs doc update
Review by calvin on 2014-08-31: some issues, questions & suggestions.
Returned with Feedback Peter Eisentraut Fabien Coelho, Heikki Linnakangas 2014-09-23
delta relations in AFTER triggers
Review by heikki on 2014-08-27: Should use hooks
Patch by kgrittn on 2014-09-15: Eliminated all SPI usage from parser/planner/executor, but passed similar to normal parameters rather than using hooks.
Comment by heikki on 2014-09-24: Marking as "Returned with feedback", as this has been discussed in depth during this commitfest. I'm not sure we've reached a consensus on how to continue, but we can continue the discussion outside the commitfest.
Returned with Feedback Kevin Grittner David Fetter, Amit Khandekar 2014-09-24
Correctly place DLLs for ECPG apps in bin folder
Patch by maumau on 2013-12-08: Initial version.
Patch by petere on 2014-08-15: Also consider this patch in conjunction, which does the same thing in the mingw build in a more general way (should be backpatched).
Comment by heikki on 2014-09-24: No response from patch author or reviewers. Returned with feedback.
Returned with Feedback MauMau Muhammad Asif Naeem 2014-09-24
rounding up time value less than its unit
Patch by tomonari katsumata on 2014-09-12: New version patch.
Comment by heikki on 2014-09-12: The latest patch implements the consensus that was reached, marking as Ready for Committer
Review by sfrost on 2014-09-23: Minor comments; leaving as ready-for-committers as the remaining changes are pretty minor, unless there are objections to them for some reason.
Returned with Feedback Tomonari Katsumata Nobody 2014-09-26
LIMIT for UPDATE and DELETE
Comment by rukhmeski on 2014-08-27: Jeff's detailed response describing the common use cases
Comment by rukhmeski on 2014-08-27: Kevin's input on the use cases
Comment by heikki on 2014-09-27: Let's rewrite inheritance_planner first
Returned with Feedback KaiGai Kohei, Etsuro Fujita 2014-09-27
Reducing impact of hints/cleanup for SELECTs
Review by michael-kun on 2014-09-12: Review from Amit: DDL code path broken for MarkBufferDirty, other things noticed
Review by michael-kun on 2014-09-12: Comments still not addressed. Patch needs a rebase.
Comment by simon on 2014-09-17: v5 with substantially changed design following input from Alvaro and Tom
Returned with Feedback Simon Riggs Nobody 2014-09-27
Compression of Full Page Writes
Patch by rahila.syed on 2014-08-19: Patch to compress multiple blocks of a record together. Memory allocation is moved out of critical section. Backup blocks are compressed without hole as in the original code to back up the blocks in WAL.
Patch by rahila.syed on 2014-09-23: Patch to compress FPW using pglz. This patch compresses all backup blocks in WAL record at once. full_page_writes GUC had been modified to accept literals 'on', 'compress' 'off'
Comment by andresfreund on 2014-09-29: A fair amount of work left to be done.
Returned with Feedback Pavan Deolasee , Rahila Syed Abhijit Menon-Sen 2014-09-29
INNER JOIN removals
Patch by davidrowley on 2014-08-17: Updated version and planner benchmarks
Patch by davidrowley on 2014-09-12: No interest in Semi/anti join patch, here one for INNER JOIN removal
Comment by heikki on 2014-09-29: Need to make this work without the assumption that there are no data changes between planning and execution.
Returned with Feedback David Rowley Nobody 2014-09-29
event triggers: more DROP info
Comment by andresfreund on 2014-08-26: There rather likely have been (private) changes since the last version.
Patch by alvherre on 2014-08-27: updated
Review by abrightwell on 2014-09-16: Review of updated patch. Applies successfully, checks pass, multiple FIXME statements still exist, any plans to resolve?
Returned with Feedback Álvaro Herrera Adam Brightwell 2014-10-03
Escaping from blocked send() by pg_terminate_backend().
Patch by heikki on 2014-09-26: Another patch.
Comment by andresfreund on 2014-09-29: And yet another patch, based on latches.
Patch by horiguti on 2014-10-09: Escaping from blocking patch based on Andres's patch 1 to 3.
Returned with Feedback Kyotaro Horiguchi Heikki Linnakangas 2014-10-05
pg_receivexlog --status-interval add fsync feedback
Patch by osamufuruya on 2014-09-05: Be applied to the head.
Comment by heikki on 2014-09-27: I don't understand this patch, marked as Waiting on Author, for clarification
Comment by heikki on 2014-10-13: Should have just a single --synchronous flag
Returned with Feedback Osamu Furuya Sawada Masahiko 2014-10-13