Log In - Home Page

CommitFest 2014-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 30, Returned with Feedback: 16, Rejected: 6. Total: 52.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
heapify speedup
Patch by jgh on 2014-02-05: Initial version.
Patch by davidrowley on 2014-08-01: Working link to updated patch
Returned with Feedback Jeremy Harris Nobody 2014-04-11
slow startup due to LWLockAssign() spinlock
Patch by andresfreund on 2014-03-31: Initial version.
Comment by andresfreund on 2014-06-16: Simple approach not well liked - the proper way is to allocate the buffer manager lwlocks separately.
Returned with Feedback Andres Freund Nobody 2014-06-16
Extended Prefetching using Asynchronous IO
Patch by johnlumby on 2014-06-11: new version of patch based on git head of 140608
Review by masaofujii on 2014-06-20: Compilation error on MacOS.
Review by heikki on 2014-06-20: Broken design
Returned with Feedback Claudio Freire and John Lumby Nobody 2014-06-20
multibyte messages are displayed incorrectly on the client
Patch by maumau on 2013-12-26: Initial version.
Comment by petere on 2014-01-11: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/296/
Patch by maumau on 2014-01-24: As a happy compromise, disable message localization only when the client encoding differs from the server one
Returned with Feedback MauMau Yugo Nagata 2014-06-23
Patch by rukhmeski on 2014-02-22: Initial version.
Patch by rukhmeski on 2014-03-12: Fix problems with concurrency and LIMIT.
Review by heikki on 2014-06-24: Amit pointed out that it doesn't work with inheritance.
Returned with Feedback Heikki Linnakangas 2014-06-24
Better partial index-only scans
Patch by pythonesque on 2014-03-16: Initial version.
Review by hasegeli on 2014-06-29: Thoughts about the options suggested by the author.
Review by tgl on 2014-06-30: A few thoughts about the issues raised by the author.
Returned with Feedback Joshua Yanovski Emre Hasegeli, Tom Lane 2014-07-01
Spread shared memory across NUMA memory nodes
Patch by kgrittn on 2014-06-08: Initial version.
Review by kaigai on 2014-06-26: What interaction is expected with automatic numa balancing feature in the recent Linux kernel?
Returned with Feedback Kevin Grittner KaiGai Kohei 2014-07-03
Allow NOT IN to use anti joins
Review by jeevan.chalke on 2014-07-09: Looks good to me. No issues found.
Comment by andresfreund on 2014-07-13: Not yet ready.
Comment by tgl on 2014-07-15: Closer but not ready yet.
Returned with Feedback David Rowley Jeevan Chalke 2014-07-15
X509v3 extension functions in sslinfo module
Review by kandreas on 2014-06-23: Nice feature but code and API needs some improvment.
Patch by dimv36 on 2014-07-18: Version 2.0
Review by michael-kun on 2014-07-18: Patch still needs a lot of work.
Returned with Feedback Dmitry Voronin Andreas Karlsson 2014-07-18
WAL format & API changes
Comment by michael-kun on 2014-06-27: Review of v1: several crashes reported, comments, etc.
Patch by michael-kun on 2014-07-03: Patch v2: fixes and review of exiting APIs
Review by michael-kun on 2014-07-03: Crash found in gin code, for WAL record creation.
Returned with Feedback Heikki Linnakangas Michael Paquier 2014-07-19
Lag & Lead Window Functions Can Ignore Nulls
Patch by njw45 on 2014-04-16: I've fixed the outstanding issues from my last review.
Review by jdavis on 2014-07-07: Also a WIP patch to show how I'm refactoring it.
Patch by jdavis on 2014-07-11: Still a few open issues and some refactoring to do.
Returned with Feedback Nick White, Troels Nielsen Jeff Davis, Álvaro Herrera 2014-07-22
Use unique index for longer pathkeys
Comment by amitkapila on 2014-07-21: some suggestions and questions related to patch.
Patch by horiguti on 2014-07-24: A bug fix, and reply to the comment.
Comment by horiguti on 2014-07-25: I drop this patch and try it reintegrate into another patch. So this patch is closed. Thank you.
Returned with Feedback Kyotaro Horiguchi Amit Kapila 2014-07-25
change alter user to be a true alias for alter role
Review by xocolatl on 2014-06-19: there's really not much to review here, it's a very simple patch.
Comment by tgl on 2014-06-19: I think this could be done better ...
Patch by jov on 2014-08-22: I make the v2 of the patch,use Tom's advice.

But I can't make ROLE and USER in the keyword list,it is hard to solve the
conflict,or rewrite many gram rules.
the problem is :

role_or_user : ROLE | USER;
xx_keyword:...| ROLE|...|USER..;

this two rules produce conflict.So in v2,I remove ROLE and USER from the
xx_keyword rule now.
Returned with Feedback Jov Vik Fearing 2014-08-05
"RETURNING PRIMARY KEY" syntax extension
Patch by ibarwick on 2014-06-09: Initial version.
Patch by ibarwick on 2014-06-26: Revised patch.
Review by rlathia on 2014-07-02: Shared the review points.
Returned with Feedback Ian Barwick Rushabh Lathia 2014-08-05
showing index update time on EXPLAIN
Patch by jcasanov on 2014-05-08: Initial version.
Review by haribabu on 2014-06-20: minor review comments
Returned with Feedback Jaime Casanova Hari Babu 2014-08-07
Buffer capture facility: check WAL replay consistency
Comment by horiguti on 2014-07-24: I'll mark this as 'Ready for Committer' if no comments from others in a few days.
Comment by horiguti on 2014-07-25: Mark as 'Ready for Committer'
Comment by michael-kun on 2014-08-15: Not sure that this is acceptable as-is.
Returned with Feedback Michael Paquier, Heikki Linnakangas Kyotaro Horiguchi 2014-08-15