Log In - Home Page

CommitFest 2014-01 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 76, Returned with Feedback: 22, Rejected: 4. Total: 102.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
plpgsql.consistent_into
Patch by johto on 2014-01-12: Initial version.
Review by johto on 2014-01-15: Possible way forward, author unsure whether he has the energy to pursue for 9.4.
Comment by johto on 2014-01-15: A bit unrealistic for 9.4, focusing on other patches instead.
Returned with Feedback Marko Tiikkaja Nobody 2014-01-15
Hide other user's application name from non-superusers
Patch by hgimenez on 2014-01-21: Initial version.
Comment by simon on 2014-01-29: More complex approach desired, not for 9.4
Returned with Feedback Harold Giménez Nobody 2014-01-29
INSERT...ON DUPLICATE KEY LOCK FOR UPDATE
Patch by pgeoghegan on 2014-01-08: v7 of patch, fixing issues relating to visibility. Also includes miscellaneous polishing.
Comment by pgeoghegan on 2014-01-10: Summary of current situation. Benchmark that measures extended heavyweight page locking overhead.
Comment by petere on 2014-01-11: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/307/
Returned with Feedback Peter Geoghegan Heikki Linnakangas 2014-02-10
psql \copy doesn't end if backend is killed
Patch by maumau on 2013-12-26: Initial version.
Comment by petere on 2014-01-11: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/300/
Comment by tgl on 2014-02-14: This issue got fixed in another way (and I have doubts about this patch anyhow).
Returned with Feedback MauMau Dilip Kumar 2014-02-14
Filter error log statements by sqlstate
Review by tgl on 2014-01-16: Concerns about usefulness, definition, and code correctness.
Comment by petere on 2014-01-16: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/330/
Comment by andresfreund on 2014-02-15: Author doesn't have time for it in 9.4.
Returned with Feedback Oskari Saarenmaa Jeevan Chalke 2014-02-15
Set visibility map and hint bits for VACUUM FULL and CLUSTER operations
Comment by petere on 2014-01-31: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/336/
Review by andresfreund on 2014-02-15: I don't think the current approach can work as-is.
Comment by andresfreund on 2014-02-16: Won't be done in 9.4
Returned with Feedback Bruce Momjian Jaime Casanova 2014-02-16
Add support to "IF NOT EXISTS" to others "CREATE" statements
Comment by okbobcz on 2014-01-30: Tom Lane's reply
Comment by okbobcz on 2014-01-30: for selected objects should be implemented CREATE OR REPLACE insted CREATE IF NOT EXISTS to be consistent with current implementation.
Comment by alvherre on 2014-02-28: returned due to extensive rework needed
Returned with Feedback Fabrízio de Royes Mello Pavel Stehule 2014-02-28
Drop duplicate buffers in OS
Patch by mitsu-ko on 2014-01-15: Initial version.
Comment by jjanes on 2014-01-28: Waiting on benchmark which shows a benefit
Comment by rhaas on 2014-03-04: insufficient performance proof points to consider a commit
Returned with Feedback Mitsumasa KONDO Nobody 2014-03-04
Optimize kernel readahead using buffer access strategy
Patch by mitsu-ko on 2014-01-14: Initial version.
Comment by andresfreund on 2014-02-15: Waiting on further benchmarks by the Author.
Returned with Feedback Mitsumasa KONDO Nobody 2014-04-04
RETURNING...AFTER/BEFORE
Patch by dfetter on 2014-02-02: Coding style fixups.
Patch by dfetter on 2014-02-12: Comments by Karol.
Comment by andresfreund on 2014-04-04: Needs a fair amount of work, approach isn't agreed upon.
Returned with Feedback Karol Trzcionka Zoltán Böszörményi, Robert Haas, David Fetter 2014-04-04
Store Extension Options
Patch by andresfreund on 2014-02-15: New Version
Review by ams on 2014-02-28: Minor documentation quibbles
Patch by fabriziomello on 2014-02-28: New version
Returned with Feedback Fabrízio de Royes Mello Pavel Stehule 2014-04-04
Exposing currentTransactionWALVolume
Patch by simon on 2014-01-14: Initial version.
Review by andresfreund on 2014-02-15: Minimal review.
Returned with Feedback Simon Riggs Mitsumasa KONDO 2014-04-04
WAL rate limiting
Patch by jjanes on 2014-02-05: new version
Review by 3manuek on 2014-02-21: Reviewed the basic functionality. I see a decrease of the load average using the delay. I'll continue the tests:

Fri Feb 21 23:01:38 UTC 2014
CLUSTER
CREATE INDEX
Fri Feb 21 23:01:47 UTC 2014
DROP TABLE
23:01:48 up 23:15, 4 users, load average: 0.89, 0.65, 0.52
wal_rate_limit
----------------
0
(1 row)

ALTER TABLE
UPDATE 10000
server signaled
wal_rate_limit
----------------
100ms
(1 row)

Fri Feb 21 23:02:24 UTC 2014
CLUSTER
CREATE INDEX
Fri Feb 21 23:02:33 UTC 2014
DROP TABLE
23:02:33 up 23:16, 4 users, load average: 0.74, 0.64, 0.52
server signaled
Comment by petere on 2014-02-25: no consensus on scope of this patch
Returned with Feedback Simon Riggs Nobody 2014-04-06
Widening application of indices.
Comment by tgl on 2014-04-09: Patch definitely needs work still.
Patch by horiguti on 2014-04-14: Avoid running unnecessary rounds and added a comment for the dubious loop to make its purpose clearer, and rebased.
Review by tgl on 2014-04-18: There's a better way to do it: we should be recognizing the query pathkeys as redundant.
Returned with Feedback Kyotaro Horiguchi (Etsuro Fujita in CF3) 2014-04-18
Custom Scan APIs
Patch by kaigai on 2014-03-12: Patch v10; revised according to Tom's suggestion that intends to work custom node as a base class of polymorphismic class.
Patch by kaigai on 2014-03-17: Patch v11; little bit enhancement to expose fix_scan_expr()
Patch by kaigai on 2014-03-28: Patch v13; eliminate duplicated typedefs
Returned with Feedback KaiGai Kohei Jim Mlodgenski, Shigeru HANADA 2014-05-29
cache-only table scan
Patch by kaigai on 2014-02-20: revised patch, according to the comments
Patch by kaigai on 2014-03-04: revised patch, with a benchmark result
Patch by kaigai on 2014-03-17: Rebased to the latest custom-plan interface, and fixup synchronization logic on vacuum pages.
Returned with Feedback KaiGai Kohei Hari Babu 2014-05-29
Using indices for UNION
Patch by horiguti on 2014-01-14: Initial version.
Patch by horiguti on 2014-01-14: The first message missing patch itself. This is it.
Review by tgl on 2014-04-04: Can't generate the DISTINCT clause that way.
Returned with Feedback Kyotaro Horiguchi Tom Lane 2014-05-29
Enable CREATE FOREIGN TABLE (... LIKE ... )
Review by michael-kun on 2014-02-17: Review of v8: issues with documentation, regression tests and implementation.
Patch by michael-kun on 2014-02-17: Added v9 with review of v8 actually as I found a couple of things...
Comment by dfetter on 2014-02-18: More in-depth analysis of the patch and its consequences.
Returned with Feedback David Fetter Vik Fearing, Michael Paquier 2014-05-29
Add min, max, and stdev execute statement time in pg_stat_statement
Comment by mitsu-ko on 2014-01-14: I will revise for latest HEAD.
Patch by mitsu-ko on 2014-01-21: Revise for latest HEAD.
Comment by petere on 2014-01-28: discussion ongoing
Returned with Feedback Mitsumasa KONDO Simon Riggs 2014-05-29
ECPG cursor readahead
Comment by a.houska on 2014-01-31: I spent some time (nearly a working day) reviewing this. Part 25 is the last I managed so far. If someone wants to continue, please let me know. Otherwise I'll try to finish it next week and send the summary to -hackers.
Patch by zboszor on 2014-04-16: Rebased patchset.
Review by a.houska on 2014-04-23: Finished the review that I started earlier.
Returned with Feedback Zoltán Böszörményi Nobody 2014-05-29
transforms
Patch by petere on 2014-01-16: updated patch (previous one got lost?)
Review by andresfreund on 2014-04-04: Good direction, but imo a good chunk of work is needed.
Review by andresfreund on 2014-04-09: Some issues, needs rebase.
Returned with Feedback Peter Eisentraut Nobody 2014-05-29
extension_control_path
Patch by dim on 2014-01-27: Patch version 1. Fixes all comments.
Review by smurav on 2014-01-30: Version 1 looks fine.
Comment by petere on 2014-01-31: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/341/
Returned with Feedback Dimitri Fontaine Nobody 2014-05-29