Log In - Home Page

CommitFest 2013-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 42, Returned with Feedback: 31, Rejected: 9. Total: 82.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Statistics collection for CLUSTER command
Comment by snaga on 2013-09-16: Need additional test cases. See attached one.
Patch by glaucous on 2013-10-15: added additional test cases, per review
Review by nmisch on 2013-10-20: Widening the stats files imposes too much distributed cost
Returned with Feedback Vik Fearing Satoshi Nagayasu 2013-10-26
SQL assertions prototype
Patch by petere on 2013-11-15: Initial version.
Comment by petere on 2013-11-16: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/220/
Comment by tgl on 2013-11-17: Heikki's comments are probably sufficient review for the moment ...
Returned with Feedback Peter Eisentraut Nobody 2013-11-18
Add accurate option to pgbench
Patch by mitsu-ko on 2013-10-31: Initial version.
Comment by petere on 2013-11-07: builds OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/169/
Comment by heikki on 2013-11-21: The consensus seems to be that we should document the steps instead.
Returned with Feedback Mitsumasa KONDO Nobody 2013-11-21
REINDEX CONCURRENTLY
Patch by michael-kun on 2013-11-18: Some documentation added
Review by andresfreund on 2013-11-18: Open concurrency issues
Comment by michael-kun on 2013-11-27: Won't be able to allocate time fot that by the end of the CF. It would have been good to see the 1st 2 patches committed...
Returned with Feedback Michael Paquier Nobody 2013-11-27
Cube extension kNN support
Comment by maiku41 on 2013-11-21: Doesn't pass regression tests
Patch by kelvich on 2013-12-03: Updated patch.
Comment by petere on 2013-12-11: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/275/
Returned with Feedback Stas Kelvich Nobody 2013-11-30
Cube extension types support
Patch by kelvich on 2013-09-24: Initial version.
Comment by maiku41 on 2013-11-21: Doesn't build
Returned with Feedback Stas Kelvich Nobody 2013-11-30
Cube extension split algorithm fix
Comment by maiku41 on 2013-11-22: Patch needs work - compiler warnings.
Comment by maiku41 on 2013-11-22: Sent reviewer reminder.
Review by smagen on 2013-11-25: Initial review
Returned with Feedback Stas Kelvich Alexander Korotkov 2013-11-30
pg_fallocate
Comment by petere on 2013-11-07: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/170/
Comment by petere on 2013-11-17: issues
Comment by petere on 2013-11-17: more issues
Returned with Feedback Mitsumasa KONDO Nobody 2013-11-30
[PoC] pgstattuple2: block sampling to reduce physical read
Comment by snaga on 2013-09-14: Looking forward to seeing more feedback on this approach, in terms of design and performance improvement.
Patch by snaga on 2013-09-16: Fixed to eliminate SnapshotNow.
Comment by firozev on 2013-11-26: Waiting for the new patch.
Returned with Feedback Satoshi Nagayasu Hari Babu, Firoz E V 2013-11-30
pre-commit triggers
Comment by petere on 2013-11-17: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/229/
Review by ibarwick on 2013-11-18: Initial review, mainly from a usage point of view
Comment by maiku41 on 2013-11-22: Moved to Waiting on Author based on review feedback.
Returned with Feedback Andrew Dunstan Ian Barwick 2013-12-01
HStore Gin Speedup
Patch by dfetter on 2013-09-16: Reworked the patch by adding a new hstore gin opclass
(gin_hstore_combined_ops) and leaving the functionality of the default
hstore gin opclass the same.
Comment by tgl on 2013-11-17: I wonder how this interacts with the "HStore 2.0" patch ...
Review by a.houska on 2013-11-25: Initial review. I'll check more as soon as the patch is applicable to the current master branch.
Returned with Feedback Blake Smith Antonin Houska 2013-12-02
Optimize kernel readahead using buffer access strategy
Patch by mitsu-ko on 2013-11-14: Initial version.
Review by masaofujii on 2013-11-14: Got compile error.
Comment by petere on 2013-11-15: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/205/
Returned with Feedback Mitsumasa KONDO Nobody 2013-12-05
Fix picksplit function with NaN values
Patch by smagen on 2013-09-10: Reworked version
Comment by maiku41 on 2013-10-16: Moved to CF 2013-11
Review by tgl on 2013-11-17: Still some things to fix, or else explain why these other places needn't consider NaNs.
Returned with Feedback Alexander Korotkov Tom Lane 2013-12-05
Freezing without write I/O
Patch by heikki on 2013-09-25: Updated patch
Comment by maiku41 on 2013-10-16: Moved to CF 2013-11 (CF end)
Review by andresfreund on 2013-11-18: Some more issues
Returned with Feedback Heikki Linnakangas Andres Freund 2013-12-07
Use MAP_HUGETLB where supported
Patch by heikki on 2013-11-14: Initial version.
Comment by petere on 2013-11-15: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/216/
Comment by tgl on 2013-11-17: Sameer Kumar got unimpressive performance results from this.
Returned with Feedback Abhijit Menon-Sen Heikki Linnakangas 2013-12-07
CLUSTER FREEZE
Review by davidrowley on 2013-11-19: review and an attempt at some docs
Comment by davidrowley on 2013-11-20: Waiting on doc changes
Comment by petere on 2013-12-08: Waiting for other patch that allows freezing while preserving forensic informtion.
Returned with Feedback Thomas Munro David Rowley 2013-12-08
Event triggers: CREATE statement info
Patch by alvherre on 2013-11-08: Initial version.
Review by cbbrowne on 2013-11-20: A preliminary review...

The patch works, has some issues (doesn't normalize enough).

There are some broader questions to discuss about intent.
Returned with Feedback Álvaro Herrera Christopher Browne 2013-12-08
plpgsql_check_function
Patch by okbobcz on 2013-08-23: rebased
Comment by maiku41 on 2013-10-16: Moved to CF 2013-11
Review by ssinger on 2013-12-07: Improvement on the output format
error messages and docs need work.
Did not do indepth review of the code
Returned with Feedback Pavel Stehule Nobody 2013-12-08
Track commit timestamp
Comment by petere on 2013-12-01: removed reviewer because of inactivity
Review by jcasanov on 2013-12-02: Patch, when the feature is on, drops performance significantly. In my tests it went from around 430tps to 0.3tps
Review by heikki on 2013-12-10: Reviewed. I don't think this is very useful as it is.
Returned with Feedback Álvaro Herrera Heikki Linnakangas 2013-12-12
standalone backend with full FE/BE protocol
Patch by amitkapila on 2013-11-14: Initial version.
Comment by petere on 2013-11-15: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/197/
Comment by petere on 2013-11-20: Several philosophical concerns have been raised. Need to decide which direction to take this in.
Returned with Feedback Tom Lane, Amit Kapila Nobody 2013-12-16
Packed posting lists in GIN
Comment by petere on 2013-11-27: needs rebase
Patch by smagen on 2013-12-08: Rebased version by Heikki Linnakangas
Patch by smagen on 2013-12-10: Version applies cleanly to head
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-12-16
Add min and max execute statement time in pg_stat_statement
Review by rajeevrastogi03 on 2013-11-21: Provided initial feedback.
Patch by petere on 2013-12-08: current patch
Comment by rajeevrastogi03 on 2013-12-13: Current patch does not contain changes related to feedback provided.
Returned with Feedback Mitsumasa KONDO Kumar Rajeev Rastogi 2013-12-16
GIN fast scan
Patch by smagen on 2013-11-14: Initial version.
Comment by petere on 2013-11-15: build failed: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/215/
Patch by petere on 2013-11-27: newer patch
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-12-16
UNION ALL on partitioned tables won't use indices.
Review by nmisch on 2013-11-23: I like the approach of changing inheritance-specific planner code to preserve append-flatness. One variant of the original test case still misbehaves, and a few other details deserve attention.
Patch by horiguti on 2013-11-26: Added regress for type 2 and 3. (Originally patch 3 and 4) And rebased.
Comment by petere on 2013-12-02: some concerns
Returned with Feedback Kyotaro Horiguchi Noah Misch 2013-12-16
Using indices for UNION
Comment by tgl on 2013-11-17: I think this approach is fundamentally misguided.
Patch by horiguti on 2013-11-19: Refactored. Split into two portions and rebased.
Patch by horiguti on 2013-11-22: Old patches are scrapped. Brand new approach.
Returned with Feedback Kyotaro Horiguchi Tom Lane 2013-12-16
Row-level Security
Comment by maiku41 on 2013-09-30: Still being worked on as of 9/22.
Comment by maiku41 on 2013-10-16: Moved to CF 2013-11
Review by gsmith on 2013-12-14: Initial bit rot merge. Feature demo testing code. Still needs regression test fixes, documentation improvements, and full catchup with master.
Returned with Feedback KaiGai Kohei Greg Smith, Jeff McCormick 2013-12-16
Replication Node Identifiers and crashsafe Apply Progress
Patch by andresfreund on 2013-11-14: Initial version.
Comment by andresfreund on 2013-11-22: Needs changes to accomodate review.
Returned with Feedback Andres Freund Nobody 2013-12-16
Gaussian distribution pgbench
Patch by mitsu-ko on 2013-09-20: Initial version.
Review by heikki on 2013-11-21: I'd like to see \setrandom with gaussian option instead
Review by petere on 2013-12-02: review
Returned with Feedback Mitsumasa KONDO Fabien Coelho 2013-12-16
COPY table FROM STDIN doesn't show count tag
Review by amitdkhan on 2013-12-09: Asked for a regression test.
Comment by rajeevrastogi03 on 2013-12-11: Asked for few clarifications. Waiting for input from reviewer.
Patch by rajeevrastogi03 on 2013-12-12: Updated patch.
Returned with Feedback Kumar Rajeev Rastogi Amit Khandekar 2013-12-16
Shave a few instructions from child-process startup sequence
Comment by petere on 2013-11-07: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/173/
Patch by singh.gurjeet on 2013-11-23: Patch that adds aseertions to make sure the assumptions hold true. On Peter E's suggestion.
Comment by petere on 2013-11-27: build unstable: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/243/
Returned with Feedback Gurjeet Singh Peter Eisentraut 2014-01-23
Widening application of indices.
Comment by petere on 2013-11-30: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/254/
Patch by efujita on 2013-12-03: Revised a bit.
Comment by petere on 2013-12-11: build OK: http://pgci.eisentraut.org/jenkins/job/postgresql_commitfest_world/273/
Returned with Feedback Kyotaro Horiguchi Etsuro Fujita 2014-01-23