Log In - Home Page

CommitFest 2009-07 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Rejected".

Status Summary. Committed: 37, Returned with Feedback: 24, Rejected: 5. Total: 66.

Rejected Patches

Patch Name Status Author Reviewers Date Closed
remove {join,from}_collapse_limit, add enable_join_ordering
Patch by rhaas on 2009-07-12: Initial version.
Review by andresfreund on 2009-07-16: Patch is technically fine, some doubts remain about possible regressions in plantime
Comment by rhaas on 2009-07-19: Testing by Tom and Andres has revealed that this change is presently not workable.
Rejected Robert Haas Tom Lane, Andres Freund 2009-07-19
Sampling Profiler
Patch by itagaki on 2009-07-14: adjust to HEAD.
Comment by dim on 2009-07-18: dim=# create table series(i integer);
dim=# insert into series select generate_series(1, 10000000);
WARNING: condition stack overflow: 11
ERROR: canceling statement due to user request
Comment by dim on 2009-07-21: Tom says: "For the record, I think this patch is a waste of manpower and we should rely on dtrace/systemtap."
Rejected Itagaki Takahiro Dimitri Fontaine 2009-07-21
user mapping extension to pg_ident.conf
Comment by larskanis on 2009-07-07: More description of the use followed here.
Comment by rhaas on 2009-07-22: Although this has not been assigned an official reviewer, it's been discussed extensively by Tom, Magnus (as linked here), and also commented on by Stephen Frost. It looks like it is a no-go in its present form, but maybe it can be reworked to be acceptable.
Comment by rhaas on 2009-07-24: Marking this rejected.
Rejected Lars Kanis Nobody 2009-07-24
dependencies for generated header files
Patch by rhaas on 2009-06-28: Initial version
Comment by rhaas on 2009-07-29: Peter wonders if src/backend/common.mk is better than src/Makefile.global.in, and will this conflict too much with "autogenerating headers & bki stuff".
Rejected Robert Haas Peter Eisentraut 2009-08-15
autogenerating headers & bki stuff
Comment by rhaas on 2009-07-02: if this last patch is applied, the previous two become moot
Patch by rhaas on 2009-07-21: updated to reflect commit of "pg_listener attribute number #defines"
Patch by rhaas on 2009-08-02: Stripped out the anum.h stuff.
Rejected Robert Haas Peter Eisentraut 2009-08-15