Log In - Home Page

CommitFest 2009-07 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 37, Returned with Feedback: 24, Rejected: 5. Total: 66.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
add_path optimization
Patch by rhaas on 2009-02-01: Initial version
Comment by tgl on 2009-02-28: it doesn't seem to work
Returned with Feedback Robert Haas Tom Lane 2009-02-28
Patch by kaigai on 2009-04-17: Initial version
Comment by kaigai on 2009-04-22: The matter is avoidable in another way.
Returned with Feedback KaiGai Kohei Nobody 2009-04-22
psql display sequence owner
Patch by jwilliams on 2008-12-07: Initial version
Comment by jwilliams on 2009-07-07: Please defer, patch is being redesigned.
Returned with Feedback Josh Williams Peter Eisentraut 2009-07-07
Synch Rep
Patch by MasaoFujii on 2009-07-14: Updated version (adjust to HEAD and fix some bugs)
Patch by MasaoFujii on 2009-07-15: Updated version (Introduce a new function XLogShutdownFlush() and revert the XLogFlush() api to the original)
Review by heikki on 2009-07-15: Summary of must-fix issues raised this far
Returned with Feedback Fujii Masao Peter Eisentraut, Heikki Linnakangas 2009-07-15
Security checks on LargeObject
Comment by psoo on 2009-07-10: It seems there's a consensus in reworking this stuff based on TOAST, maybe this patch should be "returned with feedback"?
Comment by kaigai on 2009-07-10: We have a matter with TOAST approach commented on the message. Is there any good idea?
Comment by eggyknap on 2009-07-16: Author agrees that rework is needed, and the patch shouldn't be reviewed at this time.
Returned with Feedback KaiGai Kohei Joshua Tolley 2009-07-16
Patch by aglio on 2009-06-08: Initial version
Review by simon on 2009-07-14: Patch design needs further thought. Patch needs further work to follow PostgreSQL project coding practices. Not, IMHO, ready for commit at this commitfest, though likely to be so at later commitfests in this release. Detailed review submitted to hackers.
Returned with Feedback Kedar Potdar Simon Riggs 2009-07-18
Writeable CTEs
Review by jcasanov on 2009-07-18: Initial review. it has problems with triggers, default values...
Comment by rhaas on 2009-07-19: This should probably be marked Returned With Feedback.
Comment by jcasanov on 2009-07-19: Tom recommended doing this in 2 steps, 1 patch refactoring code and a 2nd with the new feature
Returned with Feedback David Fetter, Marko Tiikkaja Jaime Casanova 2009-07-19
Have ParseConfigFile report all parsing errors
Comment by meskes on 2009-07-10: Feedback given by Tom should be incorporated.
Comment by eggyknap on 2009-07-16: Status changed to "waiting on author" after offline discussion with Selena.
Comment by rhaas on 2009-07-20: As this was reviewed by Tom 5 days before starting of CommitFest and has not been updated for 11 days, I am moving it to returned with feedback.
Returned with Feedback Selena Deckelmann Nobody 2009-07-20
join removal
Review by rhaas on 2009-07-19: Greg thinks this is pretty good, but can we do more? Also lists some concerns.
Comment by rhaas on 2009-07-19: My responses to Greg's concerns.
Comment by rhaas on 2009-07-21: Tom Lane's review.
Returned with Feedback Robert Haas Nathan Boley, Gregory Stark 2009-07-21
Security Enhanced PostgreSQL
Comment by rhaas on 2009-07-19: Dave Fetter wonders if it's time to give up on this patch set.
Comment by kaigai on 2009-07-20: Peter Eisentraut suggested to describe the specifications of SE-PgSQL, and KaiGai agreed with the suggestion.
It will make clear what is the fundamental principle of SE-PgSQL to be implemented and makes clear what implementation is better.
It is necessary to submit the specification for several days.
Comment by rhaas on 2009-07-23: Submitting a patch is premature at this point - we first need a spec.
Returned with Feedback KaiGai Kohei Robert Haas 2009-07-23
Non-blocking communication between a frontend and a backend (pqcomm)
Patch by MasaoFujii on 2009-07-22: Updated patch to reflect the comments by Martin.
Comment by tgl on 2009-07-24: Not real happy with this one ...
Comment by rhaas on 2009-07-25: marking returned with feedback
Returned with Feedback Fujii Masao Martin Pihlak 2009-07-25
Set PD_ALL_VISIBLE flag in HOT pruning
Review by alexhunsaker on 2009-07-15: Review, a few questions for the author plus last I heard Heikki was going to review and decide if we really wanted this...
Comment by rhaas on 2009-07-20: Ping.
Comment by rhaas on 2009-07-25: Patch not updated for 10 days, moving to "Returned with Feedback".
Returned with Feedback Pavan Deolasee Alex Hunsaker 2009-07-25
\dL for languages
Patch by rhaas on 2009-07-18: New version.
Review by rhaas on 2009-07-19: Peter's latest review
Comment by rhaas on 2009-07-22: Need updated patch soon.
Returned with Feedback Fernando Ike Peter Eisentraut 2009-07-28
WIP: TODO Item 'Add prompt escape to display the client and server versions'
Patch by guedes on 2009-05-07: Initial version
Review by petere on 2009-07-17: review and questions about usefulness
Comment by rhaas on 2009-07-28: New patched promised ASAP on 7/21.
Returned with Feedback Dickson S. Guedes Peter Eisentraut 2009-07-29
better support for win64 via intptr_t
Patch by Tsutomu Yamada on 2009-06-26: Initial version
Review by rhaas on 2009-07-24: Peter wonders whether this patch does anything.
Returned with Feedback Tsutomu Yamada Peter Eisentraut 2009-07-30
hstore enhancements
Review by theory on 2009-07-16: I've reviewed the patch and, a few documentation issues notwithstanding, I believe that it's ready for committer review.

Comment by tgl on 2009-07-21: Got some beefs associated with upgrade scenarios...
Comment by rhaas on 2009-08-02: Moving to "Returned with Feedback".
Returned with Feedback Andrew Gierth David Wheeler 2009-08-02
Merge append
Review by tgl on 2009-07-26: Quick review of planner parts of patch
Comment by rhaas on 2009-08-04: Author says enough feedback has been provided.
Comment by rhaas on 2009-08-04: Abhijit Menon-Sen never reviewed this, changing reviewer's name to Tom Lane, who did.
Returned with Feedback Greg Stark Tom Lane 2009-08-04
Comment by eggyknap on 2009-07-25: Suggested docs changes
Patch by PJMODOS on 2009-07-26: Applied suggested doc changes
Review by tgl on 2009-08-04: IMHO this needs significant redesign.
Returned with Feedback Petr Jelinek, Stephen Frost, Josh Berkus Joshua Tolley 2009-08-07
Indexam API changes
Patch by heikki on 2009-07-13: Initial version.
Comment by rhaas on 2009-07-21: Ping.
Comment by rhaas on 2009-07-21: I've been told Heikki is on vacation.
Returned with Feedback Heikki Linnakangas Stephen Frost 2009-08-07
Index-only quals
Patch by heikki on 2009-07-14: Initial version.
Comment by heikki on 2009-07-14: More description of the patch. Note that this depends on the "indexam API changes" patch.
Returned with Feedback Heikki Linnakangas Nobody 2009-08-07
Determine client_encoding from client locale
Patch by heikki on 2009-07-12: Initial version.
Review by jcasanov on 2009-07-23: It doesn't compile in windows and other problems...
Patch by jcasanov on 2009-07-25: Fixed the dependency and compile problem... other comments...
Returned with Feedback Heikki Linnakangas Jaime Casanova 2009-08-07
Parser's hook based on FuncCall
Review by rhaas on 2009-07-29: I'm on the fence about this one; needs further input from others.
Comment by jdavis on 2009-08-08: Use cases described by author
Comment by jdavis on 2009-08-08: Probably requires some more time to get enough input.
Returned with Feedback Pavel Stehule Robert Haas, Jeff Davis 2009-08-09
Named and mixed notation for PL
Patch by psoo on 2009-08-05: Updated documentation
Comment by tgl on 2009-08-06: Working on this one ...
Review by tgl on 2009-08-09: Several significant issues need to be addressed.
Returned with Feedback Pavel Stehule Bernd Helmle 2009-08-15
ECPG dynamic cursor, SQLDA support
Patch by zboszor on 2009-06-24: Initial version.
Comment by rhaas on 2009-08-05: Michael Meskes just got back, will review as soon as he finds the time.
Comment by rhaas on 2009-08-15: waiting on author
Returned with Feedback Zoltan Boszormenyi Michael Meskes 2009-08-15