Log In - Home Page

CommitFest 2009-07 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Status Summary. Committed: 37, Returned with Feedback: 24, Rejected: 5. Total: 66.

Pending Patches

No patches.

Committed Patches

Patch Name Status Author Reviewers Date Closed
\d shows child tables that inherit from the specified parent
Patch by daamien on 2009-02-25: Initial version
Comment by rhaas on 2009-02-26: several people (Tom, Greg Sabino Mullane, myself) have wondered whether we really want this
Committed Damien Clochard Peter Eisentraut 2009-07-03
SQL State in log_line_prefix
Patch by gsmet on 2009-05-10: Initial version
Committed Guillaume Smet Peter Eisentraut 2009-07-03
Shows method of index in \di
Patch by kheechin on 2009-05-08: Initial version
Committed Khee Chin Peter Eisentraut 2009-07-06
Add C++ support for backend and calls into C functions
Patch by harriman on 2008-12-05: Initial version
Comment by petere on 2009-07-16: Patch 1 was accepted, patches 2-4 rejected, possibly pending more convincing use cases.
Committed Kurt Harriman Peter Eisentraut 2009-07-16
pg_standby link dependencies
Patch by masaofujii on 2009-06-25: Initial version
Committed Fujii Masao Simon Riggs, Heikki Linnakangas 2009-07-16
Make planning via GEQO repeatable
Patch by andresfreund on 2009-07-14: Initial version
Committed Andres Freund Tom Lane 2009-07-16
DROP COLUMN/CONSTRAINT IF EXISTS support
Patch by andresfreund on 2009-05-07: Initial version
Comment by beinstein on 2009-07-02: thinks this could be a very useful feature
Review by psoo on 2009-07-09: Reviewed and slightly modified patch version
Committed Andres Freund Bernd Helmle 2009-07-19
TOAST MAIN out-of-line reluctantly
Patch by kgrittn on 2009-06-11: Initial version
Patch by kgrittn on 2009-06-15: Version 2 minor refactoring to avoid duplicated code
Committed Kevin Grittner Tom Lane 2009-07-21
Avoid manual shift-and-test logic in AllocSetFreeIndex
Review by tgl on 2009-07-20: Actually this doesn't look like it's such a win after all ...
Comment by tgl on 2009-07-21: Current plan is to use something based on AllocSetFreeIndex_lts as shown here
Patch by tgl on 2009-07-21: Version as committed
Committed Jeremy Kerr Dan Colish 2009-07-21
replace plpgsql_dstring by StringInfo
Review by jconway on 2009-07-20: Applies cleanly (small offset)
Passes regression tests
Looks sensible and correct
Comment by tgl on 2009-07-21: Passes an eyeball check ... it's about time we did this.
Comment by jconway on 2009-07-21: committed
Committed Pavel Stehule Joe Conway 2009-07-21
Make pg_restore --clean to delete existing large objects
Patch by itagaki on 2009-05-18: Initial version
Review by jcasanov on 2009-07-18: applies, compiles and does its intended job... looks good to me...
Comment by tgl on 2009-07-21: I'll take this one next...
Committed Itagaki Takahiro Jaime Casanova 2009-07-21
pg_listener attribute number #defines
Patch by rhaas on 2009-06-24: Initial version
Committed Robert Haas Peter Eisentraut 2009-07-21
do_tup_output_datum v2
Patch by rhaas on 2009-06-16: Initial version
Comment by rhaas on 2009-07-02: this is a minor performance improvement for EXPLAIN and SHOW ALL regardless of the rest of the patches in this series, but the real benefit is that it makes it possible for EXPLAIN (FORMAT XML) to return type xml successfully even when --with-libxml is not used
Committed Robert Haas Tom Lane 2009-07-22
pg_dump Add dumping of comments on columns of composite types
Patch by jcasanov on 2009-07-14: Almost the same patch updated to CVS
Review by direvus on 2009-07-22: Looks good, v3 with minor consistency tweaks.
Comment by tgl on 2009-07-23: Taking this one ...
Committed Taro Minowa (Higepon) Brendan Jurd 2009-07-23
SIGPIPE masking in local socket connections
Patch by jk- on 2009-06-30: Initial version
Comment by rhaas on 2009-07-22: Let's get a move on.
Patch by tgl on 2009-07-24: Patch v4, in response to comments
Committed Jeremy Kerr Tom Lane 2009-07-24
COPY WITH CSV FORCE QUOTE *
Patch by itagaki on 2009-07-16: Remove "FORCE NOT NULL" stuff.
Review by aglio on 2009-07-20: Build, regression, feature review. Now needs code review.
Comment by rhaas on 2009-07-22: needs further review; looking for reviewer
Committed Itagaki Takahiro Josh Berkus, Andrew Dunstan 2009-07-24
explain refactoring v4
Patch by rhaas on 2009-06-12: Initial version
Review by andresfreund on 2009-07-18: Patch looks sensible and clean.
Comment by tgl on 2009-07-24: Working on this one...
Committed Robert Haas Andres Freund 2009-07-24
fix "could not reattach to shared memory" on Windows
Patch by tsutomu@sraoss on 2009-07-15: revised, add error handling
Comment by rhaas on 2009-07-16: We have a report that this does in fact work.
Comment by rhaas on 2009-07-22: Magnus wants testers.
Committed Tsutomu Yamada Magnus Hagander 2009-07-24
generic explain options v3
Patch by rhaas on 2009-07-21: Updated based on suggestions from Tom Lane and Andres Freund.
Comment by rhaas on 2009-07-22: Thoughts on additional refactoring requested by Tom.
Patch by rhaas on 2009-07-24: New version, with questions.
Committed Robert Haas Andres Freund 2009-07-26
Fix memory leak in win32 security functions
Patch by mha on 2009-06-24: Initial version
Comment by rhaas on 2009-07-02: If this has been reviewed on -hackers, there should be a link here to the review. If not, that should probably be happen before this is marked ready for committer.
Comment by mha on 2009-07-02: The review is in the thread...
Committed Magnus Hagander Andrew Chernow 2009-07-27
Polygons
Patch by teodor on 2009-07-10: Initial version.
Review by jwilliams on 2009-07-17: Reviewed patch, seems to perform as promised.
Comment by tgl on 2009-07-21: Looks okay to me too.
Committed Teodor Sigaev, Oleg Bartunov Josh Williams 2009-07-28
Deferrable unique constraints
Patch by deanr on 2009-07-22: Updated version (triggers in new source file, minor code tidy per comments)
Review by jdavis on 2009-07-24: Updated patch addresses open issues.
Comment by tgl on 2009-07-27: Taking this one ...
Committed Dean Rasheed Jeff Davis 2009-07-29
Provide support for multiplexing SIGUSR1 signal
Patch by MasaoFujii on 2009-07-17: Fixed two problems which were pointed out.
Comment by tgl on 2009-07-26: Not happy with the proposed solutions to some issues...
Patch by MasaoFujii on 2009-07-29: Revised the patch according to the suggestion.
Committed Fujii Masao Jaime Casanova 2009-07-31
report key values in duplicate-key errors
Comment by guedes on 2009-07-17: suggesting include regression test for this
Patch by itagaki on 2009-07-20: Adjust regression tests.
Comment by tgl on 2009-08-01: Working on this one ...
Committed Itagaki Takahiro Dickson S. Guedes 2009-08-01
ALTER TABLE ... ALTER COLUMN ... SET DISTINCT
Comment by dim on 2009-07-18: bitrot was whitespace related but confusing, fixed locally, will resume reviewing next week
Comment by rhaas on 2009-07-29: Ping.
Patch by dim on 2009-07-31: Patch merged to head and revised to followup on comments.
Regression test issues (opr_sanity ordering issue)
Work as documented wrt to ANALYZE, pg_statistic, pg_dump
Committed Robert Haas Dimitri Fontaine 2009-08-02
multi-threaded pgbench
Review by gsmith on 2009-07-29: Josh Williams review finds a buffer overrun error in the base pgbench code the new feature exposes; small patch to correct that submitted.
Comment by gsmith on 2009-07-29: Performance and bug fixes all look good
Comment by rhaas on 2009-08-02: Tom thinks maybe Tatsuo Ishii should commit this one.
Committed Itagaki Takahiro Greg Smith, Josh Williams 2009-08-03
has_sequence_privilege() function
Review by jconway on 2009-08-01: Generally OK. Not happy with verify_sequence_oid() function -- more-or-less duplicates already existing function get_rel_relkind(). Will post new patch to hackers.
Review by jconway on 2009-08-01: sent to HACKERS -- will commit revise patch if no objections are heard.
Patch by jconway on 2009-08-03: final patch posted to HACKERS -- committed
Committed Abhijit Menon-Sen Joe Conway 2009-08-03
new bytea hex output format
Comment by tgl on 2009-08-03: Some other stuff we ought to fix using this...
Comment by tgl on 2009-08-03: I'm working on making this committable, but it's not there yet ...
Comment by tgl on 2009-08-04: Committed, but we'll need to consider later whether to keep the default output format as HEX.
Committed Peter Eisentraut Bernd Helmle 2009-08-04
async notifications for dblink
Patch by jconway on 2009-08-03: new patch based on Tom's excellent (as usual) suggestion.
Patch by jconway on 2009-08-04: Modified to use OUT params instead of a custom rowtype per Alvaro's suggestion.
Patch by jconway on 2009-08-04: Modified to make regression test more useful...last call for comments
Committed Marcus Kempe Joe Conway 2009-08-05
Improvements for dict_xsyn extended synonym dictionary
Review by andresfreund on 2009-07-29: Except some minor whitespace issues the patch looks ready for me.
Patch by rhaas on 2009-07-29: Fixed whitespace errors in Sergey's latest version.
Patch by tgl on 2009-07-30: Some minor additional cleanup; looks ready to me, but Teodor should check it.
Committed Sergey Karpov Andres Freund 2009-08-05
return query and dropped columns
Patch by okbobcz on 2009-08-04: actualised with respect to tgl comment
Review by jcasanov on 2009-08-06: Seems good...
Comment by tgl on 2009-08-06: Taking this again ...
Committed Pavel Stehule Jaime Casanova 2009-08-06
Revise parallel pg_restore's scheduling heuristic
Comment by rhaas on 2009-08-02: Seems there is enough evidence to commit this even while followup research is continuing.
Comment by tgl on 2009-08-05: I'm discouraged by the complete lack of evidence of benefit. Maybe we should just abandon this.
Comment by rhaas on 2009-08-05: Should be discussed on -hackers, but I share your concern.
Committed Tom Lane Kevin Grittner 2009-08-07
ECPG support for string pseudo-type v2
Patch by Zboszor on 2009-07-04: Initial version.
Comment by meskes on 2009-07-10: This datatype should only be available in Informix compatibility mode.
Comment by rhaas on 2009-08-05: Michael Meskes just got back, will review as soon as he finds the time.
Committed Zoltan Boszormenyi Michael Meskes 2009-08-07
Support for EEEE in to_char()
Patch by direvus on 2009-08-09: Version 6 implements sci notation for numeric data type and aligns the output.
Patch by direvus on 2009-08-10: Version 7 avoids use of fmgr signature for numeric_out_sci().
Comment by tgl on 2009-08-10: Taking this one ...
Committed Pavel Stehule, Brendan Jurd David Fetter, Euler Taveira de Oliveira 2009-08-10
machine-readable explain output v4
Patch by rhaas on 2009-07-29: Rebased over extensive modifications to explain options patch.
Review by andresfreund on 2009-08-02: Some smaller things need resolving and then there is the XML type issue...
Patch by rhaas on 2009-08-06: v5.
Committed Robert Haas Andres Freund 2009-08-10
Prefix support for synonym dictionary
Review by jdavis on 2009-08-02: Patch looks good. A few doc suggestions.
Comment by rhaas on 2009-08-05: Ping.
Patch by teodor on 2009-08-06: New version per Alvaro's notices.
Committed Oleg Bartunov, Teodor Sigaev Jeff Davis 2009-08-14
Filtering dictionary support and unaccent dictionary
Patch by teodor on 2009-08-14: New patch fixes doc issue with high-bit characters
Patch by rhaas on 2009-08-15: Final version.
Review by rhaas on 2009-08-15: request from Alvaro for $PostgreSQL$ tags
Committed Oleg Bartunov, Teodor Sigaev Jaime Casanova 2009-08-19

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
add_path optimization
Patch by rhaas on 2009-02-01: Initial version
Comment by tgl on 2009-02-28: it doesn't seem to work
Returned with Feedback Robert Haas Tom Lane 2009-02-28
unalias of ACL_UPDATE_FOR_SELECT
Patch by kaigai on 2009-04-17: Initial version
Comment by kaigai on 2009-04-22: The matter is avoidable in another way.
Returned with Feedback KaiGai Kohei Nobody 2009-04-22
psql display sequence owner
Patch by jwilliams on 2008-12-07: Initial version
Comment by jwilliams on 2009-07-07: Please defer, patch is being redesigned.
Returned with Feedback Josh Williams Peter Eisentraut 2009-07-07
Synch Rep
Patch by MasaoFujii on 2009-07-14: Updated version (adjust to HEAD and fix some bugs)
Patch by MasaoFujii on 2009-07-15: Updated version (Introduce a new function XLogShutdownFlush() and revert the XLogFlush() api to the original)
Review by heikki on 2009-07-15: Summary of must-fix issues raised this far
Returned with Feedback Fujii Masao Peter Eisentraut, Heikki Linnakangas 2009-07-15
Security checks on LargeObject
Comment by psoo on 2009-07-10: It seems there's a consensus in reworking this stuff based on TOAST, maybe this patch should be "returned with feedback"?
Comment by kaigai on 2009-07-10: We have a matter with TOAST approach commented on the message. Is there any good idea?
Comment by eggyknap on 2009-07-16: Author agrees that rework is needed, and the patch shouldn't be reviewed at this time.
Returned with Feedback KaiGai Kohei Joshua Tolley 2009-07-16
Auto-Partitioning
Patch by aglio on 2009-06-08: Initial version
Review by simon on 2009-07-14: Patch design needs further thought. Patch needs further work to follow PostgreSQL project coding practices. Not, IMHO, ready for commit at this commitfest, though likely to be so at later commitfests in this release. Detailed review submitted to hackers.
Returned with Feedback Kedar Potdar Simon Riggs 2009-07-18
Writeable CTEs
Review by jcasanov on 2009-07-18: Initial review. it has problems with triggers, default values...
Comment by rhaas on 2009-07-19: This should probably be marked Returned With Feedback.
Comment by jcasanov on 2009-07-19: Tom recommended doing this in 2 steps, 1 patch refactoring code and a 2nd with the new feature
Returned with Feedback David Fetter, Marko Tiikkaja Jaime Casanova 2009-07-19
Have ParseConfigFile report all parsing errors
Comment by meskes on 2009-07-10: Feedback given by Tom should be incorporated.
Comment by eggyknap on 2009-07-16: Status changed to "waiting on author" after offline discussion with Selena.
Comment by rhaas on 2009-07-20: As this was reviewed by Tom 5 days before starting of CommitFest and has not been updated for 11 days, I am moving it to returned with feedback.
Returned with Feedback Selena Deckelmann Nobody 2009-07-20
join removal
Review by rhaas on 2009-07-19: Greg thinks this is pretty good, but can we do more? Also lists some concerns.
Comment by rhaas on 2009-07-19: My responses to Greg's concerns.
Comment by rhaas on 2009-07-21: Tom Lane's review.
Returned with Feedback Robert Haas Nathan Boley, Gregory Stark 2009-07-21
Security Enhanced PostgreSQL
Comment by rhaas on 2009-07-19: Dave Fetter wonders if it's time to give up on this patch set.
Comment by kaigai on 2009-07-20: Peter Eisentraut suggested to describe the specifications of SE-PgSQL, and KaiGai agreed with the suggestion.
It will make clear what is the fundamental principle of SE-PgSQL to be implemented and makes clear what implementation is better.
It is necessary to submit the specification for several days.
Comment by rhaas on 2009-07-23: Submitting a patch is premature at this point - we first need a spec.
Returned with Feedback KaiGai Kohei Robert Haas 2009-07-23
Non-blocking communication between a frontend and a backend (pqcomm)
Patch by MasaoFujii on 2009-07-22: Updated patch to reflect the comments by Martin.
Comment by tgl on 2009-07-24: Not real happy with this one ...
Comment by rhaas on 2009-07-25: marking returned with feedback
Returned with Feedback Fujii Masao Martin Pihlak 2009-07-25
Set PD_ALL_VISIBLE flag in HOT pruning
Review by alexhunsaker on 2009-07-15: Review, a few questions for the author plus last I heard Heikki was going to review and decide if we really wanted this...
Comment by rhaas on 2009-07-20: Ping.
Comment by rhaas on 2009-07-25: Patch not updated for 10 days, moving to "Returned with Feedback".
Returned with Feedback Pavan Deolasee Alex Hunsaker 2009-07-25
\dL for languages
Patch by rhaas on 2009-07-18: New version.
Review by rhaas on 2009-07-19: Peter's latest review
Comment by rhaas on 2009-07-22: Need updated patch soon.
Returned with Feedback Fernando Ike Peter Eisentraut 2009-07-28
WIP: TODO Item 'Add prompt escape to display the client and server versions'
Patch by guedes on 2009-05-07: Initial version
Review by petere on 2009-07-17: review and questions about usefulness
Comment by rhaas on 2009-07-28: New patched promised ASAP on 7/21.
Returned with Feedback Dickson S. Guedes Peter Eisentraut 2009-07-29
better support for win64 via intptr_t
Patch by Tsutomu Yamada on 2009-06-26: Initial version
Review by rhaas on 2009-07-24: Peter wonders whether this patch does anything.
Returned with Feedback Tsutomu Yamada Peter Eisentraut 2009-07-30
hstore enhancements
Review by theory on 2009-07-16: I've reviewed the patch and, a few documentation issues notwithstanding, I believe that it's ready for committer review.

--Theory
Comment by tgl on 2009-07-21: Got some beefs associated with upgrade scenarios...
Comment by rhaas on 2009-08-02: Moving to "Returned with Feedback".
Returned with Feedback Andrew Gierth David Wheeler 2009-08-02
Merge append
Review by tgl on 2009-07-26: Quick review of planner parts of patch
Comment by rhaas on 2009-08-04: Author says enough feedback has been provided.
Comment by rhaas on 2009-08-04: Abhijit Menon-Sen never reviewed this, changing reviewer's name to Tom Lane, who did.
Returned with Feedback Greg Stark Tom Lane 2009-08-04
DefaultACLs
Comment by eggyknap on 2009-07-25: Suggested docs changes
Patch by PJMODOS on 2009-07-26: Applied suggested doc changes
Review by tgl on 2009-08-04: IMHO this needs significant redesign.
Returned with Feedback Petr Jelinek, Stephen Frost, Josh Berkus Joshua Tolley 2009-08-07
Indexam API changes
Patch by heikki on 2009-07-13: Initial version.
Comment by rhaas on 2009-07-21: Ping.
Comment by rhaas on 2009-07-21: I've been told Heikki is on vacation.
Returned with Feedback Heikki Linnakangas Stephen Frost 2009-08-07
Index-only quals
Patch by heikki on 2009-07-14: Initial version.
Comment by heikki on 2009-07-14: More description of the patch. Note that this depends on the "indexam API changes" patch.
Returned with Feedback Heikki Linnakangas Nobody 2009-08-07
Determine client_encoding from client locale
Patch by heikki on 2009-07-12: Initial version.
Review by jcasanov on 2009-07-23: It doesn't compile in windows and other problems...
Patch by jcasanov on 2009-07-25: Fixed the dependency and compile problem... other comments...
Returned with Feedback Heikki Linnakangas Jaime Casanova 2009-08-07
Parser's hook based on FuncCall
Review by rhaas on 2009-07-29: I'm on the fence about this one; needs further input from others.
Comment by jdavis on 2009-08-08: Use cases described by author
Comment by jdavis on 2009-08-08: Probably requires some more time to get enough input.
Returned with Feedback Pavel Stehule Robert Haas, Jeff Davis 2009-08-09
Named and mixed notation for PL
Patch by psoo on 2009-08-05: Updated documentation
Comment by tgl on 2009-08-06: Working on this one ...
Review by tgl on 2009-08-09: Several significant issues need to be addressed.
Returned with Feedback Pavel Stehule Bernd Helmle 2009-08-15
ECPG dynamic cursor, SQLDA support
Patch by zboszor on 2009-06-24: Initial version.
Comment by rhaas on 2009-08-05: Michael Meskes just got back, will review as soon as he finds the time.
Comment by rhaas on 2009-08-15: waiting on author
Returned with Feedback Zoltan Boszormenyi Michael Meskes 2009-08-15

Rejected Patches

Patch Name Status Author Reviewers Date Closed
remove {join,from}_collapse_limit, add enable_join_ordering
Patch by rhaas on 2009-07-12: Initial version.
Review by andresfreund on 2009-07-16: Patch is technically fine, some doubts remain about possible regressions in plantime
Comment by rhaas on 2009-07-19: Testing by Tom and Andres has revealed that this change is presently not workable.
Rejected Robert Haas Tom Lane, Andres Freund 2009-07-19
Sampling Profiler
Patch by itagaki on 2009-07-14: adjust to HEAD.
Comment by dim on 2009-07-18: dim=# create table series(i integer);
dim=# insert into series select generate_series(1, 10000000);
WARNING: condition stack overflow: 11
ERROR: canceling statement due to user request
Comment by dim on 2009-07-21: Tom says: "For the record, I think this patch is a waste of manpower and we should rely on dtrace/systemtap."
Rejected Itagaki Takahiro Dimitri Fontaine 2009-07-21
user mapping extension to pg_ident.conf
Comment by larskanis on 2009-07-07: More description of the use followed here.
Comment by rhaas on 2009-07-22: Although this has not been assigned an official reviewer, it's been discussed extensively by Tom, Magnus (as linked here), and also commented on by Stephen Frost. It looks like it is a no-go in its present form, but maybe it can be reworked to be acceptable.
Comment by rhaas on 2009-07-24: Marking this rejected.
Rejected Lars Kanis Nobody 2009-07-24
dependencies for generated header files
Patch by rhaas on 2009-06-28: Initial version
Comment by rhaas on 2009-07-29: Peter wonders if src/backend/common.mk is better than src/Makefile.global.in, and will this conflict too much with "autogenerating headers & bki stuff".
Rejected Robert Haas Peter Eisentraut 2009-08-15
autogenerating headers & bki stuff
Comment by rhaas on 2009-07-02: if this last patch is applied, the previous two become moot
Patch by rhaas on 2009-07-21: updated to reflect commit of "pg_listener attribute number #defines"
Patch by rhaas on 2009-08-02: Stripped out the anum.h stuff.
Rejected Robert Haas Peter Eisentraut 2009-08-15