Log In - Home Page

CommitFest 2013-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 20, Returned with Feedback: 27, Rejected: 2. Total: 49.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
PL/PgSQL strict_mode
Patch by johto on 2013-09-14: Initial version.
Comment by johto on 2013-09-15: Concerns and ideas.
Comment by johto on 2013-09-15: I don't think spending reviewer time on this patch at this point would be wise. Returning with feedback.
Returned with Feedback Marko Tiikkaja Nobody 2013-09-15
Bitmap indexes
Patch by ams on 2013-09-15: Initial version.
Review by ams on 2013-09-26: Various improvements suggested by Álvaro.
Returned with Feedback Abhijit Menon-Sen Jaime Casanova, Jeff Janes, Álvaro Herrera 2013-09-26
hint bit i/o mitigation (from 2013-01)
Comment by ringerc on 2013-01-21: Bumped to next commitfest (Merlin, Robert, Craig)
Comment by aglio on 2013-06-18: Bumped to CF2 at Atri's Request.
Comment by maiku41 on 2013-09-27: Updated to Returned per Atri.
Returned with Feedback Atri Sharma Amit Kapila, Hari Babu 2013-09-27
Truncate trailing nulls from heap rows to reduce the size of the null bitmap (from 2012-11)
Comment by maiku41 on 2013-07-16: Moved to CF 2013-09
Comment by petere on 2013-08-22: needs rebase
Comment by maiku41 on 2013-09-27: Returned w/ Feedback based on email with author.
Returned with Feedback Jameison Martin Amit Kapila, Greg Stark 2013-09-27
Custom Plan node
Comment by maiku41 on 2013-09-19: Changed to Waiting on Author based on active discussion in thread.
Review by rhaas on 2013-10-03: review of new version
Comment by kaigai on 2013-10-05: We primarily focus on CustomScan nodes, rather than general purpose.
Returned with Feedback KaiGai Kohei Robert Haas 2013-10-05
Minmax indexes
Patch by alvherre on 2013-09-17: apply on top of previous, fixes bugs reported by Thom, Peter, Jaime
Patch by alvherre on 2013-09-25: updated v5.
Comment by rhaas on 2013-10-09: author agrees with marking this returned with feedback
Returned with Feedback Álvaro Herrera Abhijit Menon-Sen, Amit Kapila 2013-10-09
pg_system_identifier()
Patch by glaucous on 2013-08-22: Initial version.
Comment by rhaas on 2013-10-09: we seem to have a consensus on a design for this, but it's not what the patch implements, so marking Returned with Feedback
Returned with Feedback Vik Fearing Satoshi Nagayasu 2013-10-09
Assertions in PL/PgSQL
Patch by johto on 2013-09-15: Add missing errcode.
Comment by amitdkhan on 2013-09-20: Brought back earlier point about extending RAISE syntax
Comment by johto on 2013-09-24: Looks like we have an agreement on the syntax.
Returned with Feedback Marko Tiikkaja Amit Khandekar 2013-10-09
Effectiveness of enable_material = off
Patch by jjanes on 2013-09-03: Initial version.
Review by rhodiumtoad on 2013-09-15: not convinced this is an improvement.
Returned with Feedback Jeff Janes Andrew Gierth 2013-10-11
MAP_HUGETLB for shared memory
Patch by richard.poole on 2013-09-13: Initial version.
Review by heikki on 2013-09-16: I don't understand the pagesize logic.
Patch by ams on 2013-10-24: Revised version of the patch
Returned with Feedback Christian Kruse, Richard Poole, Abhijit Menon-Sen Heikki Linnakangas, Andres Freund 2013-10-11
New statistics for WAL buffer dirty writes
Patch by snaga on 2013-09-10: Fix duplicated oids.
Patch by snaga on 2013-09-11: Fix compiler warning.
Review by masaofujii on 2013-09-17: Needs to change some background processes so that they can increase the counter.
Returned with Feedback Satoshi Nagayasu Simon Riggs, Fujii Masao 2013-10-11
pg_dump/restore encoding fixes
Patch by heikki on 2013-08-27: Initial version.
Review by amitdkhan on 2013-09-25: Reviewed the pg_dump part.
Review by amitdkhan on 2013-10-01: review of pg_restore changes
Returned with Feedback Heikki Linnakangas Amit Khandekar 2013-10-11
PL/PgSQL RAISE CONTEXT
Patch by johto on 2013-09-15: Fix regression tests.
Patch by johto on 2013-09-15: Fix regression tests, take two.
Review by jeevan.chalke on 2013-09-17: Need to fix few other regression tests. Code looks good to me.
Returned with Feedback Marko Tiikkaja, Pavel Stehule Jeevan Chalke 2013-10-11
Detail message for "process x still waiting for lock" log lines
Patch by tarvi on 2013-08-21: Initial version.
Comment by tarvi on 2013-08-26: Fixed compiler warning.
Comment by jjanes on 2013-09-15: Marked "waiting on author" based on Alvaro's comments.
Returned with Feedback Tarvi Pillessaar Nobody 2013-10-11
backup.sgml-cmd-v003.patch
Patch by ilivcmd on 2013-08-01: Initial version.
Comment by maiku41 on 2013-09-18: Reviewed by Karl O. Pinc
Review by rhaas on 2013-09-27: too many unrelated changes in one patch; some editing needed
Returned with Feedback Ivan Lezhnjov IV Karl O. Pinc 2013-10-11
Improve setup for documentation building with FOP
Patch by petere on 2013-09-11: Initial version.
Comment by alvherre on 2013-09-16: some observations on the new rendering
Returned with Feedback Peter Eisentraut Álvaro Herrera 2013-10-11
fast gin cache performance improvement
Patch by ilink on 2013-06-23: Initial version.
Review by efujita on 2013-09-27: Initial review.
Review by efujita on 2013-09-27: Additional comment.
Returned with Feedback Ian Link Etsuro Fujita 2013-10-13
Add pg_hba LDAP option for LDAP referrals
Comment by maiku41 on 2013-10-09: Changed to waiting for review per author's request.
Comment by petere on 2013-10-11: Please answer the existing reviews first.
Comment by maiku41 on 2013-10-16: Returned
Returned with Feedback James Sewell Peter Eisentraut 2013-10-16
Triggers on Foreign Tables
Patch by rdunklau on 2013-09-11: Initial version.
Comment by kaigai on 2013-10-07: Suggestion to implement row-level triggers on foreign table
Comment by maiku41 on 2013-10-16: Returned - End of CF
Returned with Feedback Ronan Dunklau Bernd Helmle, KaiGai Kohei 2013-10-16
Compression of full-page-writes
Patch by masaofujii on 2013-09-11: Updated version of the patch.
Comment by dim on 2013-10-10: Code review, some amount of details must get fixed.
Comment by maiku41 on 2013-10-16: Returned - End of CF
Returned with Feedback Fujii Masao Dimitri Fontaine 2013-10-16
fail-back without fresh backup
Review by masaofujii on 2013-10-04: Comments from masaofujii
Patch by masahikosawada on 2013-10-08: v12 Update version of the patch. Based on masaofujii suggestion.
Comment by maiku41 on 2013-10-16: Returned - End of CF
Returned with Feedback Samrat Revagade, Sawada Masahiko Simon Riggs, Fujii Masao 2013-10-16
reserved connections for replication users
Review by amitkapila on 2013-10-13: few minor issues left.
Comment by maiku41 on 2013-10-16: Returned - End of CF
Comment by maiku41 on 2013-10-16: Ongoing design questions.
Returned with Feedback Stefan Radomski Marko Tiikkaja, Amit Kapila 2013-10-16
Auto-tuning checkpoint_segments
Patch by heikki on 2013-08-23: New patch version, which does more than the first one.
Comment by maiku41 on 2013-10-16: Comments by Amit 9/1
Comment by maiku41 on 2013-10-16: Returned. End of CF
Returned with Feedback Heikki Linnakangas Peter Eisentraut 2013-10-16
Patch: pg_stat_statements: query, session, and eviction identification
Patch by samthakur74 on 2013-10-10: Please find patch (version8) attached which adds documentation for session_start
and introduced fields and corrects documentation for queryid to be
query_id. session_start remains in the view as agreed.
Review by arnold_s on 2013-10-10: quick usability review (of V7) suggesting a parameter
Review by masaofujii on 2013-10-10: Some review comments
Returned with Feedback Daniel Farina, Sameer Thakur Fujii Masao, Arne Scheffer 2013-10-16
coverage target in extension makefiles
Patch by rdunklau on 2013-07-26: Initial version.
Comment by maiku41 on 2013-10-16: Patch being reconsidered
Comment by maiku41 on 2013-10-16: Returned with Feedback
Returned with Feedback Ronan Dunklau Peter Eisentraut 2013-10-16
Docs: New section for subqueries
Patch by kop on 2013-08-06: Initial version.
Review by glaucous on 2013-10-15: more work needed
Comment by maiku41 on 2013-10-16: Returned - end of CF
Returned with Feedback Karl O. Pinc Vik Fearing 2013-10-16
Patch to compute Max LSN of Data Pages (from 2012-11)
Patch by amitkapila on 2013-09-14: updated patch to resolve windows build issue
Comment by rhaas on 2013-10-09: patch looks technically OK, but do we have enough consensus to move forward?
Review by rhaas on 2013-10-18: still no consensus; and some other review comments and directional thoughts
Returned with Feedback Amit Kapila, Hari Babu Robert Haas 2013-10-18