Log In - Home Page

CommitFest 2013-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Rejected".

Status Summary. Committed: 49, Returned with Feedback: 41, Rejected: 6. Total: 96.

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Process title for autovac worker
Patch by jjanes on 2013-04-06: Initial version.
Comment by jjanes on 2013-04-13: Some security concerns, and pg_stat_activity already provides this info
Rejected Jeff Janes Nobody 2013-04-13
Add regression tests for COLLATE
Patch by robins on 2013-05-23: Remove tests that cant work on all systems (for e.g. UTF8 tests). Used DROP COLLATION IF EXISTS where possible.
Comment by rhaas on 2013-07-03: some post-commit cleanup would be appreciated
Comment by rhaas on 2013-07-03: buildfarm sad; patch reverted
Rejected Robins Tharakan Fabien Coelho 2013-07-03
XidIsInProgress() cache
Patch by simon on 2013-05-11: Initial version.
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on comments.
Comment by aglio on 2013-07-08: This patch entry is a duplicate of TransactionIDIsInProgress(). Deleting the duplicate patch entry to clean things up.
Rejected Simon Riggs Satoshi Nagayasu 2013-07-08
Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Review by jeevan.chalke on 2013-06-26: Patch looks good. Its very simple and straight forward. Has documentation as well. No issue found in testing and code walk-through
Patch by nmisch on 2013-07-07: Latest version
Comment by nmisch on 2013-07-08: Recommend we not add more trivial SPI_* wrappers.
Rejected Mark Wong Jeevan Chalke 2013-07-12
clean up addRangeTableEntryForFunction
Review by rhaas on 2013-07-02: seems pointless
Comment by rhodiumtoad on 2013-07-02: This was obsoleted months ago - why was it even here, and why was it added by a third party? I had no idea it was still in play.
Comment by rhodiumtoad on 2013-07-16: Treat this as "withdrawn by author"
Rejected David Fetter and Andrew Gierth Etsuro Fujita, Robert Haas 2013-07-16
CREATE CAST ... AS EXPLICIT
Comment by aglio on 2013-07-08: Objection on approach, additional SQL keywords.
Comment by calvin on 2013-07-09: Measured impact is +8 bytes (and -4 KB!). Overall footprint of keywords could be reduced, but this is another issue.
Comment by aglio on 2013-07-17: Marking as rejected per offline conversation with Fabien and Tom.
Rejected Fabien Coelho CÚdric Villemain 2013-07-16