Log In - Home Page

CommitFest 2013-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 49, Returned with Feedback: 41, Rejected: 6. Total: 96.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Tablesample implementation
Patch by huangqi on 2012-08-21: Initial version.
Review by umitanuki on 2012-09-18: The patch needs to be updated.
Returned with Feedback Huang Qi Hitoshi Harada 2013-05-22
logical changeset generation v4
Comment by ringerc on 2013-01-21: Bug encountered (see mail); queried, W.A. pending confirmation
Comment by andresfreund on 2013-01-23: Aforementioned bug/usability problem has been fixed in new version (git repo, too big for a repost for a minor change), needs review
Review by ssinger on 2013-01-28: Review from a plugin users point-of-view. Raised a number of issues that need to be addressed
Returned with Feedback Andres Freund Dimitri Fontaine,Steve Singer 2013-06-14
Batch API for After Triggers
Patch by aglio on 2013-06-17: Initial version.
Comment by aglio on 2013-06-18: Withdrawn by Simon per email.
Comment by simon on 2013-07-04: Note this was never actually submitted to CF
Returned with Feedback Simon Riggs Nobody 2013-06-18
dividing privileges for replication role
Comment by ringerc on 2013-01-21: Waiting on author pending revision.
Comment by tomonari katsumata on 2013-01-22: answering the above comments.
Comment by aglio on 2013-06-24: Moving to Returned With Feedback due to author no-show.
Returned with Feedback Tomonari Katsumata Nobody 2013-06-24
minmax indexes
Patch by alvherre on 2013-06-14: Initial version.
Comment by maiku41 on 2013-06-25: Returned with Feedback: No patch attached. Ongoing discussion of proposed feature.
Returned with Feedback Álvaro Herrera Nobody 2013-06-25
MD5 aggregate function
Review by maiku41 on 2013-06-21: Review by David Fetter
Review by dfetter on 2013-06-22: On further testing, the performance decrease went away.
Review by nmisch on 2013-06-26: New aggregates don't belong in core. Instead of optimizing src/backend/libpq/md5.c, what about importing an already-efficient implementation?
Returned with Feedback Dean Rasheed David Fetter 2013-06-27
pgbench --startup
Patch by jjanes on 2013-06-20: coding style fix-up, conflict resolved.
Review by calvin on 2013-06-20: minor points.
Comment by rhaas on 2013-06-27: author will rewrite, but not for this CF
Returned with Feedback Jeff Janes Fabien Coelho, Robert Haas 2013-06-27
Move unused buffers to freelist
Patch by amitkapila on 2013-05-15: This patch is to make buffers available to backends from freelist by moving unused buffers to freelist by bgwriter/checkpointer
Patch by amitkapila on 2013-06-07: Patch modified, so that only bgwriter will put unused buffers to free list.
Detailed steps I have used to get performance data.
Review by rhaas on 2013-06-28: patch needs major revisions, marking returned with feedback
Returned with Feedback Amit Kapila Robert Haas 2013-06-28
ASYNC Privileges proposal
Patch by aglio on 2013-06-17: Initial version.
Comment by aglio on 2013-06-24: Need to address concerns raised by several commentors.
Comment by aglio on 2013-06-28: Needs more thought on the permissions model involved, and performance testing. Not committable as-is.
Returned with Feedback Chris Farmiloe Nobody 2013-06-28
GIN improvements part 1: additional information
Patch by smagen on 2013-06-13: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Comment by maiku41 on 2013-06-28: Possible problems noted on 6/27
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
Index on regexes
Patch by smagen on 2013-06-13: Initial version.
Comment by maiku41 on 2013-06-28: Comments from reviewer.
Comment by heikki on 2013-06-30: This is dependent on the "additional information" patch. I bounced the "additional info" patch, so bouncing this too, until that one gets applied.
Returned with Feedback Alexander Korotkov Heikki Linnakangas 2013-06-30
GIN improvements part 2: fast scan
Patch by smagen on 2013-06-14: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
GIN improvements part 3: ordering in index
Patch by smagen on 2013-06-14: Initial version.
Patch by smagen on 2013-06-17: Refactoring and bug fixes
Returned with Feedback Alexander Korotkov, Oleg Bartunov Heikki Linnakangas 2013-06-30
WIP: Levenshtein-Damerau edit distance
Patch by jconway on 2013-06-25: New version of patch in context diff form
Comment by aglio on 2013-07-03: Feedback from several hackers. Patch is not in committable form, needs changes.
Review by aglio on 2013-07-05: Review by Michael Paquier. Multiple issues with patch. Most importantly, licensing issue with upstream code.
Returned with Feedback Liming Hu Joe Conway 2013-07-03
fixing pg_ctl with relative paths
Patch by schmiddy on 2013-01-24: Initial version.
Review by schmiddy on 2013-06-26: initial review, two minor issues
Patch by schmiddy on 2013-06-26: v2 patch
Returned with Feedback Josh Kupershmidt Hari Babu, Fujii Masao 2013-07-04
Block write statistics WIP
Patch by aglio on 2013-06-17: Initial version.
Comment by snaga on 2013-07-01: Comment and design question.
Returned with Feedback Greg Smith Satoshi Nagayasu 2013-07-05
LDAP bugfix and don't use deprecated API
Patch by laurenz on 2013-02-06: Initial version.
Returned with Feedback Laurenz Albe Magnus Hagander 2013-07-05
Query result history in psql
Review by ilink on 2013-06-25: Patch looks good, but missing a few features/considerations.
Comment by aglio on 2013-06-28: Maciej planning to submit revised patch on 7/1
Patch by maciek_g on 2013-07-02: Revised patch
Returned with Feedback Maciej Gajewski Ian Link 2013-07-07
preserving forensic information when we freeze
Review by andresfreund on 2013-06-24: Nearly ready, some minor adjustments requested.
Comment by rhaas on 2013-07-02: responses to Andres' review comments
Comment by aglio on 2013-07-08: Robert Haas: Will work on this for next CF
Returned with Feedback Robert Haas Andres Freund 2013-07-08
Allows extensions to install header file
Patch by c2main on 2013-06-18: Initial version.
Comment by maiku41 on 2013-06-21: Set to Waiting on Author based on discussion.
Comment by aglio on 2013-07-11: Discussion stalled, no further work on patch. Returning.
Returned with Feedback Cédric Villemain Peter Eisentraut 2013-07-11
"Big" regression test separation
Patch by calvin on 2013-07-11: v5 fixes conflicts introduced by recent commits.
Review by samratr on 2013-07-11: According to author it is POC patch and under discussion
Comment by aglio on 2013-07-11: Marking "returned with feedback" since there's a lot of spec discussion required before commitability.
Returned with Feedback Fabien Coelho Samrat Revagade 2013-07-11
Improvement of checkpoint IO scheduler for stable transaction responses
Patch by mitsu-ko on 2013-07-09: create v2 patch
Patch by mitsu-ko on 2013-07-11: create v3 v4 v5 patches
Review by gsmith on 2013-07-14: Suggestions on checkpoint timing, additional data to monitor, past submission with similar code.
Returned with Feedback Mitsumasa KONDO Heikki Linnakangas, Greg Smith 2013-07-14
Remove PD_ALL_VISIBLE
Patch by jdavis on 2013-06-10: Rebased.
Comment by aglio on 2013-07-01: Moved to Returned with Feedback per Jeff Davis. Will be revisited next CF.
Comment by jdavis on 2013-07-02: My comment was misinterpreted; still looking for some progress here.
Returned with Feedback Jeff Davis Robins Tharakan 2013-07-15
Extension templates
Review by aglio on 2013-07-05: Extensive review by Markus Wanner. Found some issues with commands, pg_depends, and error messages. Needs revision.
Patch by dim on 2013-07-08: Patch v9, more cleaning up, including "Template" model analysis by Markus.
Comment by maiku41 on 2013-07-16: Ongoing discussion at end of CF. Returned with Feedback
Returned with Feedback Dimitri Fontaine Markus Wanner, Hitoshi Harada, Jaime Casanova 2013-07-16
TransactionIdIsInProgress() procno cache
Comment by aglio on 2013-07-10: Setting patch back to "needs review" since it hasn't actually had any performance testing.
Comment by aglio on 2013-07-12: Setting back to "ready for committer" per discussion on -performance.
Comment by ams on 2013-07-13: Can't reproduce performance gains
Returned with Feedback Simon Riggs Satoshi Nagayasu 2013-07-16
Make recovery.conf parameters into GUCs
Patch by gsmith on 2013-07-15: Updated prototype
Comment by maiku41 on 2013-07-16: Still in the works as of end of CF. Returned with Feedback.
Review by gsmith on 2013-07-18: Suggestions for how to handle the trigger file usefully.
Returned with Feedback Fujii Masao, Michael Paquier, edited by Simon Riggs Greg Smith 2013-07-16
pg_filedump 9.3: checksums (and a few other fixes)
Review by snaga on 2013-07-06: Reviewed with additional question.
Comment by maiku41 on 2013-07-16: Printing of flags still under discussion.
Comment by maiku41 on 2013-07-16: This patch doesn't need to be in the CF since it's not part of the community distribution. Marking as Returned with Feedback to close it out nicely.
Returned with Feedback Jeff Davis Satoshi Nagayasu 2013-07-16
Add visibility map information to pg_freespace.
Patch by horiguti on 2013-07-09: 2nd ver for pg_freespace and 1st ver for pgstattuple, without docs.
Review by snaga on 2013-07-16: Reviewed with a few comments.
Comment by maiku41 on 2013-07-16: Still waiting on author's response to review at end of CF. Returned with Feedback.
Returned with Feedback Kyotaro Horiguchi Satoshi Nagayasu 2013-07-16
Remove useless USE_PGXS support in contrib
Review by c2main on 2013-06-19: Ready, Waiting more feedback from community
Comment by aglio on 2013-07-03: Moved to "waiting on author" because this patch is still under spec discussion.
Comment by maiku41 on 2013-07-16: Returned with Feedback
Returned with Feedback Peter Eisentraut Cédric Villemain 2013-07-16
updated emacs configuration
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on reviewer comments.
Comment by maiku41 on 2013-06-28: Still under discussion as of 6/27.
Patch by petere on 2013-07-03: updated patch
Returned with Feedback Peter Eisentraut Dimitri Fontaine 2013-07-16
Reduce maximum error in tuples estimation after vacuum.
Comment by amitkapila on 2013-06-25: Could not reproduce the scenario for which improvement is proposed, more input is required from Author.
Comment by amitkapila on 2013-07-09: some scenario's where proposed algorithm is worse than Head.
Comment by maiku41 on 2013-07-16: Still waiting for author's response to reviewer's comments at end of CF. Returned with Feedback.
Returned with Feedback Kyotaro Horiguchi Amit Kapila 2013-07-16
Add more regression tests for SEQUENCE
Patch by robins on 2013-07-07: Updated as per 3rd July feedback
Comment by calvin on 2013-07-09: Wrong patch.
Patch by robins on 2013-07-15: Attached the correct patch this time.
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add more regression tests for SCHEMA
Patch by robins on 2013-07-07: Updated as per feedback
Comment by calvin on 2013-07-09: Patch format issue?
Patch by robins on 2013-07-15: Attached updated patch. (The last line(-ending?) seems to have been missing).
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add more regression tests for ROLE (USER)
Review by calvin on 2013-05-09: Ok!
Review by rhaas on 2013-07-03: too many unnecessary create/drop cycles
Patch by robins on 2013-07-15: Updated patch after removing most of CREATE ROLE / DROP ROLE changes.
Returned with Feedback Robins Tharakan Fabien Coelho 2013-07-16
Add basic regression tests for DISCARD
Review by fabriziomello on 2013-07-11: Final review of this patch. Ready for commiter.
Review by rhaas on 2013-07-15: Further review comments.
Comment by maiku41 on 2013-07-16: Still open at end of CF. Returned with Feedback.
Returned with Feedback Robins Tharakan Fabrízio de Royes Mello 2013-07-16
Add basic regression tests for SET xxx
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: Needs work.
Comment by maiku41 on 2013-07-16: Needs work at end of CF. Returned with Feedback.
Returned with Feedback Robins Tharakan Szymon Guz 2013-07-16
Pluggable toast compression
Patch by andresfreund on 2013-06-21: Version with lz4 support and various other things
Comment by maiku41 on 2013-07-05: Pending discussion.
Comment by aglio on 2013-07-17: Returned pending legal consultation regarding lz4/snappy. Expected to be reintroduced in CF3.
Returned with Feedback Andres Freund Hitoshi Harada 2013-07-17
Performance Improvement by reducing WAL for Update Operation
Patch by haribabu on 2013-07-02: Rebased patch as per latest PG LZ algorithm.
Patch by haribabu on 2013-07-19: Latest patch
Review by gsmith on 2013-07-22: Performance on "hundred tiny fields" cases are an issue, especially "half nulls" one.
Returned with Feedback Amit Kapila, Hari Babu Greg Smith 2013-07-22
Row-Level Security
Patch by gsmith on 2013-07-19: Updated to fix trivial bit rot. Suggestions on the skills needed to review the feature usefully.
Comment by gsmith on 2013-07-22: Suggested improvement for eliminating getrelid changes.
Patch by ringerc on 2013-10-23: v4 of the patch against 9.4
Returned with Feedback KaiGai Kohei Mike Blackwell, Atri Sharma, Dean Rasheed 2013-07-22
Add more regression tests for DBCommands
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: More review comments.
Returned with Feedback Robins Tharakan Szymon Guz 2013-07-23
Remove unused targets from plan (from 2013-01)
Review by alvherre on 2013-06-25: please add a few comments
Patch by efujita on 2013-07-03: Added some comments and improved the code a little bit.
Review by tgl on 2013-08-02: Should take the cost savings into account while choosing the plan, not just whack the tlist around afterwards...
Returned with Feedback Alexander Korotkov, Etsuro Fujita Hitoshi Harada, Álvaro Herrera 2013-08-02