Log In - Home Page

CommitFest 2013-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Committed".

Status Summary. Committed: 49, Returned with Feedback: 41, Rejected: 6. Total: 96.

Committed Patches

Patch Name Status Author Reviewers Date Closed
Add Makefile dep in bin/scripts for libpgport
Patch by phils on 2013-01-23: Initial version.
Committed Phil Sorber Nobody 2013-02-08
printing boolean domains in sql/xml function
Patch by okbobcz on 2013-02-22: bug fix (maybe for 9.3, if not to 9.4) - fix printing domain' values in SQL/XML function
Committed Pavel Stehule Nobody 2013-03-04
backup_label is critical, not merely informative.
Patch by jjanes on 2013-04-06: Initial version.
Comment by gsmith on 2013-04-26: Is it possible to flag when it's expected but missing in a way that doesn't generate too many false warnings?
Committed Jeff Janes Greg Smith 2013-05-07
Fix escaped connstring handling in libpq and do double escaping in pg_basebackup
Patch by zboszor on 2013-02-19: Initial version.
Comment by zboszor on 2013-02-28: Hari Babu tested these two patches.
Committed Zoltán Böszörményi Heikki Linnakangas 2013-05-20
Server side lo-funcs name
Patch by aglio on 2013-06-17: Initial version.
Committed Tatsuo Ishii Robert Haas 2013-06-12
pgbench: introduce a new automatic variable 'client_number'
Patch by aglio on 2013-06-17: Initial version.
Committed Gurjeet Singh Heikki Linnakangas 2013-06-14
Pass buffer_std to MarkBufferDirtyHint()
Patch by jdavis on 2013-06-14: FSM callers pass buffer_std=false.
Review by jdavis on 2013-06-14: Andres: Comment improvements, and suggested rename XLOG_HINT -> XLOG_FPI.
Patch by jdavis on 2013-06-15: Clarify comments and rename XLOG_HINT to XLOG_FPI.
Committed Jeff Davis Andres Freund 2013-06-17
Removal of pageinspect--1.0.sql
Patch by aglio on 2013-06-17: Initial version.
Comment by michael-kun on 2013-06-18: This has been already committed by Heikki as 230e92c.
Committed Michael Paquier Nobody 2013-06-17
Make static the on-line doc ids referenced by phpPgAdmin project
Patch by kop on 2013-05-07: Initial version.
Comment by petere on 2013-06-18: already done in 9.3
Committed Karl O. Pinc Nobody 2013-06-18
SET work_mem = '1TB'
Patch by aglio on 2013-06-17: Initial version.
Review by jjanes on 2013-06-18: submitted new patch with my suggestions. Marked ready for committer
Patch by masaofujii on 2013-06-18: Updated version; Changed postgresql.conf.sample
Committed Simon Riggs Jeff Janes 2013-06-20
standalone versus single-user backends
Patch by jjanes on 2013-06-13: Initial version.
Committed Jeff Janes Nobody 2013-06-21
Clean switchover
Review by masaofujii on 2013-06-13: Updated patch
Review by andresfreund on 2013-06-24: looks fine, minor, minor stylistic points
Patch by andresfreund on 2013-06-24: v2, addressing some stylistic issues
Committed Fujii Masao Andres Freund 2013-06-26
Fix postmaster messages encoding
Patch by law on 2013-03-13: Initial version.
Patch by nmisch on 2013-06-23: Reviewed the submission; heavy revisions attached.
Comment by law on 2013-06-25: Modified patch is much better that the initial version, so I think it should be commited.
Committed Alexander Lakhin Noah Misch 2013-06-26
MemoryContextAllocHuge(): selectively bypassing MaxAllocSize
Patch by nmisch on 2013-05-14: Initial version.
Comment by nmisch on 2013-06-01: Could particularly benefit from verification that I didn't miss newly-relevant overflow cases in tuplesort.c.
Committed Noah Misch Stephen Frost, Simon Riggs, Jeff Janes 2013-06-27
add long options to pgbench
Patch by calvin on 2013-06-20: v3, diff wrt current master
Review by rhaas on 2013-06-25: missed pgbench --help, suggestions for better long option names
Patch by calvin on 2013-06-25: v4, with --help update & other suggestions by Robert Haas.
Committed Fabien Coelho Fabrízio de Royes Mello 2013-06-27
[bug fix] backend hangs at immediate shutdown
Comment by maiku41 on 2013-06-21: Changed to Waiting on Author based on review feedback.
Patch by alvherre on 2013-06-24: new version, needs tweak from submitter
Patch by maiku41 on 2013-06-28: Patch by maumau
Committed MauMau Álvaro Herrera 2013-06-28
Spin Lock sleep resolution
Patch by jjanes on 2013-04-02: Initial version.
Patch by jjanes on 2013-04-02: patch actually attached this time
Comment by maiku41 on 2013-06-21: Moved to Waiting on Author based on reviewer comments.
Committed Jeff Janes Heikki Linnakangas 2013-06-28
ALTER TABLE ... ALTER CONSTRAINT
Patch by simon on 2013-06-16: Initial version.
Review by ams on 2013-06-24: Looks fine
Committed Simon Riggs Abhijit Menon-Sen 2013-06-29
Fix error code of lock_timeout
Patch by zboszor on 2013-06-28: Initial version.
Committed Zoltán Böszörményi Simon Riggs 2013-06-29
makeFuncArgs
Patch by dfetter on 2013-06-28: Updated to current master, remove gratuitous whitespace changes.
Patch by dfetter on 2013-07-01: Updated to current master reflecting de-reserving OVER as a keyword
Review by jeevan.chalke on 2013-07-01: Looks good to go in. Thanks David.
Committed David Fetter Jeevan Chalke 2013-07-01
Pglz compression optimizations
Patch by heikki on 2013-04-30: Initial version.
Comment by amitkapila on 2013-06-20: some of the performance test for large data shows negative results.
Comment by maiku41 on 2013-06-28: Patch still under discussion as of 6/26.
Committed Heikki Linnakangas Amit Kapila 2013-07-01
set VPATH for out-of-tree extension builds
Comment by myon on 2013-05-30: I'd propose a simplification here:

srcdir = $(dir $(firstword $(MAKEFILE_LIST)))
VPATH = $(srcdir)

No need to do the $(dir...) stuff twice, I'd say.
Patch by c2main on 2013-06-18: Updated accordingly
Comment by maiku41 on 2013-06-29: Still being discussed as of 6/24
Committed Cédric Villemain Andrew Dunstan 2013-07-01
Fix build of extension regression data with VPATH
Patch by c2main on 2013-05-29: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Comment by maiku41 on 2013-06-28: Under discussion as of 6/26
Committed Cédric Villemain Andrew Dunstan 2013-07-01
fix SHLIB_PREREQS when building with USE_PGXS
Patch by c2main on 2013-05-29: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Committed Cédric Villemain Andrew Dunstan 2013-07-01
adds support for VPATH with USE_PGXS
Patch by c2main on 2013-05-30: Initial version.
Comment by c2main on 2013-06-18: Group all patches in a new thread.
Committed Cédric Villemain Andrew Dunstan 2013-07-01
extensible external toast tuple support
Patch by andresfreund on 2013-06-27: Patch addressing bug found during review and improving some comment improvments
Patch by andresfreund on 2013-07-02: v03
Review by andresfreund on 2013-07-02: Review by Robert with the advice to decouple on bit of the code.
Committed Andres Freund Hitoshi Harada, Robert Haas 2013-07-02
MVCC catalog access
Patch by rhaas on 2013-06-28: v4
Patch by andresfreund on 2013-07-02: v5
Review by andresfreund on 2013-07-02: Looks good, might need more changes after commit but that seems fine
Committed Robert Haas Andres Freund 2013-07-02
Mention extra_float_digits in floating point numbers chapter
Patch by laurenz on 2013-03-06: More elaborate version.
Review by ams on 2013-06-24: Some concerns, rewording proposed.
Patch by laurenz on 2013-06-24: New version.
Committed Laurenz Albe Abhijit Menon-Sen 2013-07-02
access to new error fields from PLpgSQL
Patch by okbobcz on 2013-06-25: fixed formatting
Review by nmisch on 2013-06-27: Let's rename DATATYPE_NAME, update the protocol docs to allow free-form use of these error fields, and back-patch this to 9.3
Patch by nmisch on 2013-07-02: Revised based on review
Committed Pavel Stehule Rushabh Lathia 2013-07-03
Add more regression tests for CREATE OPERATOR
Review by rhaas on 2013-06-27: needs to adhere to regression user conventions
Patch by robins on 2013-06-30: Updated patch as per robert's comments. prepend regress to role names.
Patch by robins on 2013-07-01: Added two more tests (pending from the discussion thread). Nothing more to add here.
Committed Robins Tharakan Szymon Guz 2013-07-03
Add more regression tests for ASYNC
Patch by robins on 2013-05-23: Initial version.
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Committed Robins Tharakan Szymon Guz 2013-07-03
Use posix_fallocate to build (new) WAL files
Patch by jdavis on 2013-06-18: New patch. Still has GUC in for testing purposes, which needs to be removed when Greg is finished with the performance evaluation.
Comment by aglio on 2013-06-28: Queried reviewers about testing progress.
Comment by jdavis on 2013-06-30: Responded to Greg Smith's request.
Committed Jon Nelson Andres Freund, Greg Smith, Jeff Davis 2013-07-05
Display number of changed rows since last analyze
Patch by markir on 2013-05-23: Initial version.
Review by laurenz on 2013-06-17: Patch is fine, documentation could be improved.
Committed Mark Kirkwood Laurenz Albe 2013-07-05
Fix conversion of Decimal arguments for plpython
Patch by ssinger on 2013-06-27: plpython_decimal_v6.patch - changes the numeric unit test so it outputs the same text in both cases (with and without) cdecimal installed
Patch by szymon on 2013-06-27: plpython_decimal_v7.patch - changes tests to check the class name
Patch by ssinger on 2013-06-28: plpython_decimal_v8.patch - changes tests to also include the value
Committed Szymon Guz, Ronan Dunklau Steve Singer 2013-07-06
XLogInsert scaling
Patch by heikki on 2013-06-19: Latest patch version.
Review by andresfreund on 2013-06-24: First read through the patch, some correctness, comment and algorithmic questions raised.
Comment by maiku41 on 2013-07-05: Under discussion as of 7/1
Committed Heikki Linnakangas Andres Freund, Abhijit Menon-Sen 2013-07-08
Add session_preload_libraries configuration parameter
Review by robins on 2013-06-29: Basic review of the patch
Comment by maiku41 on 2013-07-05: Needs additional reviewer to complete review.
Comment by dim on 2013-07-08: Ready for commit, let's have both local_preload_librairies and session_preload_librairies for awhile.
Committed Peter Eisentraut Dimitri Fontaine, Robins Tharakan 2013-07-13
Add regression tests for LOCK TABLE
Review by szymon on 2013-06-24: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Patch by robins on 2013-07-07: Updated as per Robert's feedback (prepend regress_xxx to ROLEs). Added to serial_schedule (missed out earlier).
Review by rhaas on 2013-07-15: Committed with significant changes
Committed Robins Tharakan Szymon Guz 2013-07-15
refresh materialized view concurrently
Review by umitanuki on 2013-07-09: One of the previous issues are not resolved yet. +1 issue.
Patch by kgrittn on 2013-07-09: Fixed all reported issues. Some question on whether error context for duplicate keys is OK.
Review by kgrittn on 2013-07-16: Brief review saying no problems found.
Committed Kevin Grittner Hitoshi Harada 2013-07-16
dynamic background workers
Review by maiku41 on 2013-06-21: Review by Michael Paquier: Minor comments and testing
Review by michael-kun on 2013-06-25: Review of 2nd patch: compilation, test and code review
Comment by maiku41 on 2013-07-05: Under discussion as of 4/3. Expecting updated patch.
Committed Robert Haas Michael Paquier 2013-07-16
add --progress option to pgbench
Review by calvin on 2013-07-01: Review by Mitsumasa.
Patch by calvin on 2013-07-01: v6 which includes Mitsumasa style suggestions.
Patch by calvin on 2013-07-11: v7 with updated error message, suggested by Tatsuo Ishii.
Committed Fabien Coelho Mitsumasa KONDO 2013-07-16
Add FILTER option to aggregates, as mandated by SQL standard.
Review by deanr on 2013-07-01: Review of updated patch. Looks good. Some minor doc issues.
Patch by dfetter on 2013-07-05: Updated docs per request
Patch by deanr on 2013-07-06: Fixes minor typo in docs. Marking ready for committer.
Committed David Fetter Dean Rasheed 2013-07-17
WITH CHECK OPTION for auto-updatable views
Patch by deanr on 2013-07-03: Rebased to apply cleanly to git master
Patch by deanr on 2013-07-05: Updated patch following Pavel's review.
Review by okbobcz on 2013-07-06: it ready for commiter
Committed Dean Rasheed Pavel Stehule 2013-07-18
simplify variadic "any"
Review by jeevan.chalke on 2013-06-27: Initial Review. Need few clarification on some changes.
Patch by okbobcz on 2013-06-30: more asserts, more comments
Review by jeevan.chalke on 2013-07-02: Looks good to go in now. Thanks Pavel.
Committed Pavel Stehule Jeevan Chalke 2013-07-18
Fix pgstattuple/pgstatindex to use regclass-type as the argument
Review by rlathia on 2013-07-16: Few comments in the code and documentation change ???
Comment by snaga on 2013-07-18: Comments by Masao Fujii.
Patch by snaga on 2013-07-18: Patch revised per review and comments.
Committed Satoshi Nagayasu Rushabh Lathia 2013-07-19
add --throttle to pgbench
Patch by calvin on 2013-07-17: v16 fixes conflicts introduced by a recent commit.
Patch by calvin on 2013-07-18: v17 with updated & extended documentation about "lag", asked by Tatsuo.
Patch by gsmith on 2013-07-22: v18 with more documentation updates
Committed Fabien Coelho Greg Smith 2013-07-22
logical changeset generation v5
Review by kgrittn on 2013-06-23: Each patch file in turn applies cleanly, builds without warning, and passes make check-world. More detailed review to come.
Comment by aglio on 2013-07-08: Ongoing discussion on use of the relcache and potential issues.
Comment by gsmith on 2013-07-23: Summary of partial commits completed
Committed Andres Freund Kevin Grittner, Robert Haas, Tom Lane, Steve Singer 2013-07-23
Add more regression tests mostly for ALTER OPERATOR FAMILY .. ADD/DROP
Patch by robins on 2013-05-23: Initial version.
Review by szymon on 2013-06-20: This patch applies cleanly on trunk code. All tests pass. The test coverage increses as provided. It works as described. Tests changes look good.
Committed Robins Tharakan Szymon Guz 2013-07-23
access to calls stack from GET DIAGNOSTICS statement
Patch by okbobcz on 2013-02-03: Initial version.
Review by rlathia on 2013-06-24: Submitted review points to the patch mail thread.
Patch by okbobcz on 2013-06-26: updated patch
Committed Pavel Stehule Rushabh Lathia 2013-07-24
UNNEST() (and other functions) WITH ORDINALITY
Patch by dfetter on 2013-07-03: More re-jiggering to reflect what's gone on on master.
Patch by gsmith on 2013-07-23: Update with some bug fixes
Patch by rhodiumtoad on 2013-07-25: Updated patch with more comments.
Committed Andrew Gierth, David Fetter Dean Rasheed, Jeevan Chalke 2013-07-29