Log In - Home Page

CommitFest 2012-11 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Needs Review: 1, Committed: 25, Returned with Feedback: 13, Rejected: 4. Total: 43.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Doc patch, distinguish sections with an empty row in error code table
Review by rhaas on 2012-11-05: not the right approach
Patch by kop on 2012-11-06: V2 of patch to fix the problem the "right way" using <tgroup>. Does not work, unless I've made a stupid mistake somewhere.
Comment by kop on 2012-12-10: Reject this patch? (Am I supposed to do this?)
Returned with Feedback Karl O. Pinc Robert Haas, Tom Lane 2012-11-05
Suggestion for --truncate-tables to pg_restore
Patch by kop on 2012-11-12: New patch to apply to latest head.
Review by schmiddy on 2012-12-05: Review of v4 patch.
Comment by kop on 2012-12-10: Reject this patch?
Returned with Feedback Karl O. Pinc Josh Kupershmidt 2012-12-04
pg_dump --extension-script
Patch by dim on 2012-11-12: Initial version.
Review by ali on 2012-12-05: Comments and Observations
Returned with Feedback Dimitri Fontaine Ali Dar 2012-12-05
Doc patch, further describe additive nature of the permission system
Patch by kop on 2012-10-02: Additional paragraph added (as separate patch file) regards roles
Patch by kop on 2012-10-02: Fix typeo in second patch. Latest version of both patch files attached.
Patch by kop on 2012-12-11: Another try.
Returned with Feedback Karl O. Pinc Nobody 2012-12-11
pg_dump --format=split
Patch by johto on 2012-10-22: Initial version.
Comment by dim on 2012-11-27: Review raising questions, needs more review and advice from a pg_dump guru.
Comment by alvherre on 2012-11-28: needs to handle circular dependencies in homonymous objects
Returned with Feedback Marko Tiikkaja, Joel Jacobson Dimitri Fontaine 2012-12-14
Doc patch, Add big fat caution to pg_restore docs regards partial db restores
Patch by kop on 2012-10-02: Initial version.
Comment by kop on 2012-10-02: I have mixed feelings about putting something so obvious in the docs.
Returned with Feedback Karl O. Pinc Peter Eisentraut 2012-12-16
Trim trailing NULL columns
Review by amitkapila on 2012-10-16: few review comments needs to be addressed.
Patch by amitkapila on 2012-10-19: updated patch to handle review comments.
Comment by simon on 2013-01-11: Performance tests show a reasonable gain in the extreme cases, but they are sensitive to exact layout of values. Performance regression of 1% on normal pgbench. Impact > benefit, so rejected from this CF. More work is possible in future.
Returned with Feedback Jameison Martin Josh Berkus, Amit Kapila 2013-01-11
Patch for option in pg_resetxlog for restore from WAL files
Patch by amitkapila on 2012-07-23: Initial version.
Comment by amitkapila on 2012-07-23: This patch is for providing an option in pg_resetxlog to restore the control file values from WAL files.
Comment by heikki on 2012-09-24: This should be refactored to make use of the generic xlogreader facility.
Returned with Feedback Amit Kapila Nobody 2013-01-11
Timing Events WIP v1
Patch by gsmith on 2012-11-15: Initial version.
Returned with Feedback Greg Smith Nobody 2013-01-13
2d-mapping based GiST for ranges
Patch by heikki on 2012-12-05: Latest version of the patch
Review by heikki on 2012-12-05: Review comments from Jeff Davis
Comment by jdavis on 2012-12-18: Duplicate of "Adjacent in SP-GiST for range-types".
Returned with Feedback Alexander Korotkov Nobody 2013-01-15
Make hugepage TLB usable for mmap()ed shared memory
Patch by cjk on 2012-10-30: Initial version.
Patch by cjk on 2012-11-01: Updated patch
Review by andresfreund on 2012-12-03: some small issues remaining
Returned with Feedback cjk Andres Freund 2013-01-15
logical changeset generation v3
Review by ssinger on 2012-12-09: Review of patch 9/14. This patch is ready for a committer
Patch by andresfreund on 2012-12-10: New version of the patch series addressing review comments (including a rebase onto a different xlogreader)
Review by pgeoghegan on 2012-12-13: Extensive, relatively high level review that summarises the current state of the patch.
Returned with Feedback Andres Freund Peter Geoghegan 2013-01-15
pg_trgm partial-match
Patch by masaofujii on 2012-11-16: Initial version.
Review by fuzzycz on 2012-11-19: initial review - mostly minor issues
Comment by masaofujii on 2012-11-23: Needs to implement the infra patch first.
Returned with Feedback Fujii Masao Tomas Vondra 2013-01-16