Log In - Home Page

CommitFest 2012-09 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 20, Returned with Feedback: 20, Rejected: 5. Total: 45.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
Add hooks for pre- and post-processor executables for COPY and \copy
Patch by efujita on 2012-09-18: Initial version.
Returned with Feedback Etsuro Fujita Nobody 2012-09-20
WIP checksums patch
Patch by jdavis on 2012-09-15: Initial version.
Returned with Feedback Simon Riggs, Jeff Davis Nobody 2012-10-09
sortsupport for text
Patch by rhaas on 2012-03-02: Initial version.
Comment by sternocera on 2012-06-19: I'd like us to find a way to shoehorn the use of strxfrm() into this patch.
Comment by pgeoghegan on 2012-10-08: Can we please wrap this one up?
Returned with Feedback Robert Haas Peter Geoghegan 2012-10-09
Identity projection
Patch by horiguti on 2012-09-14: Initial version. I'll consider on this patch further and post next version.
Returned with Feedback Kyotaro Horiguchi Nobody 2012-10-17
Reduce palloc's in numeric operations.
Patch by horiguti on 2012-09-14: Initial version.
Review by heikki on 2012-09-19: Small amount of work needed.
Returned with Feedback Kyotaro Horiguchi Heikki Linnakangas 2012-10-17
BUG #6412: psql & fe-connect truncate passwords
Patch by rhaas on 2012-09-06: Initial version.
Review by heikki on 2012-09-20: Needs a little bit of work
Returned with Feedback Andy Grimm Heikki Linnakangas 2012-10-17
[06] Add support for a generic wal reading facility dubbed XLogReader
Review by heikki on 2012-06-18: Should refactor ReadRecord to use the new API.
Patch by andresfreund on 2012-08-02: Patch v2 addressing some/most of the review from Heikki and rebasing it after the recent xlog refactoring.
Patch by alvherre on 2012-10-10: Latest version from Heikki
Returned with Feedback Andres Freund Heikki Linnakangas 2012-10-18
pgbench - aggregation of info written into log
Patch by fuzzycz on 2012-08-24: Initial version.
Patch by fuzzycz on 2012-09-20: updated version of the patch - there are two things to fix right now (timestamps windows and handling the last interval)
Review by okbobcz on 2012-10-04: there are some issues still
Returned with Feedback Tomas Vondra Pavel Stehule 2012-10-18
dropping multiple tables in a transaction
Patch by fuzzycz on 2012-08-24: Initial version.
Review by hanada on 2012-10-17: It seems reasonable, but it needs some refactoring such as avoiding code duplicate.
Returned with Feedback Tomas Vondra Shigeru Hanada 2012-10-18
xlog filename formatting functions in recovery
Patch by fdr on 2012-07-03: Initial version.
Comment by heikki on 2012-09-21: Need to decide which tli to report
Returned with Feedback Daniel Farina Heikki Linnakangas 2012-10-18
pg_stat_lwlocks view - lwlocks statistics
Patch by snaga on 2012-10-13: The 2nd patch.
Fixed to support local and global (shared) statistics in the same system view.
Fixed to collect global statistics via pgstat collector process.
Fixed to split PgStat_GlobalStats for different uses, BgWriter stats and LWLock stats.
Patch by snaga on 2012-10-13: Fixed wrong array indexes.
Review by masaofujii on 2012-10-13: The patch causes measurable performance overhead. Needs mechanism to avoid that.
Returned with Feedback Satoshi Nagayasu Fujii Masao 2012-10-23
New statistics for WAL buffer dirty writes
Review by jjanes on 2012-08-11: Needs documentation.
Probably needs function to show reset time.
Is it OK for counts not to survive a restart?
Patch by snaga on 2012-09-25: Revised to use the stat collector process instead of writing shared memory directly. So, the statistics could be kept on restart, and could be reset by pg_stat_reset_shared('walwriter').
Review by alvherre on 2012-10-23: some remaining items
Returned with Feedback Satoshi Nagayasu Jeff Janes 2012-10-23
Visual Studio 2012 build support
Review by nmisch on 2012-10-02: Functionally flawless. Add/fix some comments; doc changes to consider
Review by nmisch on 2012-10-08: Problems for a 32-bit build
Review by nmisch on 2012-10-23: In an NLS build, IsoLocaleName() needs to account for a CRT internals change
Returned with Feedback Brar Piening Noah Misch 2012-10-23
pgbench - custom logging step, estimate of remaining time
Patch by fuzzycz on 2012-09-16: Initial version.
Review by alvherre on 2012-10-23: a command line switch seems awkward to use
Returned with Feedback Tomas Vondra Pavel Stehule 2012-10-23
Array ELEMENT Foreign Keys
Patch by mnencia on 2012-10-10: Refreshed patch, loose ends fixed
Patch by tgl on 2012-10-24: v3 patch, still very much WIP
Review by tgl on 2012-10-24: I think we can't commit without some solution for this performance issue.
Returned with Feedback Marco Nenciarini, Gabriele Bartolini, Gianni Ciolli Rafal Pietrak, Noah Misch 2012-10-24
wal decoding, attempt #2
Review by pgeoghegan on 2012-10-10: My initial thoughts on this patch.
Comment by pgeoghegan on 2012-10-18: New design document from Andres concerning the snapshot building aspect of the patch
Review by pgeoghegan on 2012-10-19: Further review focused on the snapshot building aspect of the patch.
Returned with Feedback Andres Freund Peter Geoghegan 2012-10-25
copy result to psql variables
Patch by okbobcz on 2012-10-17: fixed bug FETCH_COUNT=1 case.
Review by phils on 2012-10-24: Overall +1. Couple a points that I laid out in email.
Review by alvherre on 2012-10-25: avoid touching the lexer
Returned with Feedback Pavel Stehule Shigeru Hanada 2012-10-25
Performance Improvement by reducing WAL for Update Operation
Review by nmisch on 2012-10-25: CPU-bound performance numbers: LZ has a nontrivial penalty, delta encoding is OK
Patch by nmisch on 2012-10-26: v3 of delta encoding variant
Review by nmisch on 2012-10-26: Latest version does not address all prior review comments. Some new bugs.
Returned with Feedback Amit Kapila Noah Misch, Heikki Linnakangas 2012-10-26
Performance Improvement in Buffer Management for Select operation
Patch by amitkapila on 2012-09-11: Initial version.
Returned with Feedback Amit Kapila Nobody 2012-10-29
FOR KEY SHARE foreign keys
Patch by alvherre on 2012-08-31: v21
Patch by alvherre on 2012-10-18: v22
Comment by andresfreund on 2012-10-26: First round of code review
Returned with Feedback Álvaro Herrera Simon Riggs, Andres Freund 2012-11-05