Log In - Home Page

CommitFest 2012-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Rejected".

Status Summary. Committed: 35, Returned with Feedback: 26, Rejected: 8. Total: 69.

Rejected Patches

Patch Name Status Author Reviewers Date Closed
Optimize IS DISTINCT FROM NULL => IS NOT NULL
Patch by intgr on 2012-03-08: Initial version.
Review by intgr on 2012-03-09: Tom thinks we should keep this simple
Rejected Marti Raudsepp Tom Lane 2012-03-08
Fix little typo in a comment in contrib/file_fdw
Patch by efujita on 2012-04-11: Initial version.
Comment by schmiddy on 2012-04-21: Tom says fine as-is
Rejected Etsuro Fujita Tom Lane 2012-04-11
pgbench new transaction type
Patch by gsmith on 2011-06-13: Initial version.
Review by gsmith on 2011-06-19: Performance confirmed, needs docs and some adjustments
Patch by jjanes on 2012-06-14: updated patch
Rejected Jeff Janes Greg Smith, Heikki Linnakangas 2012-06-20
Make checkpointer look checkpoint_segments on standbys
Patch by horiguti on 2012-06-08: Initial version.
Rejected Kyotaro Horiguchi Greg Smith, Simon Riggs 2012-06-29
Lazy hashaggregate when no aggregation is needed
Patch by antsaasma on 2012-03-28: Initial version.
Comment by rhaas on 2012-06-26: ping
Rejected Ants Aasma Etsuro Fujita 2012-07-02
Restrict ALTER FUNCTION CALLED ON NULL INPUT
Patch by nmisch on 2012-06-11: Initial version.
Review by rhaas on 2012-07-20: no consensus on this approach; further discussion of what to do
Rejected Noah Misch Tom Lane 2012-07-20
Add value_to_json(anyelement) to allow conversion/escaping of scalars to JSON
Patch by ringerc on 2012-08-13: Initial version.
Review by ringerc on 2012-08-13: Bounced; the `json' type isn't supposed to ever have SQL-visible scalar values.
Rejected Craig Ringer Tom Lane 2012-08-13
NOT NULL violation error handling in file_fdw
Patch by efujita on 2012-04-18: fix a bug in fileGetOptions(), rename the validation option and clean up
Patch by jjanes on 2012-07-13: link v4 of patch into commitfest app
Comment by rhaas on 2012-08-20: there is no consensus that we want this; both tgl and I have expressed reservations
Rejected Etsuro Fujita Dimitri Fontaine 2012-08-20