Log In - Home Page

CommitFest 2012-06 (Closed)

New Patch - Activity Log - CommitFest Topics

The most recent three comments for each patch will be displayed below. To view all the comments for a particular patch, or to add a comment or make other changes, click on the patch name.

Filtering on status "Returned with Feedback".

Status Summary. Committed: 35, Returned with Feedback: 26, Rejected: 8. Total: 69.

Returned with Feedback

Patch Name Status Author Reviewers Date Closed
smart shutdown at end of transaction
Patch by rhaas on 2012-04-27: Initial version.
Returned with Feedback Robert Haas Nobody 2012-06-07
ECPG FETCH readahead
Patch by zboszor on 2012-03-29: Fixed some cosmetic points, explained policy
Patch by zboszor on 2012-03-30: No 0-vs-1 distinction in the runtime. Less MOVEs. Documentation updates.
New 2nd patch without NO READAHEAD and modified docs.
Comment by meskes on 2012-04-24: Zoltan himself found a hole and has to redo parts of the patch
Returned with Feedback Zoltán Böszörményi Noah Misch 2012-06-13
autocomple - CREATE OR REPLACE FUNCTION
Patch by okbobcz on 2012-02-20: Initial version.
Review by petere on 2012-04-10: some problems to solve
Returned with Feedback Pavel Stehule Dean Rasheed 2012-06-13
[02][TRIVIAL] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0}
Patch by andresfreund on 2012-06-13: Initial version.
Review by rhaas on 2012-06-14: Redundant with existing InvalidXLogRecPtr
Returned with Feedback Andres Freund Robert Haas 2012-06-14
[03] Add a new syscache to fetch a pg_class entry via its relfilenode
Patch by andresfreund on 2012-06-13: Initial version.
Review by rhaas on 2012-06-14: Review.
Returned with Feedback Andres Freund Robert Haas 2012-06-14
Foreign keys with arrays
Comment by nmisch on 2012-06-10: No longer applies
Comment by mnencia on 2012-06-14: The patch wil be splitted and summitted to the next commitfest
Comment by mnencia on 2012-08-01: This patch has been abandoned in favour of the new "Array ELEMENT foreign key" patch
Returned with Feedback Marco Nenciarini, Gabriele Bartolini, Gianni Ciolli Noah Misch 2012-06-14
Making truncate MVCC-safe
Patch by jdavis on 2012-04-21: Initial version.
Patch by jdavis on 2012-04-21: New patch from Simon
Comment by nmisch on 2012-06-10: Author doubts
Returned with Feedback Marti Raudsepp, Simon Riggs Robert Haas 2012-06-20
[13] Introduction of pair of logical walreceiver/sender
Patch by andresfreund on 2012-06-13: Initial version.
Comment by andresfreund on 2012-06-29: Decoding/catalog syncing infrastructure isn't far along yet to make this interesting beyond whats already done so far.
Returned with Feedback Andres Freund Alexander Korotkov 2012-06-29
[15] Activate/Implement the "apply process" which applies received updates from another node
Patch by andresfreund on 2012-06-13: Initial version.
Comment by andresfreund on 2012-06-29: At this point it doesn't seem important to review this patch. Other things need to be decided beforehand.
Returned with Feedback Andres Freund Nobody 2012-06-29
Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Patch by chetan on 2012-02-08: now uses the recommended name SPI_gettypmod().
Review by amitkapila on 2012-06-18: Documentation needs to be updated.
Comment by rhaas on 2012-06-28: ping
Returned with Feedback Chetan Suttraway Amit Kapila 2012-07-03
Prevent the specification of conflicting transaction read/write options
Patch by chetan on 2012-02-08: Initial version.
Review by amitkapila on 2012-06-18: Test regression needs to updated and the code needs to be changed for review comments.
Returned with Feedback Chetan Suttraway Amit Kapila 2012-07-03
relation metapages
Patch by rhaas on 2012-06-14: Initial version.
Review by aevernon on 2012-07-01: Does not apply cleanly to current Git master.
Returned with Feedback Robert Haas Albert Vernon 2012-07-16
[10] Introduce the concept that wal has a 'origin' node
Patch by andresfreund on 2012-06-13: Updated patch fixing a stupid mismerge.
Review by ssinger on 2012-06-18: Some naming suggestions, a places code from a later patch was included in this one
Comment by andresfreund on 2012-06-18: New version of patch in git-tree, addressed most comments in review (except configuration variable naming, it seems to be to early to settle on anything at this point ;))
Returned with Feedback Andres Freund Steve Singer, Simon Riggs 2012-07-17
[11] Add infrastructure for manipulating multiple streams of wal on a segment handling level
Patch by andresfreund on 2012-06-13: Initial version.
Review by zboszor on 2012-06-29: Doesn't apply cleanly to current GIT.
Returned with Feedback Andres Freund Nobody 2012-07-20
[14] Add module to apply changes from an apply-cache using low-level functions
Patch by andresfreund on 2012-06-13: Initial version.
Review by smagen on 2012-07-01: Review
Returned with Feedback Andres Freund Alexander Korotkov 2012-07-20
Allow CREATE FOREIGN TABLE to take LIKE
Patch by dfetter on 2012-03-28: Initial version.
Comment by deanr on 2012-06-23: Some review comments from Thom, Alvaro and me. Needs some doc additions. Should use RELKIND #defines instead of char literals. Supported like_options need a bit of work.
Returned with Feedback David Fetter Dean Rasheed 2012-07-20
transforms
Patch by petere on 2012-06-14: Initial version.
Review by andresfreund on 2012-06-18: a first review while reading the patch to get an idea what it actually does
Patch by rhaas on 2012-07-20: new patch, but petere says this won't be done this CF
Returned with Feedback Peter Eisentraut Andres Freund 2012-07-20
pgsql_fdw contrib module
Patch by hanada on 2012-04-07: v20 patch, use libpq row processor API, and support ANALYZE.
Patch by hanada on 2012-06-14: Rebased for 9.3, with some fixes.
Review by kaigai on 2012-06-26: This patch has many improvements from the previous commit fest, but still some problems are remained.
Returned with Feedback Hanada Shigeru KaiGai Kohei, Laurenz Albe 2012-07-20
pg_prewarm
Patch by rhaas on 2012-04-09: v2, with documentation improvements.
Review by jjanes on 2012-07-07: review
Review by singh.gurjeet on 2012-08-21: Review of the code implementation.
Returned with Feedback Robert Haas singh.gurjeet, Jeff Janes 2012-07-20
autocomplete SELECT fx
Comment by petere on 2012-04-10: There was some debate about this.
Review by schmiddy on 2012-06-19: Review of Pavel's and Peter's overlapping patches. Some small technical issues in Peter's patch, plus the debate Peter noted.
Comment by schmiddy on 2012-07-23: Peter not satisfied with function autocomplete.
Returned with Feedback Pavel Stehule, Peter Eisentraut Josh Kupershmidt 2012-07-23
Allow breaking out of hung connection attempts
Review by hanada on 2012-07-10: Need to resolve CPU consumption issue.
Patch by jjanes on 2012-07-13: linking v6 patch into commitfest app
Review by heikki on 2012-07-18: A couple of issues remain
Returned with Feedback Ryan Kelly Shigeru Hanada, Heikki Linnakangas 2012-07-23
[08] Introduce the ApplyCache module which can reassemble transactions from a stream of interspersed changes
Patch by andresfreund on 2012-06-13: Initial version.
Review by ssinger on 2012-06-21: design review covering options on how transactions can be grouped for apply
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[09] Decode wal (with wal_level=logical) into changes in an ApplyCache instance
Patch by andresfreund on 2012-06-13: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[12] Add state to keep track of logical replication
Patch by andresfreund on 2012-06-13: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
[07] Log enough data into the wal to reconstruct logical changes from it if wal_level=logical
Patch by andresfreund on 2012-06-20: Initial version.
Returned with Feedback Andres Freund Simon Riggs 2012-08-02
FOR KEY SHARE
Patch by alvherre on 2012-06-25: v14 fixes the make failures and merges to current master
Patch by jjanes on 2012-07-13: update commit fest app to newest v17 patch
Comment by rhaas on 2012-08-20: already added to next CF
Returned with Feedback Álvaro Herrera Kevin Grittner 2012-08-20